Received-SPF: pass (google.com: domain of linux-kernel+bounces-180191-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Feedback-ID: i1719461a:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-456-gcd147058c-fm-hotfix-20240509.001-g0aad06e4
Precedence: bulk
MIME-Version: 1.0
Message-Id: <2419538f-199c-4404-9af4-e17259e09cf4@app.fastmail.com>
In-Reply-To: <c927c490-bc22-45d9-87e4-4156746547f9@gmx.de>
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
 <20240511023726.7408-4-lsanche@lyndeno.ca>
 <c927c490-bc22-45d9-87e4-4156746547f9@gmx.de>
Date: Wed, 15 May 2024 11:06:43 -0600
From: "Lyndon Sanche" <lsanche@lyndeno.ca>
To: "Armin Wolf" <W_Armin@gmx.de>
Cc: "Mario Limonciello" <mario.limonciello@amd.com>,
 =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
 srinivas.pandruvada@linux.intel.com,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
 "kernel test robot" <lkp@intel.com>, "Hans de Goede" <hdegoede@redhat.com>,
 "Yijun Shen" <Yijun.Shen@dell.com>, "Matthew Garrett" <mjg59@srcf.ucam.org>,
 "Heiner Kallweit" <hkallweit1@gmail.com>,
 "Randy Dunlap" <rdunlap@infradead.org>, "Jonathan Corbet" <corbet@lwn.net>,
 "Vegard Nossum" <vegard.nossum@oracle.com>,
 platform-driver-x86@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
 Dell.Client.Kernel@dell.com
Subject: Re: [PATCH v6 2/2] platform/x86: dell-laptop: Implement platform_profile
Content-Type: text/plain


On Sun, May 12, 2024, at 12:05 PM, Armin Wolf wrote:
> Am 11.05.24 um 04:36 schrieb Lyndon Sanche:
>

>> +static int thermal_init(void)
>> +{
>> +	int ret;
>> +	int supported_modes;
>> +
>> +	/* If thermal commands not supported, exit without error */
>> +	if (!dell_laptop_check_supported_cmds(CLASS_INFO))
>> +		return 0;
>> +
>> +	/* If thermal modes not supported, exit without error */
>> +	ret = thermal_get_supported_modes(&supported_modes);
>> +	if (ret < 0)
>> +		return ret;
>
> Hi,
>
> the function dell_smbios_error() says that when a specific functionality is
> not supported, -ENXIO is returned.
>
> Please treat this as "no thermal modes supported", since checking if CLASS_INFO
> is supported is not enough (CLASS_INFO is also used by other functionality like
> rfkill, so machines might support CLASS_INFO but not USTT).
>
> Thanks,
> Armin Wolf
>

Armin:

Thank you for this. I will include this in the next revision.

Thanks,

Lyndon