Received-SPF: pass (google.com: domain of linux-kernel+bounces-179882-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 15 May 2024 15:12:04 +0200
From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: linan666@huaweicloud.com, song@kernel.org, linux-raid@vger.kernel.org,
 linux-kernel@vger.kernel.org, yi.zhang@huawei.com, houtao1@huawei.com,
 yangerkun@huawei.co, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] md: do not delete safemode_timer in mddev_suspend
Message-ID: <20240515151204.0000113d@linux.intel.com>
In-Reply-To: <33185f65-b657-b15b-ffa8-e35319fa0a5f@huaweicloud.com>
References: <20240508092053.1447930-1-linan666@huaweicloud.com>
	<33185f65-b657-b15b-ffa8-e35319fa0a5f@huaweicloud.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 9 May 2024 09:34:15 +0800
Yu Kuai <yukuai1@huaweicloud.com> wrote:

> However, since this behaviour is introduced since 2012, does anybody
> really care about array status is 'active' instead of 'clean' while
> there is no IO after suspend?

It may cause rebuild after reboot (bad but we can live with it) or platform hang
(this is bad). mdadm is waiting for transition to clean on shutdown if I
remember correctly.
Probably nobody tried that as we all know that Linux doesn't like suspending
and this is rare to reboot platform just after suspend. Probably any write will
fix it.

But this is all based on my knowledge, not tested or proved however I believe
that it gives light where to look for problems if you want.

Mariusz