Received-SPF: pass (google.com: domain of linux-kernel+bounces-180236-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Naohiro Aota <Naohiro.Aota@wdc.com>
To: Johannes Thumshirn <jth@kernel.org>
CC: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>, David Sterba
	<dsterba@suse.com>, Hans Holmberg <Hans.Holmberg@wdc.com>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Johannes
 Thumshirn <Johannes.Thumshirn@wdc.com>
Subject: Re: [PATCH 2/2] btrfs: reserve new relocation zone after successful
 relocation
Thread-Topic: [PATCH 2/2] btrfs: reserve new relocation zone after successful
 relocation
Thread-Index: AQHapkOklbppV3Xln0eYnqZCoPqOErGYlyoA
Date: Wed, 15 May 2024 18:01:08 +0000
Message-ID: <ntbfehck4zi2vns3773bo7f5mlxclka36fwfphkzdnbz3k37nc@ojamkclv2w4n>
References: <20240514-zoned-gc-v1-0-109f1a6c7447@kernel.org>
 <20240514-zoned-gc-v1-2-109f1a6c7447@kernel.org>
In-Reply-To: <20240514-zoned-gc-v1-2-109f1a6c7447@kernel.org>
Accept-Language: ja-JP, en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?GQSVO+BzhVcDbiU+r2qtVRiTp/bfBslFniMdem3DHEO/YDgkBDDX3OQRvDJI?=
 =?us-ascii?Q?p4xEcK+oYUSz/gr7Jhta25SpWTuLJx4wVT69p2mFwrDT2QAbvaD87DDQF+aF?=
 =?us-ascii?Q?xt0yWjRNoxIyT/cJpwwo3U8fo1a++e3RxDqBsRNQQBT1YhsBp+DpjhMpdd5D?=
 =?us-ascii?Q?EoYa4MMrFbW8nOP2h+iB8J2Rg4W6w/vbde29SpfsJ0hQKlexgo4vSXa02Lpl?=
 =?us-ascii?Q?UhZT/9btxD5ZoN+aoqkUG6v/+8Xi6yqNZpJXTyr5NId3fmW+D59gWrLAi85Y?=
 =?us-ascii?Q?PMFDImP8OmLl0c3LqSS7bd0r7xWS2bPU9j/kSitrXvkSDZlumjwb7LHEfV90?=
 =?us-ascii?Q?dmWCY7QHsOhH15klEq5AHweIvXBDoN0mzIU5nMLLWJfqGYKpKwoZ1bJ5Y/2t?=
 =?us-ascii?Q?aeB9gl9NC+n/DIQ8ViG4D5HhCY+dgTuzh6c4O4oUEA+BTqmz5jfBrd2qvzS8?=
 =?us-ascii?Q?y+RzfMlUM/GPHNzBXc1QoJe67EIaPnZzW3EBDU6W8Dff9SKkEnq1gbIHQf/T?=
 =?us-ascii?Q?zamZUp3Puxasx+1IQ2bIlWBZ7BpGB+Ckmux9qQG4mnDMrnm2jvtz7E4Sauvt?=
 =?us-ascii?Q?QwMcpDvbRrjk89S1Uvp+KlGE16O3CWOV7cN2kIWCbCtDnvvmWrlCWMJrGuoM?=
 =?us-ascii?Q?TRH375nmY1wAIX63AiaQZT76tQtb2Bm+c9kOwv9Qi1v1zmHojExQfVSIDMKc?=
 =?us-ascii?Q?od6XkeMkuYPHanD3VMNnXhRrFYUftYM5j4eH4CRXZj6W8bGdb9P4m9ZvTncx?=
 =?us-ascii?Q?q7XfhVEZBPYxg3AtwbABF9APuj1Tacx67t5rWTaueDI/SI6JcRlL4D86RA/E?=
 =?us-ascii?Q?DjnMEafv7hACZBJRqWcz4EwzAWCsL1Gv0qXiOE4lX+ZU2ibcgyBIMUE+wAbr?=
 =?us-ascii?Q?cyOtjLdNcCMRneQdZ3Z854tBKDBGuVjR7PF/uHhgsWilCcR9FlUBYzGdpn3U?=
 =?us-ascii?Q?NSgYwWjmR1MKU9i3wUrIwuv0iwUFM2jvljiryEPpYCsW5vFnfyv+Bct8GiKx?=
 =?us-ascii?Q?2SkJi+/3MUkEMbXQH5WuPE/ZGAD7ABXogLPo16Fa6s5hB9XbWrWrLN9rNrZG?=
 =?us-ascii?Q?E0dGpKFgVxFsnndbZ+bJ2+wDSuz5A3I3wp3waD1ofIi69A00i1z+rX7KETvJ?=
 =?us-ascii?Q?7DIEbddMiNnvwixx2uFqXyPFblFzq+G0lK6yXNlGZZCDF4PBRk/xV/2ypuGT?=
 =?us-ascii?Q?D4vH5dVUEhmUePuwUSBNOlDDlzI5Tom+7j7i85OVfC3SsvQrEqa5AqSRaaMr?=
 =?us-ascii?Q?+ldwL7bNwiPM1NLTKVBaV0vH0uoBV2RB278ep1/zrm76bFPvmyIq/iLb9Pai?=
 =?us-ascii?Q?HkoN58MGGCQnsX2JOvWcpZi8YkmH+a/GVPqiaWKSr3fAMamfUVy09zl0ZNlL?=
 =?us-ascii?Q?o2eW0HKkaDem5tZCHr2TG3BCw4wrwvnofiZl4BL6eFKdI9NZVpuH9kpNmYXd?=
 =?us-ascii?Q?/v6KJSj2V/CJMfW34MczcSMnWGWhNVNi791ba1dumRr4RTJJgviPy/9FdJRQ?=
 =?us-ascii?Q?gFhO8eys7vn82smwNiQYKQARGLGfRiuEotV+6v3/+JhKLB9JriFifBhp9E+q?=
 =?us-ascii?Q?dNTzrIDND2aLMqXP58rNVUGwkyeUhjpZKID8odx3?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BE5B11D77B92DF49BBD7A6439228A45C@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	COBqJ+ALY8cgFskWdToj/3QsbFAjfVXXcPDZSG30qercYUQaTCNYtHRLHECbF0/dktcFiETfAu1D0qnSxv4R6yRW6CFcBAshOoqh4wxHTJd5qjiYxsFL1pPphRkaToJlVrpqPV5YbQ0WxW0tGJG/KdFhQrw5XgyCoM4PoiOmLNNySMG3w8ExE+ccx051FjZ8SwSq57ma5m0Hm+Tzt8a+H+DO6LWTHvkN8Gt8O9KF3XAL3ZHZGKsIoUZHo865NsAnjGQ3huO6GAxDdRF1C9Cg23hBAaB4S83xj7zDhP6HCAs4hEwIJ58mXfg8xYR5cnXfkoL0/Zutyy5V9UX+l/dFZclaz4csZ6C+EWcSIKM4xsjpK6MmiVKH6/8ZBhjiRBFglMgzma0wLqcmpi2sraPngz8oaNohkzsYr/NNxuwDlciNj1Xzn9ezB6iZu0kkDBJzNho+mw4LmfJENzrR8ltO9+yBLIuibBP3+NSRJ32szdj56qqwJqrr9zI1jUCvNGzVOhlu9Mn7J3kPSggM9+TaSEYmWhXy/HowPaofeTVRlnh1cE3oF0RZbjnlw3wBScutQBh5EgKuKTaiHfPTLGo67snjWGP3lwNcOs2Nsq7yynRTAVR1jKA0LlBccMRJ5P8U
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR04MB7776.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a7d17d7-0fa8-416c-dd92-08dc7508ff2a
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2024 18:01:08.0892
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LH8rxksl/JzIb14A7ZIHd6ggN5eCVIegiHoEllNNRNQMf8jCefhZ2zmmKnWT520OH3Yrbk/CiDqx3OL50GtCUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR04MB7236

On Tue, May 14, 2024 at 11:13:22PM +0200, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>=20
> After we've committed a relocation transaction, we know we have just free=
d
> up space. Set it as hint for the next relocation.
>=20
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---
>  fs/btrfs/relocation.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
> index 8b24bb5a0aa1..d943abf5cb33 100644
> --- a/fs/btrfs/relocation.c
> +++ b/fs/btrfs/relocation.c
> @@ -3808,9 +3808,13 @@ static noinline_for_stack int relocate_block_group=
(struct reloc_control *rc)
>  		err =3D PTR_ERR(trans);
>  		goto out_free;
>  	}
> +
>  	ret =3D btrfs_commit_transaction(trans);
>  	if (ret && !err)
>  		err =3D ret;
> +
> +	/* We know we have just freed space, set it as hint for the next reloca=
tion */
> +	btrfs_reserve_relocation_zone(fs_info);

With "if (!err)"? We definitely bail out fast in an error case.

>  out_free:
>  	ret =3D clean_dirty_subvols(rc);
>  	if (ret < 0 && !err)
>=20
> --=20
> 2.35.3
> =