Received-SPF: pass (google.com: domain of linux-kernel+bounces-180267-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Valentin Obst <kernel@valentinobst.de>
To: mhiramat@kernel.org
Cc: a.hindborg@samsung.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	gregkh@linuxfoundation.org,
	hpa@zytor.com,
	john.m.baublitz@gmail.com,
	kernel@valentinobst.de,
	linux-kernel@vger.kernel.org,
	mingo@kernel.org,
	mingo@redhat.com,
	ojeda@kernel.org,
	peterz@infradead.org,
	sergio.collado@gmail.com,
	stable@vger.kernel.org,
	tglx@linutronix.de,
	x86@kernel.org
Subject: Re: [PATCH v3] x86/tools: fix line number reported for malformed lines
Date: Wed, 15 May 2024 20:17:16 +0200
Message-ID: <20240515181716.3313-1-kernel@valentinobst.de>
In-Reply-To: <20240403091748.ee180a7a1d4bf92e0c46fb8a@kernel.org>
References: <20240403091748.ee180a7a1d4bf92e0c46fb8a@kernel.org>
Precedence: bulk
MIME-Version: 1.0
UI-OutboundReport: notjunk:1;M01:P0:CUGfVys0O1E=;LeLgmglAvO6+O7ly0QdmWWvmXNB
 IUE18NMJearSvvzLQ5B/cEXEthivYfvTsI6x1ycGX1c84XTosfMb5Gg4aaKmTFoOeoEMgXRai
 OalavXFvI41+rX8PaKecKrUM0b//tZy/Wwf6rU1/MJ060c+Ulid0Tztl9Us5QOaJ/Eo+pSkPA
 qKWEjDaa0RZBy13MzzH0ncJAZJfMx0UGlgF7tseGMinH2+pew/fdDoNiOPI0O2wwf1O+ixdRK
 L07PEypW8DTPLoMJ3ziRAv861oM2NSrr8ZdmJDC381ZneYCsT1hOB8MidkJiG9kLynDnIGcri
 OqjKK0NnFgLB4ecll2Dlx9nt2QiWLbD/wlUcgZO4cypNvr+aGfVcwbi/zz7BvB//aMnhqyrlo
 OTvaDKqNTChT8VJmAfWFnd34lXebm9mZvNHCUp2JiuZyS4zWmUT6eNojwdwv/+pIwhOyqd43C
 VyBMGTRW6BN8ps3aXk2UA9dtaVcipTF9WVBNcJIkFCFN6zF1ZjpT/3S2kI0uU+oqE8o+y0Wmw
 vKiiTB2w2c4iHN3pquAt4heraFi6AhGewEpkwbzx0NnEReCjlC82i87gK8Fo6O2q2VmbuOvoW
 7uqu6T6n6rBG2ZcrbhV7//oXhwIZUz2oD5jFPYKSGJFVcAAJ76K58ni51XmP2zzA8tEoCykN2
 /G1zy5SzoMs4YgERH3vA5mPllsBy0yS4h0sdJHmlu8ru7rapGYl0JP0vLMtk/Ka3GZUQMFGci
 aub9+5PoF//aMllPmgXnqBb3uS8tu6qxQghdyIwT6EBJCM3etPDrSw=

> > Commit 35039eb6b199 ("x86: Show symbol name if insn decoder test failed")
> > included symbol lines in the post-processed objdump output consumed by
> > the insn decoder test. This broke the `instuction lines == total lines`
> > property that `insn_decoder_test.c` relied upon to print the offending
> > line's number in error messages. This has the consequence that the line
> > number reported on a test failure is unreated to, and much smaller than,
> > the line that actually caused the problem.
> >
> > Add a new variable that counts the combined (insn+symbol) line count and
> > report this in the error message.
>
> This looks good to me. Thanks!
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thanks!

So what is the status on this one? Is there someone here who can take it
through their tree s.t. it might make it into 6.10-rc1 or 6.11-rc1?

	- Best Valentin

>
> >
> > Fixes: 35039eb6b199 ("x86: Show symbol name if insn decoder test failed")
> > Cc: stable@vger.kernel.org
> > Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
> > Tested-by: Miguel Ojeda <ojeda@kernel.org>
> > Reported-by: John Baublitz <john.m.baublitz@gmail.com>
> > Debugged-by: John Baublitz <john.m.baublitz@gmail.com>
> > Signed-off-by: Valentin Obst <kernel@valentinobst.de>
>
> --
> Masami Hiramatsu (Google) <mhiramat@kernel.org>