Date: Thu, 31 Jan 2008 06:36:51 -0800
From: Arjan van de Ven <arjan@infradead.org>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
       Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] x86: EFI memory mapping changes according to
 changes to ioremap and c_p_a
Message-ID: <20080131063651.678c6652@laptopd505.fenrus.org>
In-Reply-To: <1201764968.12950.26.camel@caritas-dev.intel.com>
References: <1201764968.12950.26.camel@caritas-dev.intel.com>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 794
Lines: 20

On Thu, 31 Jan 2008 15:36:08 +0800
"Huang, Ying" <ying.huang@intel.com> wrote:

> The patch fixes EFI runtime memory mapping code according to the
> changes to ioremap() and change_page_attr().

this is way overkill. really.

Just call set_memory_x() after your ioremap call, and call set_memory_nx() before the iounmap.
THere is no need to hack up ioremap for any of this stuff. At all.

-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/