Received-SPF: pass (google.com: domain of linux-kernel+bounces-180460-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <CAPM=9tw-53PCvveRcdLUUQ+mjq2X2er5zp6n1KeE8Nu8x=VP2g@mail.gmail.com>
 <CAHk-=whxT8D_0j=bjtrvj-O=VEOjn6GW8GK4j2V+BiDUntZKAQ@mail.gmail.com> <CAPM=9tyOtH24Mw_2X+bgV9iChOQV3LtmRCoR5x6KXhSUD6FjUg@mail.gmail.com>
In-Reply-To: <CAPM=9tyOtH24Mw_2X+bgV9iChOQV3LtmRCoR5x6KXhSUD6FjUg@mail.gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Wed, 15 May 2024 15:56:28 -0700
Message-ID: <CAHk-=wh8DWSMrtuhZOzanfBCFcuJCihO9x7fkzx-dBhLddXF-Q@mail.gmail.com>
Subject: Re: [git pull] drm for 6.10-rc1
To: Dave Airlie <airlied@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, 
	dri-devel <dri-devel@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Wed, 15 May 2024 at 15:45, Dave Airlie <airlied@gmail.com> wrote:
>
>           The drm subsystem enables more warnings than the kernel default, so
>           this config option is disabled by default.

Irrelevant.

If the *main* CONFIG_WERROR is on, then it does NOT MATTER if somebody
sets CONFIG_DRM_WERROR or not. It's a no-op. It's pointless.

And that means that it's also entirely pointless to ask. It's only annoying.

> depends on DRM && EXPERT
>
> so we aren't throwing it at random users.

Yes you are.

Because - rightly or wrongly - distros enable EXPERT by default. At
least Fedora does. So any user that starts from a distro config will
have EXPERT enabled.

> should we rename it CONFIG_DRM_WERROR_MORE or something?

Renaming does nothing. If it's pointless, it's pointless even if it's renamed.

It needs to have a

   depends on !WERROR

because if WERROR is already true, then it's stupid and wrong to ask AGAIN.

To summarize: if the main WERROR is enabled, then the DRM tree is
*ALREADY* built with WERROR. Asking for DRM_WERROR is wrong.

I keep harping on bad config variables because our kernel config thing
is already much too messy and is by far the most difficult part of
building your own kernel.

Everything else is literally just "make" followed by "make
modules_install" and "make install". Very straightforward.

But doing a kernel config? Nasty. And made nastier by bad and
nonsensical questions.

            Linus