Received-SPF: pass (google.com: domain of linux-kernel+bounces-180463-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <175989e7-2275-4775-9ad8-65c4134184dd@intel.com>
Date: Thu, 16 May 2024 11:06:35 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 02/16] KVM: x86/mmu: Introduce a slot flag to zap only
 slot leafs on slot deletion
To: Sean Christopherson <seanjc@google.com>, Rick P Edgecombe
	<rick.p.edgecombe@intel.com>
CC: "dmatlack@google.com" <dmatlack@google.com>, "sagis@google.com"
	<sagis@google.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Yan Y Zhao <yan.y.zhao@intel.com>, "Erdem
 Aktas" <erdemaktas@google.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>, "isaku.yamahata@gmail.com"
	<isaku.yamahata@gmail.com>
References: <20240515005952.3410568-1-rick.p.edgecombe@intel.com>
 <20240515005952.3410568-3-rick.p.edgecombe@intel.com>
 <b89385e5c7f4c3e5bc97045ec909455c33652fb1.camel@intel.com>
 <ZkUIMKxhhYbrvS8I@google.com>
 <1257b7b43472fad6287b648ec96fc27a89766eb9.camel@intel.com>
 <ZkUVcjYhgVpVcGAV@google.com>
 <ac5cab4a25d3a1e022a6a1892e59e670e5fff560.camel@intel.com>
 <ZkU7dl3BDXpwYwza@google.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <ZkU7dl3BDXpwYwza@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1RuNWxQTmZ4QnlraUdsckZ3SkcrS1V4OGlBaVNycWhkelNMQ2NaTkRmbm1s?=
 =?utf-8?B?MXZFS25Wbm5iNTM2dElFWlZyNnIyaXBxbFZOVUp2bFRxQ0QzaWtRejF2Q3pZ?=
 =?utf-8?B?cjl5bUQ0TE5wdDlwTTdnSHFOVVI1R3ZqU0ord3ZIL3RSM0hML2hMeWhlTnFx?=
 =?utf-8?B?bU9FR2djVjk3NnI3ZXBETE1KcHI4ZS94d0JkU0doSzJwNHowbk9RVDh0RldL?=
 =?utf-8?B?WUNacEk4UXJ1eUJuOU9URXFwZkd1N0Q1RGtiSTdLTTVpQytpdkVqcGUzMEkv?=
 =?utf-8?B?bEV1QnUxWStoN0VaT20za1BRWTZKZ3VibUtnM1lHS1pHRHFYT05VV01rbzlK?=
 =?utf-8?B?WmNja2pUQ2kvYXQ0Tm1zc3VqelEvV2syR1I5YnRGSm13UXRDYWM1Yk96SDBI?=
 =?utf-8?B?cGRKTlcxTnErSS9TUjRKNjZpUGFnOTBPWGdWdS9XRXkvVnI1NVdITVhsUEhW?=
 =?utf-8?B?SjFZOFhwUnc4aHNmcWpnOXZVQWRHcml6SWRLRzV3aWNmanpMdXRYRlFXdXo1?=
 =?utf-8?B?djg5N2Jwek1MY2IyOHhPdEpnQ01SczlMdjV3dDU2NXBLK21rWU1qQU12MGVn?=
 =?utf-8?B?TkVTc1NMaFdncjEvNmNBUHpVTVFqVmk2czg0bzI1T0NQZ2tMMkN0SjdDbUUr?=
 =?utf-8?B?RS9YRUNXS3IyWGsvaGVlNTB3R2htNytscXFTSTRTQXNteU1NQWdYdFR3UUUw?=
 =?utf-8?B?QXlHc3RmanBkZ1FZQUV1bE1HOFVxVTNzckxVcVc1MGFyNUhyQW5ya0pEMnJ0?=
 =?utf-8?B?cUFBcXVuZUxOc3BwMDN1UExPSmRZYzExWHlQemVQcHZKQU1WWWs0MW44OG1s?=
 =?utf-8?B?NFVRQm5ONG1TV3dCandPWk5NMi9pMjlZY3hJZ2F1RHNMWmhlYUlzUDJ4eXpW?=
 =?utf-8?B?K3lnY1MrYWlVcCtpUDlaVGVDd1VObXRaZVBhaUNIOXl3OUE5d0d3OVdJR2Ny?=
 =?utf-8?B?d1NWdFRiTGNpUk85UVVDd2JsczhTVDJqRWxxSnZ5RXhpUHFzQ3ovNVJBUGpR?=
 =?utf-8?B?aFprY3Y3YVhpTHR4RjZLTmhDazNCWndoc29XMUxPUzdoRzNLbXRONTh6M2Vr?=
 =?utf-8?B?dmRoNDRWdnFhTE40SWdtOWNmRCtvZHVTRWhLcjZpU21ISjF5NVpDVXl5WWRi?=
 =?utf-8?B?YzBaSmRQcU95MUtKclNYWFVLY01xbFZLWVpQZDZPNkw2NjV5aDZVdWVzK05Q?=
 =?utf-8?B?bHJIM3EvQ2VVem1SQ0ZlQys2QUN2NlhFMEN3NG5DSjI2OTRuZHVVcGNvQ09D?=
 =?utf-8?B?dlprbk9XakN1OUN3Y1dJZmt1ZnlNczlVNlUwYjdGOFllSzBFWHJnbldDek55?=
 =?utf-8?B?TjZRbjNUUkg5Z2ZlaXdXT1ErMEdOSWN4b1JsRzcvaTdSN2REZ2tKcS9CVXc0?=
 =?utf-8?B?aDh2aVZzMU5TTm5odlhabnordmp4NERqblJkaXZaaGh5T3RYT2JldmtqVHFE?=
 =?utf-8?B?SWViaEw1VmJQN2UrVEJ2b092WG5oRE1GRll0S3huMUpMYWgrUFZDaE9Wd0tN?=
 =?utf-8?B?RE12UmUwT3RMRGFFT2hCaHgveWgrYmJoMWlwdmpwTnltV21xc2Y4UGZGenRh?=
 =?utf-8?B?cC95QmY5TUo1clZBT1docEpzMWNoR2Y0RjdvakdLQ2RIK0FnMVBDMzlRMTQx?=
 =?utf-8?B?dTJSdmNNdkpjN0Z5a05iVWpyOXl4bkpSaER4SnFKdkRjNU5Pa2lNM01mZTIz?=
 =?utf-8?B?ckV0c0xUeDFEUmR1STJpU0lPQytmRGIrWFFhYmk1aitLZ3RSeDlrOFRka1Y1?=
 =?utf-8?B?TTB5SllSbVg5Tit1eFhSQ3poY3lJOGdQRUY5SDN5YTcyT0ZVcXhIK2ZaTTB3?=
 =?utf-8?B?eXJ4YjBlSTBMTU1MRTV2bkNrOXN4NUhDSGZWU2daTHVWM2lSenhwSmZHaTg5?=
 =?utf-8?B?N0gveE5scWZxWk9saEd6SDFJY3pWVllkbEZDVkM1amUreW9ac0ltU2REbG9n?=
 =?utf-8?B?dWY1amFoYm5TeVdFMzdUT2dZdUJkWERRS2ZnNVhEWWlCeVlLWmdxdnRSdWNT?=
 =?utf-8?B?Uk84REJvQWZSZHFtR1JDNGhxcmRkNytTUzl1NnpVNFQvZmFjOFBzaWNBR3Bs?=
 =?utf-8?B?dmNYSHlTYnVkN1lwZXVTOFZGcENud2V3QUh6VHk2M3kvNjdQMzJoZmxTYmhO?=
 =?utf-8?Q?okN7fO8w3u8Wt7HLaj2/YENjo?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 94af8e4d-d428-4779-b10e-08dc7533b0fd
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2024 23:06:45.8964
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XtMd+b6ISj4JwFq9+OyBKa/wGlwIUBiJNeZ1bxFjhWBZ8ml/Qq2CKvYNzC4ul/10H93xDjdWag7Ud/XKRPoDyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8718
X-OriginatorOrg: intel.com


>>
>> You had said up the thread, why not opt all non-normal VMs into the new
>> behavior. It will work great for TDX. But why do SEV and others want this
>> automatically?
> 
> Because I want flexibility in KVM, i.e. I want to take the opportunity to try and
> break away from KVM's godawful ABI.  It might be a pipe dream, as keying off the
> VM type obviously has similar risks to giving userspace a memslot flag.  The one
> sliver of hope is that the VM types really are quite new (though less so for SEV
> and SEV-ES), whereas a memslot flag would be easily applied to existing VMs.

Btw, does the "zap-leaf-only" approach always have better performance, 
assuming we have to hold MMU write lock for that?

Consider a huge memslot being deleted/moved.

If we can always have a better performance for "zap-leaf-only", then 
instead of letting userspace to opt-in this feature, we perhaps can do 
the opposite:

We always do the "zap-leaf-only" in KVM, but add a quirk for the VMs 
that userspace know can have such bug and apply this quirk.

But again, I think it's just too overkill for TDX.  We can just set the 
ZAP_LEAF_ONLY flag for the slot when it is created in KVM.