Received-SPF: pass (google.com: domain of linux-kernel+bounces-180498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <CAPM=9tw-53PCvveRcdLUUQ+mjq2X2er5zp6n1KeE8Nu8x=VP2g@mail.gmail.com>
 <CAHk-=wge0et+3PP47OBnNx66Q=i_XgqfGfrSmDGHSyp=Jn-CgQ@mail.gmail.com>
 <CAHk-=whTqHgXZ4Aj8dNO3Peg9Rf0sh2F7zGWRUOmBwfMDxgvbQ@mail.gmail.com>
 <CAHk-=wgWJCcJRLBZ1xoAATFyvp6YKN+qzrePhxQbN1SFrno7pQ@mail.gmail.com> <CAHk-=wjm4BcsMrvgXocATBVvZ7N6LAjSvLTzTXWg9EFzyip_cA@mail.gmail.com>
In-Reply-To: <CAHk-=wjm4BcsMrvgXocATBVvZ7N6LAjSvLTzTXWg9EFzyip_cA@mail.gmail.com>
From: Dave Airlie <airlied@gmail.com>
Date: Thu, 16 May 2024 09:50:09 +1000
Message-ID: <CAPM=9twOiwquA7Zi_mr1vKFV4RQqhnbHv+c9Xz6BadF3tGEegw@mail.gmail.com>
Subject: Re: [git pull] drm for 6.10-rc1
To: Linus Torvalds <torvalds@linux-foundation.org>, 
	"Deucher, Alexander" <Alexander.Deucher@amd.com>
Cc: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>, 
	=?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>, 
	Matthew Auld <matthew.auld@intel.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, 
	dri-devel <dri-devel@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org>
Content-Type: multipart/mixed; boundary="0000000000000a2d5c061886c829"

--0000000000000a2d5c061886c829
Content-Type: text/plain; charset="UTF-8"

On Thu, 16 May 2024 at 06:29, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Wed, 15 May 2024 at 13:24, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > I have to revert both
> >
> >   a68c7eaa7a8f ("drm/amdgpu: Enable clear page functionality")
> >   e362b7c8f8c7 ("drm/amdgpu: Modify the contiguous flags behaviour")
> >
> > to make things build cleanly. Next step: see if it boots and fixes the
> > problem for me.
>
> Well, perhaps not surprisingly, the WARN_ON() no longer triggers with
> this, and everything looks fine.
>
> Let's see if the machine ends up being stable now. It took several
> hours for the "scary messages" state to turn into the "hung machine"
> state, so they *could* have been independent issues, but it seems a
> bit unlikely.

I think that should be fine to do for now.

I think it is also fine to do like I've attached, but I'm not sure if
I'd take that chance.

Two questions for Arunpravin (and Alex):

Is this fix correct, and can we get a good explanation of it?

Where did this error sneak in? Is the problem in the amdgpu tree, or
was it a drm-next only problem? If so perhaps we need to discuss
moving amdgpu more into drm-tip to catch this sort of problem.

Dave.

--0000000000000a2d5c061886c829
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-drm-buddy-convert-WARN_ON-to-an-if-continue.patch"
Content-Disposition: attachment; 
	filename="0001-drm-buddy-convert-WARN_ON-to-an-if-continue.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lw8h2ndb0>
X-Attachment-Id: f_lw8h2ndb0

RnJvbSAwODViODkyNzhmMjk2YzQwZTg2ZjVkMWUxYmNjMTAxN2MzOWY0MDAyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZlIEFpcmxpZSA8YWlybGllZEByZWRoYXQuY29tPgpEYXRl
OiBUaHUsIDE2IE1heSAyMDI0IDA5OjQ2OjM3ICsxMDAwClN1YmplY3Q6IFtQQVRDSF0gZHJtL2J1
ZGR5OiBjb252ZXJ0IFdBUk5fT04gdG8gYW4gaWYgKyBjb250aW51ZQoKVGhpcyBXQVJOX09OIHRy
aWdnZXJzIGEgbG90LCBidXQgSSBkb24ndCB0aGluayB0aGUgX19mb3JjZV9tZXJnZQpwYXRoIGFs
d2F5cyBoYXMgdG8gc3VjY2VlZCwgc28ganVzdCByZXR1cm4gYSBmYWlsdXJlIGhlcmUgaW5zdGVh
ZApvZiB3YXJuIG9uIHRvIGxldCBvdGhlciBwYXRocyBoYW5kbGUgdGhlIGFsbG9jYXRpb24uCgoo
Tm90IDEwMCUgc3VyZSBvbiB0aGlzIHBhdGNoIC0gYWlybGllZCkuCi0tLQogZHJpdmVycy9ncHUv
ZHJtL2RybV9idWRkeS5jIHwgNSArKystLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygr
KSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2J1ZGR5
LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2J1ZGR5LmMKaW5kZXggMjg0ZWJhZTcxY2M0Li42Yjkw
ZWM2ZWVmYTggMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYnVkZHkuYworKysgYi9k
cml2ZXJzL2dwdS9kcm0vZHJtX2J1ZGR5LmMKQEAgLTE5NSw4ICsxOTUsOSBAQCBzdGF0aWMgaW50
IF9fZm9yY2VfbWVyZ2Uoc3RydWN0IGRybV9idWRkeSAqbW0sCiAJCQlpZiAoIWRybV9idWRkeV9i
bG9ja19pc19mcmVlKGJ1ZGR5KSkKIAkJCQljb250aW51ZTsKIAotCQkJV0FSTl9PTihkcm1fYnVk
ZHlfYmxvY2tfaXNfY2xlYXIoYmxvY2spID09Ci0JCQkJZHJtX2J1ZGR5X2Jsb2NrX2lzX2NsZWFy
KGJ1ZGR5KSk7CisJCQlpZiAoZHJtX2J1ZGR5X2Jsb2NrX2lzX2NsZWFyKGJsb2NrKSAhPQorCQkJ
ICAgIGRybV9idWRkeV9ibG9ja19pc19jbGVhcihidWRkeSkpCisJCQkJY29udGludWU7CiAKIAkJ
CS8qCiAJCQkgKiBJZiB0aGUgcHJldiBibG9jayBpcyBzYW1lIGFzIGJ1ZGR5LCBkb24ndCBhY2Nl
c3MgdGhlCi0tIAoyLjQ0LjAKCg==
--0000000000000a2d5c061886c829--