Received-SPF: pass (google.com: domain of linux-kernel+bounces-180514-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <6df62046-aa3b-42bd-b5d6-e44349332c73@intel.com>
Date: Thu, 16 May 2024 12:25:51 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 04/16] KVM: x86/mmu: Add address conversion functions for
 TDX shared bit of GPA
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "pbonzini@redhat.com" <pbonzini@redhat.com>,
	"seanjc@google.com" <seanjc@google.com>
CC: "isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>, "sagis@google.com"
	<sagis@google.com>, "Aktas, Erdem" <erdemaktas@google.com>,
	"dmatlack@google.com" <dmatlack@google.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
References: <20240515005952.3410568-1-rick.p.edgecombe@intel.com>
 <20240515005952.3410568-5-rick.p.edgecombe@intel.com>
 <9f315b56-7da8-428d-bc19-224e19f557e0@intel.com>
 <307f2360707e5c7377a898b544fabc7d72421572.camel@intel.com>
 <eb98d0e7-8fbd-40d2-a6b3-0bf98edb77f9@intel.com>
 <fe9687d5f17fa04e5e15fdfd7021fa6e882d5e37.camel@intel.com>
 <465b8cb0-4ce1-4c9b-8c31-64e4a503e5f2@intel.com>
 <bf1038ae56693014e62984af671af52a5f30faba.camel@intel.com>
 <4e0968ae-11db-426a-b3a4-afbd4b8e9a49@intel.com>
 <0a168cbcd8e500452f3b6603cc53d088b5073535.camel@intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <0a168cbcd8e500452f3b6603cc53d088b5073535.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHFTaVlyc0liT2dUaEtKeTU4K1ptc3krS0xiQjRxbEJFQW1hVkNyaGM4eEZz?=
 =?utf-8?B?NVpURkJFRksxSTZybUYyM3RZMUdtcGExakFTTGxMSGZyR2w0eFIyVVZwWlB6?=
 =?utf-8?B?Y2t0SVMzYkJsaEQ4c3llZnFiS3dEaFRxZXVlbFVWV0VFMjdRQ2VsMWsxMDhx?=
 =?utf-8?B?blc2QTlSZDMvdU1CV0E3dmN2VEtHdnB4c0xUaXU3dWhCdStIZmo4TTdrYXdQ?=
 =?utf-8?B?ZTl0cDEvYlFHckxSWExhR0x5OW9OVHJMenp0U2ZqWllwdU10WEVRYjlzUk93?=
 =?utf-8?B?SXVVS2hyZ0VyQ1V5eTNucStOZGJuY0FQbjJKcnN6eGxtQlVKc0t1TzEwVVRw?=
 =?utf-8?B?aGdUWkJSRERMeTltM09SNGN2MW9mWldiNHJGTmJ5T1FGQnlqSnUvNDJDNWlH?=
 =?utf-8?B?RVpORVo2eklMYk4zSVh6aGRvSnIrc2prMUh1dTZzVTFvcGIwRDNFSGVhZHND?=
 =?utf-8?B?RFk3azR5dFBsTWdNKytRVm5QWUg3TEVwYmNLWlk0SEU5RmZuZ3NLcktoYmFG?=
 =?utf-8?B?K1lmK0d6R29UMTlJY1hlcFZyY2g1TzRSZGFkQTM1NFl6NHNLemxtelVjVHI0?=
 =?utf-8?B?UUl4bTI3Y2ROMGllUUg5R0tMRmVKRThzekNlSkhOb2VXWWhVelFrcS9xd0o2?=
 =?utf-8?B?NUtsNW42cFBQYVV4ZHU4cXIxVG5mR1lETjQrOGFNM2JER09Ia3gvUjhxRjdV?=
 =?utf-8?B?OCsxUFdyNTJneVIxejc4czNaN1dqQ3pwQ3pEcXN5Qk5EeUxLQ2xEanU2Znor?=
 =?utf-8?B?Sy9MUnNsWFpzUGJWVkNJenkvRnlvQitNZ3pLUC8yZTB1LzlHZWNFaDdHWDZZ?=
 =?utf-8?B?TWtJWmJUZlRueENOOUc4REpERzZLaWNYeUVSSHk2UklYbm9XV1NDV252SVVU?=
 =?utf-8?B?bUNjaGM2RnF4VUpQbm1kVnBLZzEwMG04RjMwVnRJM2poMm1vT0RYSUszZlRh?=
 =?utf-8?B?a3RPZFArUmJ0UDJmcnBrT3VOQmZDRlBRb0h3Z3RLVitGZytwNy9vTzhibU8v?=
 =?utf-8?B?OFRMbDFSWnRhVlNrQmpOQzBRMXZ1cDNVU2dNVXRWK0VpU3NzVWRyQ2R4cjlk?=
 =?utf-8?B?U3g1TmZZckx4dVZqOXh6YlhhY3dQQmpzYSthL3ovQ1ltYmJPZUFuUzdHNW83?=
 =?utf-8?B?U1U5UGdaOUJ2RFlKWjR2YndrbVE2RCtwaURvSHRDK0pjYm1RTXpDMEUzMlNN?=
 =?utf-8?B?T3BZdHZyN3ZtMVE5OUEzbSs0QXVpOWgyMjR5V2FhdFlMVWx4U2VZR1pobE1o?=
 =?utf-8?B?VGVHTnFRU3AvYTJYSkhScnM5Ympmb293WVAxNzdCTWRmdXlTbjN3UzlxNzFk?=
 =?utf-8?B?dDBzVndrT2p3SDlNS29NWFdDMVJ3UUZHdmwyOHoxRHAwQ1UrZXhldm5PSFJl?=
 =?utf-8?B?RlY2M1dnK1lYR1d0K2g2SnFoaExNelRMdWNQNG5PZnp3VkVGL0tYWnRHMytO?=
 =?utf-8?B?K3gra1c5bGhDci9kNzZka1FPeVE2MEE2blZJMENHWW1QR3FaTC9ueEc2Zi82?=
 =?utf-8?B?UUlUcFN2S1JySmJzdlFGYVlmcUVwTUh0RmNSaXl4WU1RdkxIR3l4RGN5bCtj?=
 =?utf-8?B?TEhBeGZ3SzRrUlpyemJ3Zk5lWEV4Vi80cDBqYzFkQStGK2tzcTBjbUZVcXhy?=
 =?utf-8?B?SEVPNW84Q2kxWkl0UXZCVXR3dEUyemxieitWZ3kzaGRKNVFMMG0wZzR3TytG?=
 =?utf-8?B?dHE3RVpaMkF0NUYyUDArVzVBMVBNSUFkbExRaDRWM2V1Y21GWFUrNTdFRWtl?=
 =?utf-8?B?Q3FiaHdhS3lhcDRoRWV4VTFGYzJlR09KZjFFMThsdzZYelRad21sNjhhcFRS?=
 =?utf-8?B?Z3A3TzEyL1Rwa3R6MlFodStzN3BiRXJRYmkzbG91bU9UMHFuMTJyckVmMlVT?=
 =?utf-8?B?bUs0eUxZVDZoWHZkVzV2RlE0NVNOSFZTblp0TjAxTlhuYm42UTUzcStab1l1?=
 =?utf-8?B?ZjhrL0UvdGJwUERYRFVnN2ZvcVVvd0tpMk1OWHpFSldYZjI4N1BOS1ZPTFRu?=
 =?utf-8?B?Q1hIanQyYUFyYlZqdEU2WitVbndQVzdSRTNSQmtoV284L0IwU2lBdXBwQjBH?=
 =?utf-8?B?NTlBU0V3ZHVTVFBaL2dlSVVRNldYM0VWMTNtMWpScVJsNkMrTERwbXZiYm5p?=
 =?utf-8?Q?F1NrwXelXLUTW1AV0vyDClFYQ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a2ed0c1-85bf-4e1a-f2e7-08dc753ec35f
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 00:26:00.8080
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BiF7rEw9PF9B8U2dYebHTjvFyeiLsOlWRNzzObyy8wVUa3NbpHLsSnXEaB1kZ150vkTplesKUSwUydpqQsskhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7610
X-OriginatorOrg: intel.com


On 16/05/2024 12:19 pm, Edgecombe, Rick P wrote:
> On Thu, 2024-05-16 at 12:12 +1200, Huang, Kai wrote:
>>
>> I don't have strong objection if the use of kvm_gfn_shared_mask() is
>> contained in smaller areas that truly need it.  Let's discuss in
>> relevant patch(es).
>>
>> However I do think the helpers like below makes no sense (for SEV-SNP):
>>
>> +static inline bool kvm_is_private_gpa(const struct kvm *kvm, gpa_t gpa)
>> +{
>> +       gfn_t mask = kvm_gfn_shared_mask(kvm);
>> +
>> +       return mask && !(gpa_to_gfn(gpa) & mask);
>> +}
> 
> You mean the name? SNP doesn't have a concept of "private GPA" IIUC. The C bit
> is more like an permission bit. So SNP doesn't have private GPAs, and the
> function would always return false for SNP. So I'm not sure it's too horrible.

Hmm.. Why SNP doesn't have private GPAs?  They are crypto-protected and 
KVM cannot access directly correct?

> 
> If it's the name, can you suggest something?

The name make sense, but it has to reflect the fact that a given GPA is 
truly private (crypto-protected, inaccessible to KVM).