Received-SPF: pass (google.com: domain of linux-kernel+bounces-180539-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <32447c72-7447-4102-baf2-7af78020bee5@intel.com>
Date: Thu, 16 May 2024 13:11:24 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 08/16] KVM: x86/mmu: Bug the VM if kvm_zap_gfn_range() is
 called for TDX
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>, "seanjc@google.com"
	<seanjc@google.com>, "Yamahata, Isaku" <isaku.yamahata@intel.com>
CC: "pbonzini@redhat.com" <pbonzini@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"sagis@google.com" <sagis@google.com>, "isaku.yamahata@linux.intel.com"
	<isaku.yamahata@linux.intel.com>, "Aktas, Erdem" <erdemaktas@google.com>,
	"Zhao, Yan Y" <yan.y.zhao@intel.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "dmatlack@google.com" <dmatlack@google.com>,
	"isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>
References: <20240515005952.3410568-1-rick.p.edgecombe@intel.com>
 <20240515005952.3410568-9-rick.p.edgecombe@intel.com>
 <ZkTWDfuYD-ThdYe6@google.com> <20240515162240.GC168153@ls.amr.corp.intel.com>
 <eab9201e-702e-46bc-9782-d6dfe3da2127@intel.com>
 <d4c96caffd2633a70a140861d91794cdb54c7655.camel@intel.com>
 <66afc965-b3f5-41e5-8b8e-d19e7084b690@intel.com>
 <3879ed41213652da74c5de3e437f732dfb2324d7.camel@intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <3879ed41213652da74c5de3e437f732dfb2324d7.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2JjaVdsVjZTanI5QXFoNGUyUG5RbVBONTZYQ1BTeDJacWtrMlNnWWNpVjc1?=
 =?utf-8?B?Rm9Dakx2bWFzOEJncmFrbEpuUXBFSDRGUjdlM1orTWIwZGFtZ2hjc2k4TkVw?=
 =?utf-8?B?dGhMWWJaVFROTlRqaVBaMysvUVN4emNNTFRySXBrcVNYY0NXNHdlWmhjUTBU?=
 =?utf-8?B?dWp6b0JVNkd4TENkOElsc0FadUIxeVZTNmtXc1ZRbkRTeThYd0JTZThnSDkz?=
 =?utf-8?B?clhvUzMrTlZnck92cGhobFNOVElhemhkWmttd1Uwei9sRW1EVXRiUFpaNG1R?=
 =?utf-8?B?RzBuZWg1N2V2VUlNY1Y4Rm16TUVFMk8ycVp5U3hIV2xtbjN0cWxLQTRhellJ?=
 =?utf-8?B?bzhDQkU2MmV4TERsVHBrM2I5Tld3YzlBLzk3c2NtTG9iRUsveHVEeGFlS0wy?=
 =?utf-8?B?anc2bkFmVDV1K3pWbHNtMmk5RlNzMGJZMWJ2MlNRbjJ5Y3F4SUhsQnZXK2kx?=
 =?utf-8?B?eTBvREZZN1Faa2JtT2pRL0NsYi9GVG81SlVIU1JraUprekZBQXEyZ1hjcE4y?=
 =?utf-8?B?OWNiMmpVV0xNdU54aXFyait1VC9qcXBZRVc4VnQ0VlZ2L3N1K056UHdLU1RB?=
 =?utf-8?B?SDVoZHJiRlUyZTVkWjhxRUVlWWFxL2xERnc4QWlzem1RbDUxUHZsVmlheElI?=
 =?utf-8?B?VHZTT0xCaHBtQmlhcXBFZnhOV1dmdmIzTk1BM0Frb3d1aDVVN1NoYlpxMklZ?=
 =?utf-8?B?SFJNUHpseGg4dUNTa2NFQjdtL2U1cHRyT05xWHpFVTIwM3E3NDJMYXh6OHlN?=
 =?utf-8?B?Q014RVpSSzFnWUNKRHRCZmdEWTNZUTJtVElRZWhDa3B1WnJnT2hJaWhidWhU?=
 =?utf-8?B?M29VZzQyNXpFa0JDY0tsdnZSWm92d2Q2TUI5N2huWkw5azNrTHV5MG53bGQv?=
 =?utf-8?B?ZTkzUzhzaHFnUFA5cFE4MEEwd3ZoY1A4eFp4d0hFL0sxWDd0Snd4VjExNXBj?=
 =?utf-8?B?MXdlak1GeVJKY053akZKdVZwQjhKblpsbDUveVRMeUpObUlqVEJDbUlpbzhK?=
 =?utf-8?B?c0h3WWJSaEVWNFZ5ek05SmNHUTVMb1VNK2h0NlZkc3NxWU5Ib3hQL2pPV0ti?=
 =?utf-8?B?QWtpNWRaUk9NQXF5TnR2V1h4UzV4b1JHSUxSWndGQU51eVNrZkxSZk5SVTNx?=
 =?utf-8?B?Q2FWZksxekIzYko0bGJLNWoycEVQdWRaQWhucThJek52SVZLS2diM2xJU0Rw?=
 =?utf-8?B?bGt0Z2l1eE5CWTB3UGwrcDE1czNjbGJtcGZaRWZicGl4UGNVSmVyN1ptVHQ5?=
 =?utf-8?B?U3dRVklzUDdjaUs0SXRibXRQSUtTclM1QUw1bk5IaWU1cWxaaXMxdEwxSWti?=
 =?utf-8?B?Wmx6ZkxVamJjbnhwYVBKOE5uKzN4ZzBxd2Ftc3ZoQWdjUlY5aW10RjdIRzFG?=
 =?utf-8?B?cGpnTkJtVk1PdkN2N0hyQUJwRStOLzBHeUdjQU9QQlUzTk85aWNYamRRdzlN?=
 =?utf-8?B?WldoNE5hRkxUVGlNYTF0OFJ6ZHhLdUpqeDBwbzRzMUhpQTVIaVdaRWZjMlov?=
 =?utf-8?B?bXVlTUVHVW8zUml4bDJRWmtCNEZrTVI4T0hHZFhDZzhWVDBSYkxrNWVCeW1n?=
 =?utf-8?B?blBmR2prdmptell1aWs1YTNlcm5iZDRnZGRXa0pBK1M1WmZ6T0VLRDBTdlFC?=
 =?utf-8?B?T0N4UXNlSHBJREFtYklqckJ6RGJqbGRHVlZxb1lTMndVUVI3MEdJT1V4Y3JT?=
 =?utf-8?B?aWk1K1ZkdHgzTlF1OWwxQmJDWGJFZUlPMlRWd1ppd295RFBxcngrN3U3QkRU?=
 =?utf-8?B?WXZQTVdVS3BkTmZzZHk4ek5EWEdFODV6L0Y0bWJhY2RFRTdJc1M3Q1hPY00v?=
 =?utf-8?B?U0V6bDAxY0Y2RkNGUE90S2xTb3hwaTc1UjhLUFNiK0Nkd2paVVZtNFIzTHhO?=
 =?utf-8?B?bmdqc0lzdEE4d3ErTzRnbDFaaHQxUHpqS0t2QmFUUjVpcTZTTGVNUzZvMDZz?=
 =?utf-8?B?djFGdStwbHBYZkppU1lzMEZuU09GR05KSDYwWHJFVlpNQkFFajFSRkJnRity?=
 =?utf-8?B?Z3RheHlTL0VoeDQrUVFpRHY2eHdJK1RzS0VMU1BxWHpHamJ0VDJoVG9mdXFO?=
 =?utf-8?B?VkNjL21LMSs3QUdURmM2QWl6c0tiWFNJajJTT2owYXJsWjZ5TitpSFYzVHV2?=
 =?utf-8?Q?2MpYRUMCMCa4FtlmHJEomTZqs?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fff388a-ce1a-42b8-8162-08dc75451fef
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 01:11:33.0602
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1HYZofYjV+pcnmxILs0SY0IiXrvSBWgPniPETo5KuMx/BbTnbpNl5gEAwQPrx+z+/l7m43J5zBOGh4B2QSiWgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6436
X-OriginatorOrg: intel.com


> 
> BTW, the role bit is the thing I'm wondering if we really need, because we have
> shared_mask. While the shared_mask is used for lots of things today, we need
> still need it for masking GPAs. Where as the role bit is only needed to know if
> a SP is for private (which we can tell from the GPA).

Yeah we can have a second thought on whether sp.role.private is 
necessary.  It is useful in shadow MMU (which we originally used to 
support at the first place), but may not be necessary for TDP MMU.