Received-SPF: pass (google.com: domain of linux-kernel+bounces-180562-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <b6e8f705-e4ab-4709-bf18-c8767f63f92e@intel.com>
Date: Thu, 16 May 2024 14:10:41 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 10/16] KVM: x86/tdp_mmu: Support TDX private mapping for
 TDP MMU
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>, "Yamahata, Isaku"
	<isaku.yamahata@intel.com>
CC: "dmatlack@google.com" <dmatlack@google.com>, "seanjc@google.com"
	<seanjc@google.com>, "sagis@google.com" <sagis@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "Aktas, Erdem" <erdemaktas@google.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "pbonzini@redhat.com"
	<pbonzini@redhat.com>, "isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>
References: <20240515005952.3410568-1-rick.p.edgecombe@intel.com>
 <20240515005952.3410568-11-rick.p.edgecombe@intel.com>
 <12afae41-906c-4bb7-956a-d73734c68010@intel.com>
 <20240516014803.GI168153@ls.amr.corp.intel.com>
 <c8fe14f6c3b4a7330c3dc26f82c679334cf70994.camel@intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <c8fe14f6c3b4a7330c3dc26f82c679334cf70994.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2tmWXdBdENWYWZocllRaHRhVTZRWWJZT0F4TDdxM29lM3AzNE5NUWdmYU1M?=
 =?utf-8?B?RXRzakI5YlR0WHRVdmwzeVFtS0pMUHNQeWFaZk4yRWx2WFYyajViSy95Q2N0?=
 =?utf-8?B?S3hCNitFZHBONWJVSk9tN3NBZkRCbVdsMC8rdVFuR25kWldyQ3JuNFdkMDRZ?=
 =?utf-8?B?b2ViVzRJRnNlejkrRlAwd0JLaUcrSE80Y0VlZ3M0S09LeVZKZThmdGRQSmhX?=
 =?utf-8?B?bWo2K1lsbkQ2QnEzSUtKYnJNZkluYWRvWk0zQUh0V2RsYmswR3NaUUIvQnRw?=
 =?utf-8?B?ZDJKeDdMWWQ4SXo1NFNHMWlybHFva29VdHJOTEN6VW4yOHhHNzFBdlRya1dr?=
 =?utf-8?B?ck8yZkVobDRiL2QrQVpXM0dpMnlDcXdqa3dyUU5zVVZqQ0NZT3RKVU1EaVR1?=
 =?utf-8?B?OWlQcDRWdGF5Wi8zanZtU3NFMm5PSjJ0TDgyTzNFQ0FIOW1heXpGOWhWTksv?=
 =?utf-8?B?VndRTGZFZk5hUXNibll2QzNSZEprUzVJYW5xWTcreEtPUkQyT0J1M2JRYlBS?=
 =?utf-8?B?MEJpUEMySmY1VUsrcU1WMjA3VHNwdFFnYXBVN3pFQ2lWUTAyd3Jsa2xDaGtp?=
 =?utf-8?B?bGFiTllmcHFzc3lsZldaMVJ3cjF3SjJySXNUOWFvTkZGVUVzb1JjUmdYeW0y?=
 =?utf-8?B?TXNpWHNUNkFIRW5TZUY3SUJVV2RBeEpzL3dyU3JJRFY1TFBsQlZGS2FDTGdZ?=
 =?utf-8?B?Uk9kNFVONWhMK2NEelh3UzlnT2xjK0UzYkp1dmFhdTFXbXhibGhsZDVsSDZM?=
 =?utf-8?B?UEZycno4bzhkWWdzbmFQQnpFZUlZb0FvSkNNZjhtOG1ndzZPQ09pcnQ3Q1pn?=
 =?utf-8?B?SWF0VDlvTjFTamRBNVRiQzRLTEtlYnE4VEdBM0g4SlZpR3dvaG5MU2NUUlRj?=
 =?utf-8?B?SyszY0dORUVlWmEybklOclYyYUFSWHhha0RMYTIyMzU2ems3aVlwdWhrK2Rz?=
 =?utf-8?B?YUV6RXQ0SnVpQWpDSjhDcHJXb3VMSjJpOWhPeWd2ZEFDOEVSUk5kWWo0Qmhz?=
 =?utf-8?B?L0l0UDZBM0VSSU52b0EvZGpJWklNRGVoT3o4bWhNUitHb1VxYUtEYWtvOTRy?=
 =?utf-8?B?MTJSdE5aZ2V1YklNQ3J1WkxHYjl6QTRYRUx6bjA5aFFFbm1jNzdzbWg4NHFo?=
 =?utf-8?B?dzR3cUhwRGhGd0xZOTFrK0xwVEpJaUl6MzhpcENmSmpWMDF1T084ZFpuMUk3?=
 =?utf-8?B?Z2JUMm1EK1A2TUx5ZkY4cFpXYm9YTE5XaGdyYk53akkyOVExMHd6cUU1MUxm?=
 =?utf-8?B?U3NsREdVcEhiaTNJQ0xpTHNYT3hoMVhCVHhCMlJMcVZhblF5d1lNUVVSamNX?=
 =?utf-8?B?TUVoNXEzVFZhTFdGZDRWL0lCUE96RXpqWXJHZDRyUlBVQU8wMGVXMC9JUFBJ?=
 =?utf-8?B?M2h5MmN2NnhMMzVscFp0dE5UZnFWeGRiUDQ3OTZadjNCVUNWT2p3UTBTOEtk?=
 =?utf-8?B?Wk9YU2F6WWxFRmpKdEdnTVdudnBUZXM2OGR1czJock5HY0VpRkVFMEw3YSs3?=
 =?utf-8?B?djNrd1k2SmRJZ2paVDZ0TW43c3lYVnJlSUZiRE9vVnlKZlhUMmpaNnBCdjhV?=
 =?utf-8?B?UlBOR0VscWFsUXJTUTBFZytYUUtUWUt0R25oQXBtZ255Z05RNThLcHpsOStp?=
 =?utf-8?B?WXo3Qk9QckVEV2dQcFJjOFQwVjQ4TUdkdno3MkQyZEF2eDdWK0V4WGUvWC91?=
 =?utf-8?B?MlVmdjB6RmtieGM5VUx0ZWwra3pnRzFUakZ5eHg4NnFzUlNmRWU1aDFrMk5C?=
 =?utf-8?B?a0xWTkxCWmsxUVhsYlZMWFpZakhoYVkyTHk5TlpLUkJJN2JqS0tMT3gwMnhB?=
 =?utf-8?B?RVRSdnlXejRNRVdLSHFHZ2R4djVEMkVacmNFL3RGR2gvUXRvT1ExQmlYRFJv?=
 =?utf-8?B?cVJMemM3RFo2WHlLU2hyQThXNGNoTk50MXZMOGJIRW43UVZROU90RzBwVmdz?=
 =?utf-8?B?K2tLQU80ZVpNMkIzeG1CZ3ZGZHhJNHAxR3BkV1piQUhETXQ3SUNQa0RuTEFQ?=
 =?utf-8?B?YWVPWXU1YlkvejNKT2JnejdzV29nN2E4WFJzWE1nM1VWbXVFQUhmR0VhVm5x?=
 =?utf-8?B?VnByRlpGYkI2Mld0YjBIRzlTNFhNK2t4aTgzWWNzSW1zeXZ3dldRRmsyRHFz?=
 =?utf-8?Q?xsbMs8+/8PZadpzaVGJd8qssu?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 257971ac-86a6-45c5-9ed8-08dc754d674a
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 02:10:48.7324
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4Zpmmpr+9fISWniUJhLMK2oPiC2JnEVkQOconKMXd6fWVge+evOOYDrxqu6uU45XI1wMvfL6quRcEUkSeKb/KQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7039
X-OriginatorOrg: intel.com


>>>> +       gfn_t raw_gfn;
>>>> +       bool is_private = fault->is_private && kvm_gfn_shared_mask(kvm);
>>>
>>> Ditto.  I wish we can have 'has_mirrored_private_pt'.
>>
>> Which name do you prefer? has_mirrored_pt or has_mirrored_private_pt?
> 
> Why not helpers that wrap vm_type like:
> https://lore.kernel.org/kvm/d4c96caffd2633a70a140861d91794cdb54c7655.camel@intel.com/

I am fine with any of them -- boolean (with either name) or helper.