Received-SPF: pass (google.com: domain of linux-kernel+bounces-180572-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <15511740-ceba-42c6-abf5-b74a757a2930@nxp.com>
Date: Thu, 16 May 2024 10:33:44 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 6/6] drm/panel: simple: Add Microtips Technology
 MF-103HIEB0GA0 panel
To: Aradhya Bhatia <a-bhatia1@ti.com>,
 Neil Armstrong <neil.armstrong@linaro.org>,
 Jessica Zhang <quic_jesszhan@quicinc.com>, Sam Ravnborg <sam@ravnborg.org>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>, Thierry Reding
 <thierry.reding@gmail.com>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: DRI Development List <dri-devel@lists.freedesktop.org>,
 Devicetree List <devicetree@vger.kernel.org>,
 Linux Kernel List <linux-kernel@vger.kernel.org>, Nishanth Menon
 <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
 Praneeth Bajjuri <praneeth@ti.com>, Udit Kumar <u-kumar1@ti.com>,
 Devarsh Thakkar <devarsht@ti.com>, Jai Luthra <j-luthra@ti.com>
References: <20240515095133.745492-1-a-bhatia1@ti.com>
 <20240515095133.745492-7-a-bhatia1@ti.com>
Content-Language: en-US
From: Liu Ying <victor.liu@nxp.com>
In-Reply-To: <20240515095133.745492-7-a-bhatia1@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
 =?utf-8?B?bTdTa0t6enJjN3ducjh1czNka0I2Q1dZUkh4RWtONk92T3pIQ1pVWjMrTVBl?=
 =?utf-8?B?cGxOWWV5Y2NKeEhibE45UlJmZXBHVzBBYzNHRFlhU3V4aldaeUJYa0xJOE9J?=
 =?utf-8?B?dkxGcGpZZTZCT0pIRlFIQUdobTIvTWVLaG5mZHl0d3J3YVBYWTlvcXpiblJN?=
 =?utf-8?B?L3lXRDJud281UVAwNTBzNEFnYXA4UHVleDFyMEJGQzdmWTRUdytDNVFPR3RL?=
 =?utf-8?B?UGpMdEtkNjJHVXN1Ri9SVzNBeHpGcXRRU0JBMzJOV01hOUNJenlHVVNCOWVH?=
 =?utf-8?B?cDd0ZDRSUjJaZVJxTjlMVDIxYkx6ekkvKzVUMG9VUUdVQWs1NjVsUi9lbldm?=
 =?utf-8?B?b1hkbk1xQXlQVHVWeUZBaitVV1pTa1YyTFVEaXlXc1JrbldpYlJZWW9aYldx?=
 =?utf-8?B?SHVQMFpVRFdZTDdFN2s1THNMSnRsdjVrdm4zd2RwNHZ6YnIzOTQxNzU2STBh?=
 =?utf-8?B?STNxczBwU2ZXbFdmdnc4ME5zRk84RDRkcDdSMWF6b3pmbTcyTjdLNDJxRDZW?=
 =?utf-8?B?UVlnZlFnRGdCZTJLZTBld3pzWHZjalVDQ1VvZEo3MzRBMk8vemFUaVQ4bGtC?=
 =?utf-8?B?YTFvT3crOEVjMWhQbW12MFZONnlsTjFVcmRqOHpjeWcrUVYwcW0rNktoUWdY?=
 =?utf-8?B?SlFGYXA5dDZTb2V1TG4yeVBBREdxZDVLMEprZmtIOVN3Z1VBQTBmMTdaSjhj?=
 =?utf-8?B?YWIzRjFLd2l4QmRZQzROSWdxV0twd0FGbEZMUHIxdkg4cVBhWXZoNnZHZHhB?=
 =?utf-8?B?UHhSSHZvQzgwYzNiWm5mMHVHdDZaWXl3YXhReEoxb2t0dTVaMitMRmxsNDc2?=
 =?utf-8?B?SEhGZFF6TVFzd0tTbFZyMkhMQnF0VnN4WjRFRjY4aXR0ZEtpdE9ITDY1b0tr?=
 =?utf-8?B?MEtDNGJ2a0xBZWY2NFhCbnUxRWMyY3JuTmFjcDJEYkZwUHlXZnJJaWVyWjg3?=
 =?utf-8?B?NitHQllxQk11TTQ5WUtMWDBDWEFtZ3J1YXVlMEtMdFNONks0ZFMyU3lDa3ds?=
 =?utf-8?B?RGF3bzk4MWNjZW1lMiswQ3VCc2dSTitjWU1yWEVkUGFGM0tvYWJ6Wmo5dHBq?=
 =?utf-8?B?TSsyZXpuUFJtcDJFWGprSGJ4VFlGREk5RUpXNCtXbVJlV2c4OVZVdk1aZC9w?=
 =?utf-8?B?engrWHBlUFIxbUVyNXJOSmptcnpvNlJaclhxTTRrNXliaFpBbTdwQTVQYmdS?=
 =?utf-8?B?TElrY1pqNzA1ZUIrMDVadGtITVBiN3dkdHh2NzZvMGVmNWs3SG1zd0JyOFVq?=
 =?utf-8?B?N2RsMEVrU0k2QkNRZmxzOHhQcHJ1NmtOb012RnJwY01QWTAwbFVKRUtxRE9G?=
 =?utf-8?B?RjNMZGZpOEhaakFTTHlKNWlDSGhET3Z0amJ0NlpsSE00eWRMa0ZNK3lsVDNn?=
 =?utf-8?B?azM4dE5SdC9FYndsZnpoUnY3Nnpkc01mMUJXVzQrUHhEWUZEbWtaZmxZY3ZB?=
 =?utf-8?B?MGhJTVdxOXFLY29Rdm1CMFB5TmZrUFJudlRHUm4xNlZCQmc2SzBiZFVBaDlZ?=
 =?utf-8?B?ZlBBdGwwaHlNLy96U2pmWElZUmRRWHNodVkzTlRFTzUzT0Jaa08wdmRlbW1J?=
 =?utf-8?B?cDFJRFg0QmhrTldMRVRaNnFTNU9ZcWFEeWlheFV3OVhqRytPVGZTcnhTMWFJ?=
 =?utf-8?B?Y0szTWo0MDhkWGJiQmNuSndHSUR6cW1zcVY1UHZWaFArV0hvaGJlYUFQZi96?=
 =?utf-8?B?dG1qcXc5TjU4REdKWFhKbDdzYnB3THorck1sTnl2bGxNbHJPU1ZTV2pGMVEy?=
 =?utf-8?B?cjdOdUtCN3dXdHNDbjE4d0RtTUVGMHdlRWlrWEd0S3lIbmU4NnpnRm13RVUw?=
 =?utf-8?B?NFJQRnFXaDVac0NmalZqemZBZG9peVJzWkNON2VTcnN3QmNmdXBMMXc1UUQz?=
 =?utf-8?B?OUc4TDdWZTdUZzNZd21sMkdudDN3UU9uczV4dzhFeXVpaFJzVVBGMWo3b1p2?=
 =?utf-8?B?ekRDQWlKekk5S2FPalRVeE5rT1FGbHlaelR2VTlUand5ZkRRVFlmUWRmWHBa?=
 =?utf-8?B?aHRHSmttekJDWXhkUXBJbnBKc0ZpOWdTQ0trdFlvOWpBakhjVkIzb2QreldT?=
 =?utf-8?B?QW9PKzNZYzAxZExkRzhubE9aNElwRXJLRmxISVhnbUcxWGdtU05ncjNvdVhw?=
 =?utf-8?Q?MkjJb0Qp3WBfnpBGRFoy52M0a?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53cdb9a1-e5cc-47a2-54f0-08dc755091ee
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 02:33:28.8972
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D7YdLP5urQlYIznOEpDN2nekFEzB9cKHk2TcnIl2Id0U/bBg2dZGPl+T/80TCMBIRpZMs4JnhYXtnpg+JB5uBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7814

On 5/15/24 17:51, Aradhya Bhatia wrote:
> Add support for Microtips Technology USA MF-103HIEB0GA0 10.25"[0],
> 1920x720, 8-bit TFT LCD with LVDS interface. Its a Dual-LVDS Panel and
> does not support touch.
> 
> [0]: Panel Datasheet
> https://simplespec.microtipsusa.com/uploads/spec/datasheetFile/2660/13-103HIEB0GA0-S_V1.0_20211206.pdf
> 
> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

Like my comments for patch 3/6, this panel is not simple enough
for this driver.

Regards,
Liu Ying

> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3a0d8f0ff267..1b0a6b4e034c 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3084,6 +3084,35 @@ static const struct panel_desc microtips_mf_101hiebcaf0_c = {
>  	.connector_type = DRM_MODE_CONNECTOR_LVDS,
>  };
>  
> +static const struct drm_display_mode microtips_mf_103hieb0ga0_mode = {
> +	.clock = 93301,
> +	.hdisplay = 1920,
> +	.hsync_start = 1920 + 72,
> +	.hsync_end = 1920 + 72 + 72,
> +	.htotal = 1920 + 72 + 72 + 72,
> +	.vdisplay = 720,
> +	.vsync_start = 720 + 3,
> +	.vsync_end = 720 + 3 + 3,
> +	.vtotal = 720 + 3 + 3 + 2,
> +};
> +
> +static const struct panel_desc microtips_mf_103hieb0ga0 = {
> +	.modes = &microtips_mf_103hieb0ga0_mode,
> +	.bpc = 8,
> +	.num_modes = 1,
> +	.size = {
> +		.width = 244,
> +		.height = 92,
> +	},
> +	.delay = {
> +		.prepare = 50,
> +		.disable = 50,
> +	},
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
> +};
> +
>  static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
>  	.clock = 30400,
>  	.hdisplay = 800,
> @@ -4726,6 +4755,9 @@ static const struct of_device_id platform_of_match[] = {
>  	}, {
>  		.compatible = "microtips,mf-101hiebcaf0",
>  		.data = &microtips_mf_101hiebcaf0_c,
> +	}, {
> +		.compatible = "microtips,mf-103hieb0ga0",
> +		.data = &microtips_mf_103hieb0ga0,
>  	}, {
>  		.compatible = "mitsubishi,aa070mc01-ca1",
>  		.data = &mitsubishi_aa070mc01,