Received-SPF: pass (google.com: domain of linux-kernel+bounces-180579-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Yuan, Perry" <Perry.Yuan@amd.com>
To: "zhida312@outlook.com" <zhida312@outlook.com>
CC: Peng Ma <andypma@tencent.com>, "Huang, Ray" <Ray.Huang@amd.com>, "Shenoy,
 Gautham Ranjal" <gautham.shenoy@amd.com>, "Limonciello, Mario"
	<Mario.Limonciello@amd.com>, "linux-pm@vger.kernel.org"
	<linux-pm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "viresh.kumar@linaro.org"
	<viresh.kumar@linaro.org>, "rafael@kernel.org" <rafael@kernel.org>
Subject: RE: [v3] cpufreq: amd-pstate: fix the memory to free after epp exist
Thread-Topic: [v3] cpufreq: amd-pstate: fix the memory to free after epp exist
Thread-Index: AQHapnNS2Fs0k0Uj1kCoPfk5W0R3R7GZKPvg
Date: Thu, 16 May 2024 02:48:48 +0000
Message-ID:
 <CYYPR12MB8655ABCB32C6B11C6B382E649CED2@CYYPR12MB8655.namprd12.prod.outlook.com>
References:
 <PUZPR01MB51202786825AA6A93383B7AD92EC2@PUZPR01MB5120.apcprd01.prod.exchangelabs.com>
In-Reply-To:
 <PUZPR01MB51202786825AA6A93383B7AD92EC2@PUZPR01MB5120.apcprd01.prod.exchangelabs.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels:
 MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=48993ae2-5ef3-4cc1-9a62-e1f708bf4b65;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD
 Internal Distribution
 Only;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-16T02:44:15Z;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: CYYPR12MB8655:EE_|SJ0PR12MB7005:EE_
x-ms-office365-filtering-correlation-id: 8363829d-ddc5-4582-e752-08dc7552b675
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;ARA:13230031|1800799015|376005|366007|38070700009;
x-microsoft-antispam-message-info:
 =?us-ascii?Q?PcT4bxsds4pnVSSPmkznSJkGWj0y8Dl0d6TYKJ5ojh1JzKjBREfAcQV+XEAX?=
 =?us-ascii?Q?79P8ZogZ6LHukATbuOn/Ul8O/l9NRQsPse3SPls62rv7BXZfA0V8UivuDIvo?=
 =?us-ascii?Q?Juyk8PmokqTbNfC3Igo9RTc2SLc2xqOnuSexXOfnLzhVU5e0MNDMBEtue9My?=
 =?us-ascii?Q?mUFpsKb94Yng6cHzYQehuC7113BQtIVNsnKFtoNVrw76P6diOTjHAk8/zy5V?=
 =?us-ascii?Q?jVuyo44cTRbrQr1+pubZZeFIDeV0/8ehCNBd8E1+E+FukI3VUj5enMmEbvA6?=
 =?us-ascii?Q?KRab2MhxvxoMOhrE5XiXuMFLcfUjYalMV8/abHvSqtxmK0Vr14cnFl/ARmm0?=
 =?us-ascii?Q?DN4vCZRP/fqu7Ie3A8fW44JuXKcBzx3e0Mdw5jBJ1HTsqapHSy6trGmfYp4m?=
 =?us-ascii?Q?RhPFVvhnblY9Fz6HDzF0MMW7sgAh5LNMF+4DHncsHXKTjiu7EQfXZ0l8Gy4b?=
 =?us-ascii?Q?/qg4WxHMSLCbpDgk+RskLUJ9k1p5RO1Yd2MGYKt/4I60p2BbFHLPpF7106Lj?=
 =?us-ascii?Q?1g2sB/wRSK+N724AG1gDzDcOpYjPSHQPt2AH7Wz3z7bZzqzwhkDofXvEU8kI?=
 =?us-ascii?Q?KGnerthcZuUBIaMyLlaslM7zHCqcf6Wg2TpuQtwZpYn9/cxaOroBqsSkq/IL?=
 =?us-ascii?Q?3LqKKi7QMubvggrEXzu5hQ4o2ZTUNMZh11xwNulpjbZH+5bwyOMKUbVbXN+9?=
 =?us-ascii?Q?63IWeXL8cu7jj2pysjUwdpDOf82HNRUzf7HsBnLx6ju2pAtYp0wmTzxvrkZI?=
 =?us-ascii?Q?9qdgvf8quUIOz9OFpnbB9HxWt3+8JKFTu5l5JQyoXvm+ogMySzERyo+t3WT+?=
 =?us-ascii?Q?csGDN6CmNpqYgKgqsZvbwteRPRShB8T+3ddR/xqe2ssiA/efLA1toMfQADKA?=
 =?us-ascii?Q?IzSPOk9tcvnUE4urmnVNpQnwZbvMOpcU8/bHvz551fxVXwIQZM8wZLKloA7u?=
 =?us-ascii?Q?T/YTLm0f1gqJj4Qj9/V9H/6i8D92malYMUcpTrv41Dwh3EQc88brYV/N3+L9?=
 =?us-ascii?Q?x2qKh3cu8LzIwaa6OpHWEh8hXw5RFfTTryqRK7rNK16S/HaqZhW5BVPFk8c0?=
 =?us-ascii?Q?dfMdDhR5/5ECZ4kPBDdm2Oh0OSc/qz5WdakmECC+6i2clSj5Sfmg19VmF6+U?=
 =?us-ascii?Q?hYvtLnez20ZYiuMwjPqu0dN8xjYXwRlAKNWjaFCYbGHqextBhePyR32JrsCY?=
 =?us-ascii?Q?K0Acrlj+eYqFgoRJ3VxT5VxTnBITwJqVgRitaeaStEPIgCT8o6UpozsXdRZC?=
 =?us-ascii?Q?4KMOZP+AWOnyQsPTjAB+nRQdwJMYnFG8/S2OwKxhuyQO+89WOMTEbnWLgou7?=
 =?us-ascii?Q?88Q/tXHVjPRejxHwJK4zE1cp/h9XEPgHS7vhrxItIehW9Q=3D=3D?=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CYYPR12MB8655.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007)(38070700009);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?xo4TRhvJIVXdVK3ciNGfDLKN3p4+L/Ex+JKhN9VTIW7IeLW77P2ftxOMQU1N?=
 =?us-ascii?Q?Q2qdEbKSYqAA3V3VL/SDRKJsbEfsYJOdxB93rJ03+z7r8SeOrX0+ivuab7Vl?=
 =?us-ascii?Q?lBYvPppILAkAnGxU3YxbhwA2HCkukxOzb6wSsUvpUevlhHBf91YXYqdY9QIG?=
 =?us-ascii?Q?CKyPUVe6QLEIrQgz4hBxWDvdzyQ1JUmQdP1JZVhp3WggKJeBPN+EZykHF63+?=
 =?us-ascii?Q?sSnu6w2FLZlYUw4CEEryjWorEODW535yn+QHbi5C/krDKs4DHfmR7UwTlHDL?=
 =?us-ascii?Q?NIDPCQ2a9Cu3gNajzUUM3DWrCxF/s5VvDSQvbDj93BeoIS8/qvwi2DDtdQIc?=
 =?us-ascii?Q?yX/eO1Gbd75OMUs25luDPTOcoeyr1e0xvLajBqj8doIiZOmHWWFpyj17Vsdw?=
 =?us-ascii?Q?DV1Hcb1R+7ZAIwr2c3gR/1cY9Eg+InKhRNYO+91nPR1a+fleG4+jcJdgL5Ih?=
 =?us-ascii?Q?asGZWTAA33QkWxPlw4irKBStOrgx90r+5aJGjSV7zb+FE4jzZw7DBmKd8x8R?=
 =?us-ascii?Q?x66F4NYKZdZCYOGWb+nbl1utrfuq/G+q9iwbmBRp+oCWw/wTkgyUflIm8RuZ?=
 =?us-ascii?Q?i2r9BONGDjH0D5PHGtKDNurTSuAy00ikXmH4/I0TO4julyPygLgzfBPuJDT9?=
 =?us-ascii?Q?dYv4VZNXgcq3L59+hLJZWM2jgGSKz8gT5O2skZvq+JjNvMrLbVEbuQC42Dq/?=
 =?us-ascii?Q?xsp1BLl6F/pEkKd2XB0C9pE7r3CxpvA4fzVLRr3n3x0mxd80J9VRY/5omwIi?=
 =?us-ascii?Q?/J0i818g/5yTDZFLvjtAO17K67rSh5uAzlFKPYfEFrLFFUyilRevEZJBqd5u?=
 =?us-ascii?Q?pXKvFipltWU+MMRDphI2MQ1ls0x92nxF2V7ryvvDUTNWJNC2e8QCx/zWO+/u?=
 =?us-ascii?Q?eqOrf7mqx6Yf3okFYNA5cNxR7ehtfMfEnAEnhKhLkKgkJZoahM7bi3Eu+2qD?=
 =?us-ascii?Q?9EmtexDjiGgpDMxIeGKn58PjVed+3L2D378tnNRE2pr5DAw5cImyrwJyIXEG?=
 =?us-ascii?Q?i04urstt3VdjXee17xYDBNmYGUexfuXQ2eVbXa9wqhkvDShk4dkJQ9qJ2Nq/?=
 =?us-ascii?Q?zM487l7Kq/AZnc/YTRDObSNPcgKSvGTB6WTZ55bM7wDw5Y8us5zNpV1lzJCE?=
 =?us-ascii?Q?nNpeuv35hnEmiHud495NuECMeUFmGNoDgS5W9CORQFjbmLuWerJK8ZwPvl22?=
 =?us-ascii?Q?8LWSXl10QAs+DmgyzurnIgKAYZAGpMewaIZNkRcmVM6vhV6EK93xBOmVjA7x?=
 =?us-ascii?Q?Q5VXxF34LJzIqMmcdSSd9MCq+tN3lXgsZzmgWp70ScbmrtkTCLotL+Bp/PCA?=
 =?us-ascii?Q?Vr+OqgNtzTWKVmrxU4ddjMk9l+7CTQEvFACSByL8RUG2SjBeyxTUzAPUNXzA?=
 =?us-ascii?Q?/6hCaBNbuXRfZwJxpjFU+U4dKyuVDomllzSM4xmNR1BgyGyehcTWSZOn5HM+?=
 =?us-ascii?Q?jCNrOC4NOkdHqVkeeSjdftvmjZkAdmNjdyt7wOP8MQfnNe+5Kkw6MlVZflru?=
 =?us-ascii?Q?Y4txUybkqN8Zhduo7lyDT9eDG5wMGF+Lnekcltp2uiWwW6V/nWGeZAU4Jr/k?=
 =?us-ascii?Q?nC/tC3gRJ/VTv/jsv3w=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CYYPR12MB8655.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8363829d-ddc5-4582-e752-08dc7552b675
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2024 02:48:48.8399
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UoTQ+vQ6X0549PbdxD0nbaZezg9b8A4hZ8CVaCP9knD93kflR0QijHkg3hGpvFr9iYXlVF0DQBvI7N4DqpI74w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7005

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Peng,

> -----Original Message-----
> From: zhida312@outlook.com <zhida312@outlook.com>
> Sent: Wednesday, May 15, 2024 10:54 AM
> To: rafael@kernel.org; viresh.kumar@linaro.org
> Cc: Peng Ma <andypma@tencent.com>; Huang, Ray <Ray.Huang@amd.com>;
> Shenoy, Gautham Ranjal <gautham.shenoy@amd.com>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; Yuan, Perry <Perry.Yuan@amd.com>; linux-
> pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [v3] cpufreq: amd-pstate: fix the memory to free after epp exist

The subject need to be update as below. " git format-patch -1 -v 3"

[PATCH v3] cpufreq: amd-pstate: fix the memory to free after epp exist


>
> From: andypma <andypma.tencent.com>
>
> the cpudata memory from kzmalloc in epp init function is not free after e=
pp exist,
> so we should free it.
>
> Signed-off-by: Peng Ma <andypma@tencent.com>
>
> Changes since v2:
>       update Signed-off-by to Peng Ma <andypma@tencent.com>.
>       set a space between if and "(".
>
> Changes since v1:
>       check whether it is empty before releasing.
>       set driver_data is NULL after free.
> ---
>  drivers/cpufreq/amd-pstate.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c =
index
> 6a342b0c0140..1b7e82a0ad2e 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1441,6 +1441,13 @@ static int amd_pstate_epp_cpu_init(struct
> cpufreq_policy *policy)
>
>  static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy)  {
> +     struct amd_cpudata *cpudata =3D policy->driver_data;
> +
> +     if (cpudata) {
> +             kfree(cpudata);
> +             policy->driver_data =3D NULL;
> +     }
> +
>       pr_debug("CPU %d exiting\n", policy->cpu);
>       return 0;
>  }
> --
> 2.41.0