Received-SPF: pass (google.com: domain of linux-kernel+bounces-180613-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Yang Yang <yang.yang@vivo.com>
To: Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Mikulas Patocka <mpatocka@redhat.com>,
	dm-devel@lists.linux.dev,
	linux-kernel@vger.kernel.org
Cc: Yang Yang <yang.yang@vivo.com>
Subject: [PATCH v3 4/5] dm: Avoid sending redundant empty flush bios to the same block device
Date: Thu, 16 May 2024 12:02:33 +0800
Message-Id: <20240516040235.115651-5-yang.yang@vivo.com>
In-Reply-To: <20240516040235.115651-1-yang.yang@vivo.com>
References: <20240516040235.115651-1-yang.yang@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?C0+vmcGrBrcHUoHV90iGBt6PLFd/qXcECOu7NXB6j1EJEYu0qx6EOYuGBkV2?=
 =?us-ascii?Q?s0H4IyaSsjwtTlYjhwpu06mbxMcVBNkub7FP888fOCJxGGeuJyIOg8nTTB3w?=
 =?us-ascii?Q?h+5Wch8k9mz3yn4kGHRhlSeq1/gL5N/XwEMH6Qj3spJSE2CtrDtk18wHi8Nt?=
 =?us-ascii?Q?R/D1b/LsNFNB1w8iIBL7nfgP8mYdGfEkd2khO93tKgvWijVXxMAClyNwHqXK?=
 =?us-ascii?Q?D07LAr+mYAosLMyB9deRpD9vf3mH++uh/rErvNZgSLLCqJQzhqA65mnFk7XT?=
 =?us-ascii?Q?ChwwxxhLM7iKXr4gAp6HUZ7HNKZM++i6BLr9k2G1NS8mf8mpAtqC2LdgNbF9?=
 =?us-ascii?Q?kOkjTenlIV62zaSJw0sVkbYYtprCFqFvMM7uUAxoPY5bTCghWBhp02JzrTGq?=
 =?us-ascii?Q?bokDi8ak/4sn6kFgj5to+YeOTff7IZu1nJ7mNpvq4f04u4OZN+1lWI1yhKca?=
 =?us-ascii?Q?qDukUZchPLorsIwoaXUmFvnN6CCKzFHs795B3+ZhysE4htwLFQZgqxfilh7j?=
 =?us-ascii?Q?an43kDulxpZNnEJlfIwmpv0f9HLIAZvSC4fgkjLeJCPuF7Y50ovjtIKKu8Mz?=
 =?us-ascii?Q?02PuK9B03dAIOEVU2fAhHFuSgYRny/tUhkyS5qD/4agzAWKzfdq0FRw3WMQZ?=
 =?us-ascii?Q?V0Kw8fuqIMKCqUrShseQJRExEaSzVFpCbM8szHhoC+dO1qdK2r+8r5p7bJDX?=
 =?us-ascii?Q?d/4WV/k/tGcElBsyJWdf7dg5kKB709UbUe+wfYwcieb/N8ZTz5vTFqVpdqYI?=
 =?us-ascii?Q?ECIW7IT3e5RjVU9uo+cEv1Yc25qSwJdAtRMlQyjzDe1xWDKBdXZe4ocVPVzW?=
 =?us-ascii?Q?vL/eZmqFrqugMMjxtOovG6BlMXROiXSPo2opT7aS1bvxMD2vZhrOthfa5bj1?=
 =?us-ascii?Q?/Wepdl46Mnz0tOVSiNB3eVvWLG+k1t5z0LM4KLYX1jh9YZuQeJFB5OLUMHWy?=
 =?us-ascii?Q?pz2nBPQllQPXvvHt8qGAdectxX/Yvlmsa9yOO6vXRSvDSDvHIvNGSVKo5WA0?=
 =?us-ascii?Q?Ip39fQ4Uz1U+z/J5sBmKTPtQ10UWgRr3ncXG/57+HJePUjNZb3vckeuzm5pY?=
 =?us-ascii?Q?6D2WN+xycjT9vw38h/WbmSkyB5KazxeYGwnkzOe6YHfZxdRXBL3ZYjChxIwR?=
 =?us-ascii?Q?eSSB6gncYGnMJX0qw8Gw+BOGGL874WREH7owkK9IuWYOLVtvPt611Uhcvzqp?=
 =?us-ascii?Q?0EwL9HdQ5iaYOmQbzZNqiJybhZZn5mSWbeGW73pitIZp3esIpFzOlbZ3A/cL?=
 =?us-ascii?Q?x/vQ1YDxr7xsH3tqH9/dDUhbddrZwJjU8OcWUxK9J7hjTlI/QliTCpcITkyH?=
 =?us-ascii?Q?h4llBZZgPIAUGCFJFSjxqLU8C8xw+2UEbWwQj0Yf9tITqf3hYXehKgHKjPVo?=
 =?us-ascii?Q?1VJsbssgPnUAlHUrHtCjM2EG1aSDYTng/nim8Dqn2CoWcP2t2akk4sxzTa0b?=
 =?us-ascii?Q?mcEPnAGPMkOAdcFsYC9EfS6djb+zUpvw5/h+z4tk7uJyK92bnLuZEicajkIQ?=
 =?us-ascii?Q?StnEqxoXqtkwmqBNj1cjp+yGz/2J9k5LIRRImGhDvG5xkftDZTKLoq0Da47X?=
 =?us-ascii?Q?RD6r3ySHocoJoFRYh8Q/LcIF+j+ztEvJrBPm2Yky?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b89b3dc9-ed10-43ab-ca0b-08dc755d1832
X-MS-Exchange-CrossTenant-AuthSource: TYSPR06MB6411.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 04:03:07.9543
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CXCPGhp6pFtCw+jrl1s5RCiGxcrIuvMBU+KnfJB3rg9bisfFXPE3lACIbhgpk799qQI+91zmPvclQc7g/Dk1cQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6807

If the num_targets is greater than the number of dm_devs in the
dm_table's devices list, __send_empty_flush() might invoke
__send_duplicate_bios() multiple times for the same block device.
This could lead to a substantial decrease in performance when
num_targets significantly exceeds the number of dm_devs.
This patch ensure that __send_duplicate_bios() is only called once
for each dm_dev.

Signed-off-by: Yang Yang <yang.yang@vivo.com>
---
 drivers/md/dm.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 25215b93c3cf..9dd0f5c97028 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -1561,6 +1561,7 @@ static void __send_empty_flush(struct clone_info *ci)
 {
 	struct dm_table *t = ci->map;
 	struct bio flush_bio;
+	struct dm_dev_internal *dd;
 
 	/*
 	 * Use an on-stack bio for this, it's safe since we don't
@@ -1574,10 +1575,18 @@ static void __send_empty_flush(struct clone_info *ci)
 	ci->sector_count = 0;
 	ci->io->tio.clone.bi_iter.bi_size = 0;
 
-	for (unsigned int i = 0; i < t->num_targets; i++) {
-		struct dm_target *ti = dm_table_get_target(t, i);
+	if (!t->flush_pass_around) {
+		for (unsigned int i = 0; i < t->num_targets; i++) {
+			struct dm_target *ti = dm_table_get_target(t, i);
+			__send_empty_flush_bios(t, ti, ci);
+		}
+	} else {
+		down_read(&t->devices_lock);
+
+		list_for_each_entry(dd, dm_table_get_devices(t), list)
+			__send_empty_flush_bios(t, dd->dm_dev->ti, ci);
 
-		__send_empty_flush_bios(t, ti, ci);
+		up_read(&t->devices_lock);
 	}
 
 	/*
-- 
2.34.1