Received-SPF: pass (google.com: domain of linux-kernel+bounces-180703-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Hariprasad Kelam <hkelam@marvell.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
        "David S. Miller"
	<davem@davemloft.net>, Andrew Lunn <andrew@lunn.ch>,
        Eric Dumazet
	<edumazet@google.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jakub
 Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
        Vladimir Oltean
	<olteanv@gmail.com>,
        Woojung Huh <woojung.huh@microchip.com>,
        Arun Ramadoss
	<arun.ramadoss@microchip.com>
CC: "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        David Ahern
	<dsahern@kernel.org>, Simon Horman <horms@kernel.org>,
        Willem de Bruijn
	<willemb@google.com>,
        =?iso-8859-1?Q?S=F8ren_Andersen?= <san@skov.dk>
Subject: [PATCH net v1 1/1] net: dsa: microchip: Correct initialization order
 for KSZ88x3 ports
Thread-Topic: [PATCH net v1 1/1] net: dsa: microchip: Correct initialization
 order for KSZ88x3 ports
Thread-Index: AQHap2KYtFQlblzcdky1cgB9oid70A==
Date: Thu, 16 May 2024 07:28:07 +0000
Message-ID: 
 <PH0PR18MB4474CE8F239C66F349F043E1DEED2@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20240516070852.1953381-1-o.rempel@pengutronix.de>
In-Reply-To: <20240516070852.1953381-1-o.rempel@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?ysbwMol5Z9ZUDuX64sXNy3bmjar4JE5ysepyOSrPSU6psvAU0/t6Ok00hc?=
 =?iso-8859-1?Q?FdhBIN1kO7jaiGHeXDoEGyxAJAf7cdMx4a8n/SPvc8sgQ6+jwPFJNpVu13?=
 =?iso-8859-1?Q?u61OcB8ZwBwnOngSLlUJT0lGVVnY8wjTQH00EVQOOUiney9na3/n6b62K6?=
 =?iso-8859-1?Q?W9ZItcQFaWgrYjUdnyqPI4vkin1kKoU8iL2GPfyKK6S+pzLHf/g9SqM47R?=
 =?iso-8859-1?Q?0cYwZHC9RJvRuf1BGo/GJdKr/NJcTOFn9brMtlLPNjU3biO1QeHQIf748T?=
 =?iso-8859-1?Q?AwJc44DVOGXupWcqfEqSWbuSb///810Ohum9VQ7ThwFfxEoIpQuKw3zZ1J?=
 =?iso-8859-1?Q?3SYnJVOfDFXmkrR/YkpookaspdqwLymBwvQRRedEiRo2XTTNg0vf2hDVBP?=
 =?iso-8859-1?Q?36aLAy3A6PEiV90m7koB3fRSqD7R/5hQl3z/qeX5apku7+/QiI4Pj6bDaH?=
 =?iso-8859-1?Q?ClkEvY5fCMPTqfw2GkbLbD3Bhhz0i7w62tkWMdFCqrFk+OwN1MVDVwDopg?=
 =?iso-8859-1?Q?CWqnwou+xkCzBn41ldc1IdpeDRihVJ6STBh3oVPwKY8QbkNo05ChwWgwO4?=
 =?iso-8859-1?Q?P/Qntrg7SoP9fltiF46s113RO1KVu2bj5AqnM0T0AS6RgjZahhQbSi42jf?=
 =?iso-8859-1?Q?AQTVIAelzjZg4EBBjjrpv8xNmasf/yk8eHwdyYGURAD5+DaAomGT14jmsH?=
 =?iso-8859-1?Q?SVeA7cEkKadGZ6F+7ObzWNNr5R9tPHg3Ee5qd3kI8sDj0FluBSLtCSwIIH?=
 =?iso-8859-1?Q?tE5CRVHASHofj1XaWU8iOiUNZBKVK9VFEgufE74bepEG0c41BoAgEIvOnM?=
 =?iso-8859-1?Q?xVZkyxiK2SL2h88aT6YzWNyap/UmGYeb82xx85FhPfsifW9H2Gp01eIdev?=
 =?iso-8859-1?Q?/6Au4Djou39Tl6ff6PVObiMCWlfLfJB9CuNWWvRTOFyZsSlqU4AuvgWZpX?=
 =?iso-8859-1?Q?vd9OoIv43wnaknBBOfHzgI+kihFweYNFnQS8Ezrf0pNfkk3VnA4fuTgRme?=
 =?iso-8859-1?Q?emUIR7k42mc2tcIk9pkykKIE3K7OjYrehEIW2rqd3C4+6+Wp+Y+xezLsZL?=
 =?iso-8859-1?Q?B6JEIoojVrELuJf0OLpRCkuxRCV2Aey0lSxEJ/wJyIuhta7HIyOg4Z4fZ1?=
 =?iso-8859-1?Q?anvkixL4GLulw18F7taJU/xc3XREUvz0Sz2EUGJuaOcBIV6mVde+t48w5+?=
 =?iso-8859-1?Q?fipDqiIvRJrY4SDLe4yjcnWOdiPmLj6zBtTQckAUXNeLa2buock9jBgFU6?=
 =?iso-8859-1?Q?z1ExfqPy6kZRfoVwLuPCM9jrxFc64lDzRR4GlCiBrKum82DjaCYG3UP/HT?=
 =?iso-8859-1?Q?SHJPevv8ql8e0MYeCg27gDM1Rb1sgc29rUBk0mQucUCQBvCsRok4B4GIqa?=
 =?iso-8859-1?Q?X7Dtj3UjG54j8zssg1+kX+L8KgVT0fNsqqCGAQdpIeUp87tTkVKK4p5Cb4?=
 =?iso-8859-1?Q?kHQAERY6LJ4Bcza1Ots5M7SydH29g2BUf7MktxPumts/F3VOa/1YF6nhBJ?=
 =?iso-8859-1?Q?fiSHsF0iZSrbf2EBRDQ+3NI2GZnYsDmjfOdw6dbkmBQysJv/SUCZIkvCPH?=
 =?iso-8859-1?Q?Yv/9yQXe5HU3ULZxSa/8tHB8mNSsiP7qcDcUa3FbmwSuQt3V8tDSnFsq26?=
 =?iso-8859-1?Q?qK0ze51T3CaOc=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ed4e87e-e667-486c-574c-08dc7579bb2e
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2024 07:28:07.1427
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rwkS1EBZW55O6jCL+eaWKj3dLDkZ4sDl8GgH4rbYFWkyDjMSZLv0Iwn+3pYR6cH2QKEn405mI/Rb+Csxi+fXpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR18MB4234
X-Proofpoint-GUID: 4s_IqH20qhS5lWrz57mYXBRTCMqIOWTk
X-Proofpoint-ORIG-GUID: 4s_IqH20qhS5lWrz57mYXBRTCMqIOWTk
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-16_03,2024-05-15_01,2023-05-22_02


> Adjust the initialization sequence of KSZ88x3 switches to enable 802.1p
> priority control on Port 2 before configuring Port 1. This change ensures=
 the
> apptrust functionality on Port 1 operates correctly, as it depends on the
> priority settings of Port 2. The prior initialization sequence incorrectl=
y
> configured Port 1 first, which could lead to functional discrepancies.
>=20
> Fixes: a1ea57710c9d ("net: dsa: microchip: dcb: add special handling for
> KSZ88X3 family")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  drivers/net/dsa/microchip/ksz_dcb.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>=20
> diff --git a/drivers/net/dsa/microchip/ksz_dcb.c
> b/drivers/net/dsa/microchip/ksz_dcb.c
> index a971063275629..19b228b849247 100644
> --- a/drivers/net/dsa/microchip/ksz_dcb.c
> +++ b/drivers/net/dsa/microchip/ksz_dcb.c
> @@ -805,5 +805,18 @@ int ksz_dcb_init(struct ksz_device *dev)
>  	if (ret)
>  		return ret;
>=20
> +	/* Enable 802.1p priority control on Port 2 during switch initializatio=
n.
> +	 * This setup is critical for the apptrust functionality on Port 1, whi=
ch
> +	 * relies on the priority settings of Port 2. Note: Port 1 is naturally
> +	 * configured before Port 2, necessitating this configuration order.
> +	 */
> +	if (ksz_is_ksz88x3(dev)) {
> +		ret =3D ksz_prmw8(dev, KSZ_PORT_2,
Nit :  instead, just call return ksz_prmw8();
Reviewed-by: Hariprasad Kelam <hkelam@marvell.com>


> KSZ8_REG_PORT_1_CTRL_0,
> +				KSZ8_PORT_802_1P_ENABLE,
> +				KSZ8_PORT_802_1P_ENABLE);
> +		if (ret)
> +			return ret;

Thanks,
Hariprasad k
> +	}
> +
>  	return 0;
>  }
> --
> 2.39.2
>=20