Received-SPF: pass (google.com: domain of linux-kernel+bounces-180718-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a0ecb036-c760-447a-abfb-78fb7928fb9c@amd.com>
Date: Thu, 16 May 2024 02:47:05 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4] cpufreq: amd-pstate: fix the memory to free after epp
 exist
To: zhida312@outlook.com, rafael@kernel.org, viresh.kumar@linaro.org
Cc: Peng Ma <andypma@tencent.com>, Huang Rui <ray.huang@amd.com>,
 "Gautham R. Shenoy" <gautham.shenoy@amd.com>, Perry Yuan
 <perry.yuan@amd.com>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <PUZPR01MB5120A03DFF0EA1CE70E7334E92ED2@PUZPR01MB5120.apcprd01.prod.exchangelabs.com>
Content-Language: en-US
From: "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <PUZPR01MB5120A03DFF0EA1CE70E7334E92ED2@PUZPR01MB5120.apcprd01.prod.exchangelabs.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ck5weVVYV2o5bCtDbXk2QWtyZmk1ckZ4ZEszblZlRzIraTE2S2NLdW5GZUpN?=
 =?utf-8?B?Ry9EWmJwTURBZFAvZTJkQ0ZmZmRHMUhzS1crS0xEUm5LaTFXWEJBZHVNYk12?=
 =?utf-8?B?OU1wWmpwUVFXY0poaTlITFpjY0FUL2lrZnduSkVGaWNXT25uTWZxeHFhZzcy?=
 =?utf-8?B?c1BMZ3FYeUZMZHdZWnBUbU9PWnZoWFVsei8zc3BBdUdreHR4ZFhaYXRDaSsz?=
 =?utf-8?B?TXpKNGtIVktTN1lURjZBS09JR25RdEtLWVZndU9JUyt0S040OGU0TDVWVXpp?=
 =?utf-8?B?bitLZlB1Nmo1WUNhYkdzWUpZSGdOWndFMU8zMnA5eSsrRnFXa0U0Yi9aY3o1?=
 =?utf-8?B?RkhRQXhqNllHWUc0TGExNmRlVmdVdnBRVUlGUk5kOGR4OWhobEFxV0pXZ1lS?=
 =?utf-8?B?aDVOaE9HWXVGc0N0Z3p6STFMNkFuK280SThWV1gydWZRSmFFcStET3ovejBs?=
 =?utf-8?B?cDhaNjN0UHNpQ0JmbVh5MEJLVm0zT3U5bHNrUGRjQzZjbTZnSjJyZmdsOVpw?=
 =?utf-8?B?VDA5Tk10RHRlbFQ2Uy9ZQW9OMzc1SEJpVVYzeWc4QzZCSlZadGI0VUsvUUlq?=
 =?utf-8?B?RytHYVErMnNmTGFDbE5JcU9lVGtGYlZYODFrZE50NjJwbG1PUVBaaFdpV2xy?=
 =?utf-8?B?V0x6cy9pME1sdWxNcDI1am9sNlFKdTNwUVdtWEhScGdpR2lFN0NHcm1JVTkx?=
 =?utf-8?B?cEJERVB4NVBZU0tQNGoxY01xYmd3ZGNwN1pZOFhNOHVzQkptVXU0WWZRMzhz?=
 =?utf-8?B?N1pBVm5uS2xnbCszYTFxMzBaRnNVbDFIZ2tGcFFqb0hWNHE5L1BOWVgzSnBD?=
 =?utf-8?B?aElTRGFSNkNUK2Fvam82T3dXUzNEUy9tYitlWlNBYTgxMjRUM2ZTU0c5bGI4?=
 =?utf-8?B?R3dNNUZUMG1MUStmeC9TMFlubWlGVnFIWXFBb3k0YU04aDVobVJNS0V0RFhC?=
 =?utf-8?B?VXRqTkhjRjJvZ1ZudVZrKytnM0ZjaElsdXVtZlM0aEV0b1BTSldUMGRaM1c4?=
 =?utf-8?B?cXpvTWhFV2VhclREU0dNWUhnK1dqQmtXUWVMcjdWTzFoUHd4bHVJT1BWcXY0?=
 =?utf-8?B?cmJhWWR4Zm95dlZVQ0paMGlCVnJ3VzIwZ0E0VGdvRmZBU2xVY2h0KzZiVVRJ?=
 =?utf-8?B?NWxQMnkxMGZnaDg0RnZ1eEhGbVEzTDZCRzR0VlBGMEFXbW5obW9nNVIwMmFo?=
 =?utf-8?B?cUVrMHNMd0phS2FtTzNFSEZPSnJrVnlXa1hsN1ZjTlUrY2J4czFGMUNJd3Jp?=
 =?utf-8?B?Q3JUOThKNjh5dHZyOThWVE1xY1Q2TVA4cVY1cHovc3VPSmM2TUZTcUgrNTVY?=
 =?utf-8?B?ZWRrMlJ5Tnc2V3RpSVhpOG01Zk5Qd1luOWVKcmhKTUd5bndxVWt5V09YSTZx?=
 =?utf-8?B?bzg0Z2YvaitEcDJJRmlvYjl0Tkc0SG43QUZoSzcvVUVXY3B1cm1TSGZ2K28w?=
 =?utf-8?B?WTlMMmFZR2c1MVFDc0l0NGUvOTZhZ3RCbHJ3WkVlbTRCRDI1b3RDd1hoekF3?=
 =?utf-8?B?ZG5jNFVoSm1ocHE0azFVeWlpeTA1T21QWXBzK0dyOWVJakNUcHkrZFA0NzM3?=
 =?utf-8?B?Q2ltYUxOcXh3T3lHeHF6MEpnUnFsOGhxUDlaY205bWl6RVNJVVZCeVBSdDdN?=
 =?utf-8?B?QnV5WnZRbTNZMWExK0FuTGwvbGtBVE14QXk0NGFwTVFuVFB1Yy9udlhHWmN0?=
 =?utf-8?B?V1V4YjM0bVRtZDB3MWsxd1lONWZWWlU3UVZUMDdNajhPRkh1MXRHcXBVK1B4?=
 =?utf-8?B?K2FLaVI0MGJ4UzgyZVZTT29ES3lJdW9kcFR1Mmp4amsrdXNNUzd6SzF4UFpl?=
 =?utf-8?B?dWRidStHTHFOL1J3MXhIZEsvZndRdUpqL0dxRTBIVklFdkN2ME1LU0Evc2kv?=
 =?utf-8?B?cmhRUGlTRE5CWnFFZzJWdFo5Y0o4eTFCTnMvZXNpK2orV3NtT1BUbFFwUXBW?=
 =?utf-8?B?T1JNTTllVWFDUzhySm15Tzlmb01pWUdDeHRPcjRKY1ptOW5wYkRkNEdQSmFQ?=
 =?utf-8?B?Z0JqaitLY0Y1a3ZqSWU5ZlBtMnVjRy9VVHloSnFyWlVNL25vbHJGNFQwQWcv?=
 =?utf-8?B?QWtuWlc4M0JDL2FjdU9TUEg4bVpCTHVrenQ4UDVOWmdGWWJYclowYmVaOGZx?=
 =?utf-8?Q?0hE5rx68Bt9LLtOaAH8CG0Ea5?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b9f2a33-01e2-4207-932a-08dc757c6398
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6095.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 07:47:08.8461
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mBRwQHHgFeKSODGcZYYOKuc7vkNiBZghg8qav9ztUOW3WT/+niG4cLkV1Fh0rGtRfV5PbkJa5/Z7g7sreQAxJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8966


On 5/16/2024 1:30 AM, zhida312@outlook.com wrote:
> From: andypma <andypma.tencent.com>
> 
> the cpudata memory from kzmalloc in epp init function is
> not free after epp exist, so we should free it.
> 
> Signed-off-by: Peng Ma <andypma@tencent.com>
> 
> Changes from v3 to v4:
> 	update subject used git command "git format-patch -1 -v x"
> 
> Changes from v2 to v3:
> 	update Signed-off-by to Peng Ma <andypma@tencent.com>.
> 	set a space between if and "(".
> 
> Changes from v1 to v2:
> 	check whether it is empty before releasing
> 	set driver_data is NULL after free
> ---

Thanks for your submission!

I would prefer the change list below the cut list, but otherwise this is 
fine.  Maybe Rafael can modify that while committing.

Acked-by: Mario Limonciello <mario.limonciello@amd.com>

>   drivers/cpufreq/amd-pstate.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 6a342b0c0140..1b7e82a0ad2e 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1441,6 +1441,13 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>   
>   static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy)
>   {
> +	struct amd_cpudata *cpudata = policy->driver_data;
> +
> +	if (cpudata) {
> +		kfree(cpudata);
> +		policy->driver_data = NULL;
> +	}
> +
>   	pr_debug("CPU %d exiting\n", policy->cpu);
>   	return 0;
>   }