Received-SPF: pass (google.com: domain of linux-kernel+bounces-180729-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Yang Yang <yang.yang@vivo.com>
To: Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Mikulas Patocka <mpatocka@redhat.com>,
	dm-devel@lists.linux.dev,
	linux-kernel@vger.kernel.org
Cc: Yang Yang <yang.yang@vivo.com>
Subject: [PATCH v4 0/5] dm: empty flush optimization
Date: Thu, 16 May 2024 16:03:13 +0800
Message-Id: <20240516080318.120231-1-yang.yang@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ZnCCE/vPLFumuTu+sTClUrni0UWJwi0hRUdtyqMTXm0U1BqDxunw33mvpQg/?=
 =?us-ascii?Q?BSEQxEj6XEzQWcpH+X4t2n6qwsu6YI1U7huemOUlcR6Jx3ZjAIerctCDumIT?=
 =?us-ascii?Q?qrpbvTd30KR5PIv6wTBvGb67xzQ5BYMM/sJUnZJLkGy3jezfAANrWL+ypBJ/?=
 =?us-ascii?Q?GIAHRMGDzEbN5cMdO3m7tOYUnMKrTGsm9seU9/QTw7eVGMXBrYxpqPxJWTaC?=
 =?us-ascii?Q?85LM+7qoyjy5+pRlqaYCu+OyWObSGEoqmA8pYm3hxMNeZ4rsJ96k4pLWO9zc?=
 =?us-ascii?Q?XNhN0SunIWcYaAAgHtPkSXIcd2bQay0nAMPrM/gDrfQEECr278hJ00Z85PZl?=
 =?us-ascii?Q?JbtaTz0ohFU+Ac8zCcrRBTbdWPwyr6FG+h0Yb+DQAV1G6GHnoQ5HxoPC5BQg?=
 =?us-ascii?Q?OwtDOd4Y/Omb0lv0sZQop35o7TZdOcZbrIGydzg41C2D2V1rbPklHNWmDh+G?=
 =?us-ascii?Q?Km13uSZHqzF18T7Na566alW1YoJ/qqNPQX6XDUd54/5qZnqPTb/dUWZalRHm?=
 =?us-ascii?Q?grUH0qWuVxYpQ1knWzgqwPjac8tGUV3y+QayrJkdupifToM/lr0GZXUrqc4e?=
 =?us-ascii?Q?sqF+vnHtJYE54t16kFsh4KYHqvo7pMQOAIp3IqDxqeU+M0SWp5ArKm6BiFwi?=
 =?us-ascii?Q?PatgQ2i3p8Qy3Fx2DWLrpmJIa8L5hkATAskPaerzpOVPeIb4vaInx8KS2TDV?=
 =?us-ascii?Q?yWRqcHBQ8I2uASJGiKpHAc4P+fDOmSC4sSyXMYq2knVMrUplE4ss+j9WygZb?=
 =?us-ascii?Q?O0GYQWzZc0JSj7WVu3E0NIBC5dq2p3U2vP8GBYYd2tdgva6V7PUyM0rKNRBn?=
 =?us-ascii?Q?cwD6uTkf5n9Pr++CzNUoBREQeuzNMu36WVRdWQr/mbd61VosVQRxYLURebs/?=
 =?us-ascii?Q?saTjtlHPx9pW2ePc6KuhlRKHIkESuJN9gyjjSaipl8AXAn3NcRt5F6SmFlJC?=
 =?us-ascii?Q?iY6VAFIqvyLqHxIjf/poCMU9+wm0TQC6C2lsMknItxSZ3j5IDtRE1+XpMY5U?=
 =?us-ascii?Q?yTIhfpeFQtCQUGCIp816Wjn0/bb2JgAkG8TJOZmLJPh6xpP09WaGwYhwCmu0?=
 =?us-ascii?Q?KaM4/XUjz0syc9PmwwYZvoF4Qw1q6vp2v5h/WxcgzTpkVg2ldqYK+ueyHymD?=
 =?us-ascii?Q?6GonMWPnKJW2PdEmWT2tLpKxSP0QgoPUWOC884pAKdS0mKuY85XgCpz4UR7i?=
 =?us-ascii?Q?MBVHpNER9NuLmwi4Zh0iPJk1kgW8fm86w4CnkHzuHBVgnCDCycxBYNdGORLh?=
 =?us-ascii?Q?7cNt2B6agAg8xyJyeXgIoPkHig9NETPLkYONkwCocFJ4AOkegothyOAZVibY?=
 =?us-ascii?Q?sJj3VLu10CjfnPSnNy21lSeQvri2wZZhfKCs7Pv8HuFCBf9wvQOzZBMUSqvL?=
 =?us-ascii?Q?b2y4gtCLzrjgdNMbVq6D5whhKg579lFanrfSQWqad2s54BbDYnTMXAAq1n11?=
 =?us-ascii?Q?aSWDjsq164VeaHpUjMSLDVhwoXG9T9QV8YQCGcfIJB+FD3Bg88XZtpKl9BEN?=
 =?us-ascii?Q?vY9/EcYxWcYFei15+W/Q8juKNvZwOgwjzeymAjDu/KauFrTVUCfV+TI2zADo?=
 =?us-ascii?Q?Bc+r3HwPe7fCtMZj39Q32Y3G8K7MjQOSBQI7CSGn?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c70dd023-1494-4562-b2b6-08dc757ebfb6
X-MS-Exchange-CrossTenant-AuthSource: TYSPR06MB6411.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 08:04:02.4336
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3khQx5U2S579fJfLjZ1SRc+OMnoLAxzU6MUYuLp/Xo0dc3Y4yZGgwDATIXBLTQLntLiknvgNSdYCneS0dIuhSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6830

__send_empty_flush() sends empty flush bios to every target in the
dm_table. However, if the num_targets exceeds the number of block
devices in the dm_table's device list, it could lead to multiple
invocations of __send_duplicate_bios() for the same block device.
Typically, a single thread sending numerous empty flush bios to one
block device is redundant, as these bios are likely to be merged by the
flush state machine. In scenarios where num_targets significantly
outweighs the number of block devices, such behavior may result in a
noteworthy decrease in performance.

This is a real-world scenario that we have encountered:
1) Call fallocate(file_fd, 0, 0, SZ_8G)
2) Call ioctl(file_fd, FS_IOC_FIEMAP, fiemap). In situations of severe
file system fragmentation, fiemap->fm_mapped_extents may exceed 1000.
3) Create a dm-linear device based on fiemap->fm_extents
4) Create a snapshot-cow device based on the dm-linear device 

Perf diff of fio test:
  fio --group_reporting --name=benchmark --filename=/dev/mapper/example \
      --ioengine=sync --invalidate=1 --numjobs=16 --rw=randwrite \
      --blocksize=4k --size=2G --time_based --runtime=30 --fdatasync=1

Scenario one:
  for i in {0..1023}; do
    echo $((8000*$i)) 8000 linear /dev/sda2 $((16384*$i))
  done | sudo dmsetup create example

  Before: bw=857KiB/
  After:  bw=30.8MiB/s    +3580%

Scenario two:
  for i in {0..1023}; do
    if [[ $i -gt 511 ]]; then
      echo $((8000*$i)) 8000 linear /dev/nvme0n1p6 $((16384*$i))
    else
      echo $((8000*$i)) 8000 linear /dev/sda2 $((16384*$i))
    fi
  done | sudo dmsetup create example

  Before: bw=1470KiB/
  After:  bw=33.9MiB/s    +2261%

Any comments are welcome!

V4:
-- Fix the build warning "no semicolon at end of struct or union."

V3:
-- Focus on targets with num_flush_bios equal to 1 to simplify the code
-- Use t->devices_lock to protect the dm_table's device list

V2:
-- Split into smaller pieces that are easier to review
-- Add flush_pass_around, suggested by Mikulas Patocka
-- Handling different target types separately

Yang Yang (5):
  dm: introduce flush_pass_around flag
  dm: add __send_empty_flush_bios() helper
  dm: support retrieving struct dm_target from struct dm_dev
  dm: Avoid sending redundant empty flush bios to the same block device
  dm linear: enable flush optimization function

 drivers/md/dm-core.h          |  3 +++
 drivers/md/dm-ioctl.c         |  4 ++++
 drivers/md/dm-linear.c        |  1 +
 drivers/md/dm-table.c         | 19 +++++++++++++++++++
 drivers/md/dm.c               | 34 +++++++++++++++++++++++++---------
 include/linux/device-mapper.h |  6 ++++++
 6 files changed, 58 insertions(+), 9 deletions(-)

-- 
2.34.1