Received-SPF: pass (google.com: domain of linux-kernel+bounces-180748-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <fb65e783-4d01-46c3-8e9e-de40811dafd2@amd.com>
Date: Thu, 16 May 2024 10:14:18 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/8] dma-buf: heaps: Import uAPI header
To: Maxime Ripard <mripard@kernel.org>, Rob Herring <robh@kernel.org>,
 Saravana Kannan <saravanak@google.com>,
 Sumit Semwal <sumit.semwal@linaro.org>,
 Benjamin Gaignard <benjamin.gaignard@collabora.com>,
 Brian Starkey <Brian.Starkey@arm.com>, John Stultz <jstultz@google.com>,
 "T.J. Mercier" <tjmercier@google.com>
Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
 linaro-mm-sig@lists.linaro.org
References: <20240515-dma-buf-ecc-heap-v1-0-54cbbd049511@kernel.org>
 <20240515-dma-buf-ecc-heap-v1-3-54cbbd049511@kernel.org>
Content-Language: en-US
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <20240515-dma-buf-ecc-heap-v1-3-54cbbd049511@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?THpmcUZIK1BvSkdaZk9sM1J1SE1tb3JWYXRmRDgvL3RHMHZxVFcyU1R3K0NW?=
 =?utf-8?B?b0V1dlNZalFVL05iOWlFcGJNM1Z5WWRYNE1DalVsSkpZK0pOWjV5TDMvOWV1?=
 =?utf-8?B?a1dZakRhVS9wa3lqNTkxckNhUlNGS0FIa2RaMDVvNElERnVhMHNjbEU5dnZm?=
 =?utf-8?B?YTQxazJESS9FdUxCRml2eGI0eWk4NzdNL043L2dLOEEyWXZtbkNmQm1ZUlhs?=
 =?utf-8?B?dUozZUtUMVg1Y2FkQWo5VjVSNnlZZVorYU1ySDZXUDVDRFdlMmc4bklidTBY?=
 =?utf-8?B?Z3JiSlpWQmN6NTZmMEdzV2RsYnkxd0ljM01rM1pBbkFiUGVtN3lacHE5aUxa?=
 =?utf-8?B?UWVoQnVNdWRCT01sUVFkZE5ZTjhtN2tHdkczQ0FySWNITlpvdEllQThzemx4?=
 =?utf-8?B?cDhHV1FDdXdzN3dUbTFCeHVMUnB2SnFZcTBrajROanhsYTJxTE9IZXRLTEZH?=
 =?utf-8?B?bi9EV0hDKzBBSnB2dnRIVDU1ZFBTckNSSi9sUXE1LzFYR0RNWERHYjczelJD?=
 =?utf-8?B?YjMzZi9sSHVwcCtRbmp6Nkc2ZERpWEZmVFdjTFJzSUplQXl4Y1oxMUR5M3J1?=
 =?utf-8?B?bHlYcGxMYmVBUjhtbVZvK1dRVWxJQisvbDU3ZlQyUUUyckMzeUdUWFV4eXlV?=
 =?utf-8?B?bzFzWXBkRFhHWmpiOWU4eUs1NmhsY3JENWJIM2RHWVhFQnVlRHJza1JYNngr?=
 =?utf-8?B?cFdTWFEyWkE3NG5nZkZiWFpOYXBpOVE3S2NocFl5emVvcGl4eVpJdWRkQ0tM?=
 =?utf-8?B?cnVqQzhTWXByNmg5aWQ4WG9uQTlHM2NqdFE1aXlaZ3ViSFZvMUFFVG5PYU96?=
 =?utf-8?B?Vi9YR3FvVEY4Q2hrK3hCZFd5NjBBNUVPQm9BVTBmVVJ3WUVlMmNlVDdJa0Jn?=
 =?utf-8?B?dU5BUW0vRkViL2lnRWZabXg1bkE5RnZxdnNRb29YMHY2eE5TZUNmQzZTR3RV?=
 =?utf-8?B?eFVYbUVFK2w2N3orZUFkRW5rUVBnNERwN0krVnE0a0VBbVhTTHFxL0pSTWpm?=
 =?utf-8?B?Y3IvZG1kb0Q4TmNoMG91UVFUNnk5eXlscjdobmJCYlBSd1dvQWFjbnIwRmJH?=
 =?utf-8?B?Yko1RUR2ZXJCaXg3REFRNDNxdjdTQUJFNGQ3VjNBa0RvQTlRSlNaakJYYnJq?=
 =?utf-8?B?TW82dGE0NFBDN3RJL1JCQXVqQSszZ0ZSQ21VU1RBVkZvMjZqbkJRckxFYjI3?=
 =?utf-8?B?M3MwU21qWHBwSlA2ZnZqNU9TUi9uNWNkMkxrY2xhdExDOEhOWXVZTlJub3ZT?=
 =?utf-8?B?SFFwejZVckl2N2xQR0ZNdTVsNitGUHZoTjNwNXpRb1EvT1FNZGI3QnJCekdv?=
 =?utf-8?B?NTRMQVU1aTZ0OEk4dURFMlJQL1Ivdno4ZUlrYklza01NTm9pSVpQK0w5VlF0?=
 =?utf-8?B?Qkw3Ry9TbzBhUmQzeFFrQjRBQjVaQzB4V3k4UUNtbUNHcThQdG9CeWRqckNE?=
 =?utf-8?B?QTViMjJDM3Jra0Q4UVYrdDRTOHNkOXk0M0x0bU9teCs3SmNBV1FXSTBSeHQ0?=
 =?utf-8?B?SFFuYWVXeTZjcExEd2FaN1VNeXBYMVNvTEJlWWRsRHlYSmxQVHVRdmdYa3Rt?=
 =?utf-8?B?UEk5angvVUR2TmhDN1Q4bmhMV0xreENiKzdyTEdjR2ZVUzZSSDA1TjZrWVJL?=
 =?utf-8?B?Zm01cXcvM090TzJFUGs3SzllTnBHcU1rWWppbVllRFczK0o0OCtqY1pWNlo3?=
 =?utf-8?B?K2lwR1dtQlhSWnZsTktCQVhHSU1YZEhlTXFjOE1OR2RCQ3R4ejhCYkNwUytF?=
 =?utf-8?B?MlFXb3o0RHFabXZmK0g4QVlycXErSnpiOTVDZjVRSnFocHRBV2syRFVubzl6?=
 =?utf-8?B?VTZrYThnRXpMMllSaTdsc2h5RE9XbG5KSTkyNCtaZ3ZSaEM3Sko2WDA5MHh5?=
 =?utf-8?B?a1RGZkgydnA3c0JjRVJUMFlISHl4dnFUWnJiNG96M3hLQVJLSU9kdnJWRXRw?=
 =?utf-8?B?TE1xSEd5UFRWa0U0eXVUU1R6T3VNbDhmM3VBVE96V1VvZlcweEhSQ2x0U016?=
 =?utf-8?B?ajVaMW5FMFNDQmRnQW43MGY2UlFFOTFCWEpsTjhEVzA4TzVrTHJKUVFjRW1F?=
 =?utf-8?B?OS9XS3RUUHg1QUw3R0pnNk43cG9xcWhpTThMaXFEOEJPei9wbHUxcDljTG5T?=
 =?utf-8?Q?qMECOjt6x95rhoUVbLLzDbTm0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75a5ca1d-040b-47b1-74cb-08dc75803356
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 08:14:25.9895
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kEc+Qs1FFJC243aVke/lJVQTun4SR5AaDT5WJ8BLoD312gPudKa0yUnlnJ7gj7K2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6919

Am 15.05.24 um 15:56 schrieb Maxime Ripard:
> The uAPI header has a bunch of constants and structures that might be
> handy in drivers.
>
> Let's include the header in the driver-side dma-heap header.

Well as long as this header doesn't need any symbols from the uAPI 
itself I think that is a no-go.

Includes should only be applied for things which are really necessary 
and not because some driver might need it.

Regards,
Christian.

>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
> ---
>   include/linux/dma-heap.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/dma-heap.h b/include/linux/dma-heap.h
> index 0c05561cad6e..e7cf110c5fdc 100644
> --- a/include/linux/dma-heap.h
> +++ b/include/linux/dma-heap.h
> @@ -10,10 +10,12 @@
>   #define _DMA_HEAPS_H
>   
>   #include <linux/cdev.h>
>   #include <linux/types.h>
>   
> +#include <uapi/linux/dma-heap.h>
> +
>   struct dma_heap;
>   
>   /**
>    * struct dma_heap_ops - ops to operate on a given heap
>    * @allocate:		allocate dmabuf and return struct dma_buf ptr
>