Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765544AbYAaQCs (ORCPT ); Thu, 31 Jan 2008 11:02:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756136AbYAaQCl (ORCPT ); Thu, 31 Jan 2008 11:02:41 -0500 Received: from www.tglx.de ([62.245.132.106]:34884 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753132AbYAaQCk (ORCPT ); Thu, 31 Jan 2008 11:02:40 -0500 Date: Thu, 31 Jan 2008 17:02:25 +0100 (CET) From: Thomas Gleixner To: Andi Kleen cc: mingo@elte.hu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [6/9] GBPAGES: Add gbpages support to lookup_address In-Reply-To: <20080129050634.B1B811B416E@basil.firstfloor.org> Message-ID: References: <20080129606.610336873@suse.de> <20080129050634.B1B811B416E@basil.firstfloor.org> User-Agent: Alpine 1.00 (LFD 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 940 Lines: 34 On Tue, 29 Jan 2008, Andi Kleen wrote: > > Signed-off-by: Andi Kleen > > --- > arch/x86/mm/pageattr.c | 5 +++++ > include/asm-x86/pgtable.h | 1 + > 2 files changed, 6 insertions(+) > > Index: linux/arch/x86/mm/pageattr.c > =================================================================== > --- linux.orig/arch/x86/mm/pageattr.c > +++ linux/arch/x86/mm/pageattr.c > @@ -152,9 +152,14 @@ pte_t *lookup_address(unsigned long addr > > if (pgd_none(*pgd)) > return NULL; > + > + *level = PG_LEVEL_1G; > pud = pud_offset(pgd, address); > if (pud_none(*pud)) > return NULL; Please move the level update here, so it is consistent with PMD. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/