Received-SPF: pass (google.com: domain of linux-kernel+bounces-180755-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <PUZPR01MB5120A03DFF0EA1CE70E7334E92ED2@PUZPR01MB5120.apcprd01.prod.exchangelabs.com>
 <a0ecb036-c760-447a-abfb-78fb7928fb9c@amd.com>
In-Reply-To: <a0ecb036-c760-447a-abfb-78fb7928fb9c@amd.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 16 May 2024 10:23:48 +0200
Message-ID: <CAJZ5v0gWDAws8vOvLXo4WEcz_jr38=87giN=RJSg=O1ec6F4rg@mail.gmail.com>
Subject: Re: [PATCH v4] cpufreq: amd-pstate: fix the memory to free after epp exist
To: "Limonciello, Mario" <mario.limonciello@amd.com>
Cc: zhida312@outlook.com, rafael@kernel.org, viresh.kumar@linaro.org, 
	Peng Ma <andypma@tencent.com>, Huang Rui <ray.huang@amd.com>, 
	"Gautham R. Shenoy" <gautham.shenoy@amd.com>, Perry Yuan <perry.yuan@amd.com>, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 16, 2024 at 9:47=E2=80=AFAM Limonciello, Mario
<mario.limonciello@amd.com> wrote:
>
>
>
> On 5/16/2024 1:30 AM, zhida312@outlook.com wrote:
> > From: andypma <andypma.tencent.com>
> >
> > the cpudata memory from kzmalloc in epp init function is
> > not free after epp exist, so we should free it.
> >
> > Signed-off-by: Peng Ma <andypma@tencent.com>
> >
> > Changes from v3 to v4:
> >       update subject used git command "git format-patch -1 -v x"
> >
> > Changes from v2 to v3:
> >       update Signed-off-by to Peng Ma <andypma@tencent.com>.
> >       set a space between if and "(".
> >
> > Changes from v1 to v2:
> >       check whether it is empty before releasing
> >       set driver_data is NULL after free
> > ---
>
> Thanks for your submission!
>
> I would prefer the change list below the cut list, but otherwise this is
> fine.  Maybe Rafael can modify that while committing.

I can do that no problem.

> Acked-by: Mario Limonciello <mario.limonciello@amd.com>

Thanks!

> >   drivers/cpufreq/amd-pstate.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.=
c
> > index 6a342b0c0140..1b7e82a0ad2e 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -1441,6 +1441,13 @@ static int amd_pstate_epp_cpu_init(struct cpufre=
q_policy *policy)
> >
> >   static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy)
> >   {
> > +     struct amd_cpudata *cpudata =3D policy->driver_data;
> > +
> > +     if (cpudata) {
> > +             kfree(cpudata);
> > +             policy->driver_data =3D NULL;
> > +     }
> > +
> >       pr_debug("CPU %d exiting\n", policy->cpu);
> >       return 0;
> >   }