Received-SPF: pass (google.com: domain of linux-kernel+bounces-180766-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Yuan, Perry" <Perry.Yuan@amd.com>
To: "zhida312@outlook.com" <zhida312@outlook.com>, "rafael@kernel.org"
	<rafael@kernel.org>, "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>
CC: Peng Ma <andypma@tencent.com>, "Huang, Ray" <Ray.Huang@amd.com>, "Shenoy,
 Gautham Ranjal" <gautham.shenoy@amd.com>, "Limonciello, Mario"
	<Mario.Limonciello@amd.com>, "linux-pm@vger.kernel.org"
	<linux-pm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4] cpufreq: amd-pstate: fix the memory to free after epp
 exist
Thread-Topic: [PATCH v4] cpufreq: amd-pstate: fix the memory to free after epp
 exist
Thread-Index: AQHap1qvGXuCaEUBIUasGUJvhQIt37GZhtuw
Date: Thu, 16 May 2024 08:28:06 +0000
Message-ID:
 <CYYPR12MB86551771F1670A5F9EAC47859CED2@CYYPR12MB8655.namprd12.prod.outlook.com>
References:
 <PUZPR01MB5120A03DFF0EA1CE70E7334E92ED2@PUZPR01MB5120.apcprd01.prod.exchangelabs.com>
In-Reply-To:
 <PUZPR01MB5120A03DFF0EA1CE70E7334E92ED2@PUZPR01MB5120.apcprd01.prod.exchangelabs.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels:
 MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=b373d80b-64e5-4a0a-8ea3-79a498f9ee7c;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD
 Internal Distribution
 Only;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-16T08:26:42Z;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: CYYPR12MB8655:EE_|SN7PR12MB7936:EE_
x-ms-office365-filtering-correlation-id: 9fb43a62-2411-4ffe-c968-08dc75821c9f
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;ARA:13230031|376005|1800799015|366007|38070700009;
x-microsoft-antispam-message-info:
 =?us-ascii?Q?YP6WZMw2XaSs3hdsukfYhYhwySpiJG1gboWSAbfyRJuXi/dDPXqnJZqxjNEp?=
 =?us-ascii?Q?bTby1oJ31PcWVEchNxdWJv8Rt2uePGQrGBt2MX2VaJN4FBe4AACSfYl9iUra?=
 =?us-ascii?Q?hfaW9wHwsk0WlA1IH2OD4b2ukeS/x0Bm9TLyaiX6idhFkmVjWZjNNCVvvcjv?=
 =?us-ascii?Q?syiB2I4gcSlxtyxVjSzCkM6CXslL+UL//APC24jmscpcPX+K8lE9HJR5S9Mm?=
 =?us-ascii?Q?zExrk4jGNIsC2wZPF+Jenm1P5pIJaGT6hTn4gWtgPCZhn59VjrlM3i4IlkUx?=
 =?us-ascii?Q?TrsnGDzj6BQhtDf7ka+BUzfwN52nKu0LHo7qcvr97zjzSpXT2YGMxwxmYaaK?=
 =?us-ascii?Q?TYOyMl0Vac5zcSej37oukC53mnwFk4OZJn7tQDhgjBubCG8MT5F/MIhr0B7B?=
 =?us-ascii?Q?XheRIpJ2tAtyg0OckDv6zHDF8VHoSov9OvN1imHKLMP9vF719RFUaa71xI7G?=
 =?us-ascii?Q?Gdj4wiyhVyKD+2aAA4KRBrBUCyNY766Q5N4iSMylJELyl0lWyxLlxMk+9fJu?=
 =?us-ascii?Q?8WdhgscObyJPgOXjXbnDCWz+ofP0fdTSiwTGhmbkjQtTTJnPmxsY+Mkt2bIx?=
 =?us-ascii?Q?2SNrjHfegNIgc/d8L1uRklul7fp8a0qj2i3KS/9RPFG09L/MqO0U/pR160PJ?=
 =?us-ascii?Q?asGxyeOiDgwrW4Z2hleWu50/TiZPSHU71SjC7NCsN/QiyVrjZYgUdoRYNLh/?=
 =?us-ascii?Q?d194I4D2nwPBslsrXb4GCiubLY+ZTuuRY7UKcsWG20CHdoxjeWQ093jauUlk?=
 =?us-ascii?Q?VMh3LjljUN3kQBhR315IkMX/L609aYvLTU7PvPiE8M5JyN4fbEbRW0YoM+1r?=
 =?us-ascii?Q?tzrAvpli5rcS7IfzmuY6vEFr0HnXp92igkJgNEAqSDcEDKGkuTJtD0uZY+ur?=
 =?us-ascii?Q?Eig9Kdn1tgBPh0JCdjuGMNoNjzfxoN6+TO24NrSQ9/pKyNUKHzR0dN2LznhG?=
 =?us-ascii?Q?g/I77+nZISTj4y8zAWZZROXAk3LBESpddboiiYprgSGugFXwq5PMtCi0GXd+?=
 =?us-ascii?Q?3Xs1bwPL75hYaJoEszgPWlvXWG1IaYHWSufD82ICWc++6M0Cz/TdLoEUQxbL?=
 =?us-ascii?Q?L4Kvrp8PMnN6I7EifU4IiUdcdyH9rf/sVSZrzEQB0f/WPmtEKHtfA/oHiB5L?=
 =?us-ascii?Q?rAcwr7/CfcEjRu5DmIfcnkBpqpgi8vI20WtnXhix4dJycEpztw+0EDLOUWSo?=
 =?us-ascii?Q?I0uElz0gIJD3gucgOE37a/uMPRWnmrPugN0+KbkHkf2CT+MtwK/ec4wFQH6T?=
 =?us-ascii?Q?xM9R1/W12RhDm4lPv3ONjU8x6Hz9aoOe0hgcUcLIY+gzGaYmZMh72dd8IDT9?=
 =?us-ascii?Q?4Hu8bkFbJnYlISB4g++Ke1el6PrYBB2GC2uPrHgsQvwkJg=3D=3D?=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CYYPR12MB8655.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007)(38070700009);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?bpi9rJwIYQxiE+fHvD5pX/ep4UGZGHi/SxsUu1VUuMi+gliOBC6Kw17GYaV7?=
 =?us-ascii?Q?GyDqS3EgKXGF0TUGKYrFQC9SBtQ/E1Hh+tPQP7Lw6WUW5Slf/rVx4FraEeNq?=
 =?us-ascii?Q?tLRQGCri/cbLdJcFcfKHBHV+XHN5aFijcgA/djRdgzEzxRiz8Rx/E0mVPZIK?=
 =?us-ascii?Q?0c07cmHju4RCCtPQ/LxVbVD0htqz4PIais2Ksy+wmbb82poUPKgzZdI59yz5?=
 =?us-ascii?Q?13p6N+MmoxmS14u/hzKR9egKninmhuyE2dEQBbs8gngJlrtGfjjnvAWulmsO?=
 =?us-ascii?Q?7R6wpUGm9F1cHIuJKWmF/zryewB5YNCBt/SOofsgmfg2hHUaUbLukVbViHS9?=
 =?us-ascii?Q?nsVAYxAIRDGRa03EBiYu9BrIlQa1FB4QP4XNfyoYs0grtpRSPd9AaA9xCsVx?=
 =?us-ascii?Q?rUq6MnKL6dCMCJMy5r0iwaT06uW5OW8+0299gyKWpUKAjqPeDjqwVghLD93V?=
 =?us-ascii?Q?wBKJ9KzPv3TB9uJKin+uuOBMbNDUqJopVtVKyg/VmbxTIiEsTajNBDJ6CAZf?=
 =?us-ascii?Q?seQ951a6Dt/DprBR4NaQARMwnL7XFO7jPBnfK1d5ihHxzRnuhRt76qpJd8XV?=
 =?us-ascii?Q?ViWl68xndGwj+HBHO4pcQo66SRZ2c53pjwgATwM8QZ3XrNUk0NiqRX/qfYtq?=
 =?us-ascii?Q?N1/75PRPoJZ7ZMa+/qbYKI9kbaRHqnTMX6mEg2YrWYML//azdhFywjJYEenc?=
 =?us-ascii?Q?SFHfNFU/frFLXEzmf8ljbpe7hZy0Oly6sc/KZbn07gGWiLseYbbGUjYa5+zC?=
 =?us-ascii?Q?TlFVqlA9apIQtcA6PzW7Helvu4jz3r58PvKqz2iYkFyp/RJ4HFk6a+m0P9mZ?=
 =?us-ascii?Q?1QU3PznZxPaZlsAcHGezAaXFL6ULt5KUeBVooENRCX0BEvG7yWN3sgdYvIiZ?=
 =?us-ascii?Q?SKBvFEGnnrqXJRQbsHzhh0M6cUqBGEz9Yy8w7xsQQGvDP8w68rZWAoVqHbwP?=
 =?us-ascii?Q?d4WUe16/zgH/4iVZrzjri9whUqcrAsp2lufhmJ3m35tm19oRZDakn/ZKS9pw?=
 =?us-ascii?Q?19ETFEBD9w1bfiORCzZdRbrOAwucx9NbO92HrsU5UoKVrHFoZJvmIaGFs6Rt?=
 =?us-ascii?Q?Y3yR7HDd5Xdoxm+8OVrGj+Nl3HFX3Lfkh9g1ri8NwS4vji2JeZZex74n3AKb?=
 =?us-ascii?Q?58CFuuGFLS2SX+hSHW8RXRhUTah31/MTdJVPwGdYt2fZRnG43QhRCx2NIETE?=
 =?us-ascii?Q?9TJNwjnuCGlRViaSODmto9bPRRfe31wam2fZwvUHU3ngbanuk4Az4SpgnAFm?=
 =?us-ascii?Q?uA6I7CbVXeWXuCz+VMJGR5xUUmrqDZEtch/18PXVrsCr6wZEAe9YlKnFAzHM?=
 =?us-ascii?Q?+pXfP8guhPI7CP4aqUOWW8aON3s2nBy72ycJZTyXyttpPkrvVE6KF+dFYG8H?=
 =?us-ascii?Q?LlfetgHWPW8f2HJ66HYPQ3BUPcEnJ7zenja/uustCTcjs1dgTJpUUo2zuJAn?=
 =?us-ascii?Q?8IyZBTf2oWkmgDs6tXjYzWj1Xr7mn/rfPQz/4zqA2wCJa4Xgz1wW7evb9Wzw?=
 =?us-ascii?Q?7NBG1lOIjqQ43b0v6tHich110wkgKCDYtwEGKW4YMrzXxktzB2e6nIOL8olI?=
 =?us-ascii?Q?WoJ7oJGq+uAEqeGxjd4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CYYPR12MB8655.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fb43a62-2411-4ffe-c968-08dc75821c9f
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2024 08:28:06.5752
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6JYgam9pVE2UzAHIO6+sMioI+b/bnNyRTjHmNbYs3pscZu6Rpq09507qY+uebY/B/X8DyJicvMoLkjzbqc8pLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7936

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: zhida312@outlook.com <zhida312@outlook.com>
> Sent: Thursday, May 16, 2024 2:31 PM
> To: rafael@kernel.org; viresh.kumar@linaro.org
> Cc: Peng Ma <andypma@tencent.com>; Huang, Ray <Ray.Huang@amd.com>;
> Shenoy, Gautham Ranjal <gautham.shenoy@amd.com>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; Yuan, Perry <Perry.Yuan@amd.com>; linux-
> pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH v4] cpufreq: amd-pstate: fix the memory to free after epp
> exist
>
> From: andypma <andypma.tencent.com>
>
> the cpudata memory from kzmalloc in epp init function is not free after e=
pp
> exist, so we should free it.
>
> Signed-off-by: Peng Ma <andypma@tencent.com>
>
> Changes from v3 to v4:
>       update subject used git command "git format-patch -1 -v x"
>
> Changes from v2 to v3:
>       update Signed-off-by to Peng Ma <andypma@tencent.com>.
>       set a space between if and "(".
>
> Changes from v1 to v2:
>       check whether it is empty before releasing
>       set driver_data is NULL after free
> ---
>  drivers/cpufreq/amd-pstate.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 6a342b0c0140..1b7e82a0ad2e 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1441,6 +1441,13 @@ static int amd_pstate_epp_cpu_init(struct
> cpufreq_policy *policy)
>
>  static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy)  {
> +     struct amd_cpudata *cpudata =3D policy->driver_data;
> +
> +     if (cpudata) {
> +             kfree(cpudata);
> +             policy->driver_data =3D NULL;
> +     }
> +
>       pr_debug("CPU %d exiting\n", policy->cpu);
>       return 0;
>  }
> --
> 2.41.0

Looks good now

Reviewed-by: Perry Yuan <Perry.Yuan@amd.com>

Thanks

Regards.
Perry