Received-SPF: pass (google.com: domain of linux-kernel+bounces-180771-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 16 May 2024 10:32:14 +0200
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Richard Weinberger <richard@nod.at>, Vignesh Raghavendra
 <vigneshr@ti.com>, linux-mtd@lists.infradead.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] mtd: nand: mxc_nand: implement exec_op
Message-ID: <20240516103214.57a8ce33@xps-13>
In-Reply-To: <20240514-mtd-nand-mxc-nand-exec-op-v3-2-3e6f45fd3d82@pengutronix.de>
References: <20240514-mtd-nand-mxc-nand-exec-op-v3-0-3e6f45fd3d82@pengutronix.de>
	<20240514-mtd-nand-mxc-nand-exec-op-v3-2-3e6f45fd3d82@pengutronix.de>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Sascha,

> +static const struct nand_op_parser mxcnd_op_parser =3D NAND_OP_PARSER(
> +	NAND_OP_PARSER_PATTERN(mxcnd_do_exec_op,
> +			       NAND_OP_PARSER_PAT_CMD_ELEM(false),
> +			       NAND_OP_PARSER_PAT_ADDR_ELEM(true, 7),
> +			       NAND_OP_PARSER_PAT_CMD_ELEM(true),
> +			       NAND_OP_PARSER_PAT_WAITRDY_ELEM(true),
> +			       NAND_OP_PARSER_PAT_DATA_IN_ELEM(true, MAX_DATA_SIZE)),

CMD, ADDR, CMD, DATA is the RNDOUT pattern. So it is now working fine?
Or did you forget to adapt the patterns to your use case?


Thanks,
Miqu=C3=A8l