Received-SPF: pass (google.com: domain of linux-kernel+bounces-180787-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <PUZPR01MB5120A03DFF0EA1CE70E7334E92ED2@PUZPR01MB5120.apcprd01.prod.exchangelabs.com>
 <CYYPR12MB86551771F1670A5F9EAC47859CED2@CYYPR12MB8655.namprd12.prod.outlook.com>
In-Reply-To: <CYYPR12MB86551771F1670A5F9EAC47859CED2@CYYPR12MB8655.namprd12.prod.outlook.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 16 May 2024 10:42:17 +0200
Message-ID: <CAJZ5v0gqTnj4Dk844gMMG+rnBvbpA_dGErghTM1PokaDScdBSQ@mail.gmail.com>
Subject: Re: [PATCH v4] cpufreq: amd-pstate: fix the memory to free after epp exist
To: "Yuan, Perry" <Perry.Yuan@amd.com>, "zhida312@outlook.com" <zhida312@outlook.com>
Cc: "rafael@kernel.org" <rafael@kernel.org>, "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>, 
	Peng Ma <andypma@tencent.com>, "Huang, Ray" <Ray.Huang@amd.com>, 
	"Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>, "Limonciello, Mario" <Mario.Limonciello@amd.com>, 
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, 
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 16, 2024 at 10:28=E2=80=AFAM Yuan, Perry <Perry.Yuan@amd.com> w=
rote:
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> > -----Original Message-----
> > From: zhida312@outlook.com <zhida312@outlook.com>
> > Sent: Thursday, May 16, 2024 2:31 PM
> > To: rafael@kernel.org; viresh.kumar@linaro.org
> > Cc: Peng Ma <andypma@tencent.com>; Huang, Ray <Ray.Huang@amd.com>;
> > Shenoy, Gautham Ranjal <gautham.shenoy@amd.com>; Limonciello, Mario
> > <Mario.Limonciello@amd.com>; Yuan, Perry <Perry.Yuan@amd.com>; linux-
> > pm@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: [PATCH v4] cpufreq: amd-pstate: fix the memory to free after e=
pp
> > exist
> >
> > From: andypma <andypma.tencent.com>

The name and e-mail address in the From: header must be the same as in
the Signed-off-by tag, so I've fixed that up.

> > the cpudata memory from kzmalloc in epp init function is not free after=
 epp
> > exist, so we should free it.
> >
> > Signed-off-by: Peng Ma <andypma@tencent.com>
> >
> > Changes from v3 to v4:
> >       update subject used git command "git format-patch -1 -v x"
> >
> > Changes from v2 to v3:
> >       update Signed-off-by to Peng Ma <andypma@tencent.com>.
> >       set a space between if and "(".
> >
> > Changes from v1 to v2:
> >       check whether it is empty before releasing
> >       set driver_data is NULL after free
> > ---
> >  drivers/cpufreq/amd-pstate.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.=
c
> > index 6a342b0c0140..1b7e82a0ad2e 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -1441,6 +1441,13 @@ static int amd_pstate_epp_cpu_init(struct
> > cpufreq_policy *policy)
> >
> >  static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy)  {
> > +     struct amd_cpudata *cpudata =3D policy->driver_data;
> > +
> > +     if (cpudata) {
> > +             kfree(cpudata);
> > +             policy->driver_data =3D NULL;
> > +     }

This does not need to be conditional, because you can pass NULL to
kfree(), but it is correct and since Mario has ACKed it ->

> > +
> >       pr_debug("CPU %d exiting\n", policy->cpu);
> >       return 0;
> >  }
> > --
> > 2.41.0
>
> Looks good now
>
> Reviewed-by: Perry Yuan <Perry.Yuan@amd.com>

-> applied as 6.10 material (with edited subject and changelog).

Thanks!