Received-SPF: pass (google.com: domain of linux-kernel+bounces-180802-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 16 May 2024 11:55:37 +0300
From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
	Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] regulator: rohm-regulator: warn if unsupported voltage
 is set
Message-ID: <0937411855967cbefd9ff2d6045a52ca26712c4a.1715848512.git.mazziesaccount@gmail.com>
References: <cover.1715848512.git.mazziesaccount@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="feluPDTPybhE8DMK"
Content-Disposition: inline
In-Reply-To: <cover.1715848512.git.mazziesaccount@gmail.com>


--feluPDTPybhE8DMK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

A few of the ROHM PMICs allow setting low-power state specific voltages
for regulators. These voltages are then taken in use (by the hardware)
when the PMIC state is changed.

The voltages for these states can be given via device-tree. If
unsupported voltage has been given, the users have only seen print:
"driver callback failed to parse DT for regulator <name>". This does
help to pinpoint the problem to some extent, but there may be several
properties in device-tree so it should help if we can be a bit more
specific.

Print the voltage value and the run-state property if voltage can not be
supported.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
---
 drivers/regulator/rohm-regulator.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/regulator/rohm-regulator.c b/drivers/regulator/rohm-re=
gulator.c
index 0e2418ed957c..4b95ca01959c 100644
--- a/drivers/regulator/rohm-regulator.c
+++ b/drivers/regulator/rohm-regulator.c
@@ -46,6 +46,7 @@ static int set_dvs_level(const struct regulator_desc *des=
c,
 			continue;
 		if (ret =3D=3D uv) {
 			i <<=3D ffs(desc->vsel_mask) - 1;
+
 			ret =3D regmap_update_bits(regmap, reg, mask, i);
 			if (omask && !ret)
 				ret =3D regmap_update_bits(regmap, oreg, omask,
@@ -53,6 +54,9 @@ static int set_dvs_level(const struct regulator_desc *des=
c,
 			break;
 		}
 	}
+	if (i =3D=3D desc->n_voltages)
+		pr_warn("Unsupported %s voltage %u\n", prop, uv);
+
 	return ret;
 }
=20
--=20
2.44.0


--=20
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =3D]=20

--feluPDTPybhE8DMK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmZFygkACgkQeFA3/03a
ocXm8QgAye7nLPVpI2v476i5jFtamsFRBEGpB46uHujOWQ53QkPi+MbyRIwKetaA
t4L1MUSRAfiD1l1/3KJ6P1fEDHBzZA+F8QVdCObeP/WK0rtOFf6yno/7a0dYzdDd
HchK982+S3rka6VWEUaOyn+jin9ITX8B8JacmgiGyXKXYaYwxSUOyi5HXtaxBWNP
8WGsMscrE95JvOMV69NwtktBgLpUoOzu8/wo3BoupYy/Qan/JwAT5VzctfX0h5yP
MWZNDlebKbOrq2xUbLhfQqu3SKdpbaPiSsWV11zcj2pTa8HCBfbt/GqFuoS8c9fC
s6q5S+RrVr4YI1T4D0At0xiJMZihdA==
=IgwW
-----END PGP SIGNATURE-----

--feluPDTPybhE8DMK--