Received-SPF: pass (google.com: domain of linux-kernel+bounces-180807-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <69f12f34-bedb-4d1a-b359-7488530ab4e4@intel.com>
Date: Thu, 16 May 2024 10:58:37 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net] net: Always descend into dsa/ folder
To: Florian Fainelli <florian.fainelli@broadcom.com>
CC: <netdev@vger.kernel.org>, <masahiroy@kernel.org>, Stephen Langstaff
	<stephenlangstaff1@gmail.com>, "David S. Miller" <davem@davemloft.net>, "Eric
 Dumazet" <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Alexander Lobakin <alobakin@pm.me>, Florian Fainelli
	<f.fainelli@gmail.com>, Vladimir Oltean <olteanv@gmail.com>, open list
	<linux-kernel@vger.kernel.org>
References: <20240516033345.1813070-1-florian.fainelli@broadcom.com>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <20240516033345.1813070-1-florian.fainelli@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkgwbXIwaEdrU3lNamhkaHpKZ2k5YlAwb01MWTFBemI3TWI1NzJvMjd2SlBR?=
 =?utf-8?B?dmFGWlZKMEpaanZjMndKMnlHb1VYWVFjaHZnc2xmRktEck9SV1FSVEZGYnpH?=
 =?utf-8?B?ZTJ2RUdPaStTZHpEK1FBVk1Kc2E1NzlaZG42Q1pEamVBdlBiVmM2bjkvVHZ5?=
 =?utf-8?B?VVA5dWlpM1F0VzdsM28zd0NISjZPK1lhcFUxbUpNSjF1dEo1bGlBNU9yMFAr?=
 =?utf-8?B?SzM2M1NDTVVXU0RVMy9xSXJIQlJ5ejg4MzhOaElxeXBiNlVUelJnTHlLR0RU?=
 =?utf-8?B?YWNMTU9paXI1bnF5WnhqN2FIeGpOU2NodjdVdUExblZiZUMvWEkrdnZHTHA2?=
 =?utf-8?B?aHpyOWVDWHQxdko2eHJ6VUdqemdoQVd4SkoyazNHU3NzaXdoTU9CMzN6aS8r?=
 =?utf-8?B?SFJEak5vR05BMmFpKzJhby9UaXNlSCtTKzRQNDhQRDFPSkVMVVBPREI5OEZG?=
 =?utf-8?B?WmlydDA5OXEzcnEyYzVTM0RmV2FMRTZqb2dpUTVBWEFoMXRoU0VURGFSQk5a?=
 =?utf-8?B?eEpMR2ZpaXNMV2kyZVdNSFhhckxSY2xHY3d0dXVxa3ZuT2kwb0VIUlB0YXg3?=
 =?utf-8?B?OWpCN0RFVTF4MWU5VjNYRU9MMWFpamtXSEpBaHVpdC9FczkrZllnLzRhRkw5?=
 =?utf-8?B?Smh0ZThJRERlZmlWNWpoNVRyVlhyMU5YTEJDRDlPRGlDdFJscTZNc2c1NjJC?=
 =?utf-8?B?cVkwdWRXWVBucDdiUDhXMjhJQXp4NmlEbnJGYTRxN3VoWVUwZE1PRDNBRW5J?=
 =?utf-8?B?b2lCNWh0bDIwWUlGYjNLVDlWeHAvVXpmUDdkUHNlTSswRVl1TXVid2h1eVFI?=
 =?utf-8?B?Mm9tY3V2ajE5c3oydUdqL2RHcGlHT0k5bkFsL0l1QnVhT1VTMm5XTWdtbkpo?=
 =?utf-8?B?SENQM1gxSkhicUI3eEZDT2k4SkkwYkM3OHdBNGFuK2M5TEFIb1YvK0svSmJs?=
 =?utf-8?B?Qk5WMDIvZ0dpdmlFaUJzNlRpVWxuUldML0I3THMvZEU2ZkNXeTNRSXppVEIy?=
 =?utf-8?B?V2FKV2pFVXB3SS9UbVZmY0FwazQyVzVacmRYZjRueEp4dERZQ3ZmZllyYWxj?=
 =?utf-8?B?MWlGSzF3QTFKMHBMNjRUMDNzbHFPYldNVy92YkxuaW5FQWJNWXBDKzdZRlQr?=
 =?utf-8?B?Y3I5cGIvMUxqeVo0QXZvSHZkOVBFaEpzMFRSRU5JeS91WHB2VmtIazRRYVBI?=
 =?utf-8?B?NnZ3MTBGUlZ4M2JiSW9jT3lBWllYZE1xb3lBZ0F6VkI2UjNTZVZnQ2diR3hk?=
 =?utf-8?B?SDBOcm5xNlpHNkY5Z1ZvSVFPLzdCZUdGVWZOQStwQnJydnFFbmx3T3RRYzVm?=
 =?utf-8?B?MU5xSjg3ZU5YTldzU1FLdDRqOE03T1NVWDl1Wm5mVUU0a2VmbXJFUi9lWXZX?=
 =?utf-8?B?NGg4Q0NiaThDajNQYzBsSFVqYVFMNmNKQVBBeW5MZ1JoT0g0M2JHSHdrZWhT?=
 =?utf-8?B?cGNJNWxnRjUxelZVTnJ0dUVLeWJwWjYyTHVkMDFtQVE1Z2h2N05GaG9SdW44?=
 =?utf-8?B?T2ttZWlYS213YkxyeE9IalAzaTF3QmxyQ1NvRVlNTzhKWmFHYk9BY3RDUGY0?=
 =?utf-8?B?aWdrZjd4blFibnRJQXU2TDVkSEZtS3dMT2hMQUJydjBSOGJUays5K011ckRM?=
 =?utf-8?B?MlJEdVo1UUVWSDZQSEF0TnR1WDdMMXRZTDMxekMxWTlqQ1lEbzY4cGVYWkxs?=
 =?utf-8?B?eGlwbTBLSm5oc1ZpMXJ6QTlCb0dCNG5JdjBBUFdaSC90ekZyQWFEZU9va0h1?=
 =?utf-8?B?eVlOYTRGMG03NXNhVjkyUEgzSnUydDBwTVBpd2J4UWNSWHhyQm9rc3hDRnll?=
 =?utf-8?B?OEtEMmJXVHdkMXFnNk9HNTdaUTdIbDgrMUE2YnpQQ2tmSXduZjFTWHE2aERC?=
 =?utf-8?B?OWU0T1dlbXlEOVR3cG01UFdvVXZaWllFK0xSWkdFVmF1Ui8xRkpKRmtjQ3ZZ?=
 =?utf-8?B?eDk2WEZvb2t5UENEaXNmYVNjQUtpMndhSlYzVHVLdThNMG1EbEY1ckplZzZk?=
 =?utf-8?B?ZHVFNzhzbCt4MzB5TG5wRjRKa2RkdGgrVkRITWZpUnowSFljd3JrRG1iUHJM?=
 =?utf-8?B?NEgrc3Bpc2tYdmN1bndOVWZwMk92NWh5YWlGUnV4VzBZWHk4WmQwTkVoYzR0?=
 =?utf-8?B?bkJuZkpBOE1qVE5NUGJQUXNPT0wxeUo3U1R4VE1heEkzbUllQ0V2WUYxbDJN?=
 =?utf-8?B?Qmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a939f3b-7874-49ce-1ace-08dc7586946e
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 09:00:05.8209
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n/W3SAlpJMpAI16V+V9jR3clMwLNnzev+VVUwMPseNwtQlPpiKDd2kR57+EF9FfQpo4gcwJ1ifsJw6L3dIkMWRkdurRLVTq18BjXWZPvyqc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7817
X-OriginatorOrg: intel.com

From: Florian Fainelli <florian.fainelli@broadcom.com>
Date: Wed, 15 May 2024 20:33:45 -0700

> Stephen reported that he was unable to get the dsa_loop driver to get
> probed, and the reason ended up being because he had CONFIG_FIXED_PHY=y
> in his kernel configuration. As Masahiro explained it:
> 
>   "obj-m += dsa/" means everything under dsa/ must be modular.
> 
>   If there is a built-in object under dsa/ with CONFIG_NET_DSA=m,
>   you cannot do  "obj-$(CONFIG_NET_DSA) += dsa/".
> 
>   You need to change it back to "obj-y += dsa/".
> 
> This was the case here whereby CONFIG_NET_DSA=m, and so the
> obj-$(CONFIG_FIXED_PHY) += dsa_loop_bdinfo.o rule is not executed and
> the DSA loop mdio_board info structure is not registered with the
> kernel, and eventually the device is simply not found.
> 
> Fixes: 227d72063fcc ("dsa: simplify Kconfig symbols and dependencies")
> Reported-by: Stephen Langstaff <stephenlangstaff1@gmail.com>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
>  drivers/net/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
> index 9c053673d6b2..0f6f0f091e0e 100644
> --- a/drivers/net/Makefile
> +++ b/drivers/net/Makefile
> @@ -49,7 +49,7 @@ obj-$(CONFIG_MHI_NET) += mhi_net.o
>  obj-$(CONFIG_ARCNET) += arcnet/
>  obj-$(CONFIG_CAIF) += caif/
>  obj-$(CONFIG_CAN) += can/
> -obj-$(CONFIG_NET_DSA) += dsa/
> +obj-y += dsa/

obj-$(CONFIG_NET_DSA:m=y) += dsa/

?

or

ifdef CONFIG_NET_DSA
obj-y += dsa/
endif

I don't like always adding folders even if nothing will be built there
as we then have a lot of folders with just empty built-in.a.

>  obj-$(CONFIG_ETHERNET) += ethernet/
>  obj-$(CONFIG_FDDI) += fddi/
>  obj-$(CONFIG_HIPPI) += hippi/

Thanks,
Olek