Received-SPF: pass (google.com: domain of linux-kernel+bounces-180814-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 16 May 2024 11:07:04 +0200
From: Oscar Salvador <osalvador@suse.de>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: David Hildenbrand <david@redhat.com>, akpm@linux-foundation.org,
	shy828301@gmail.com, nao.horiguchi@gmail.com,
	xuyu@linux.alibaba.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/huge_memory: don't unpoison huge_zero_folio
Message-ID: <ZkXMuHcWPBXy9sT3@localhost.localdomain>
References: <20240515023607.870022-1-linmiaohe@huawei.com>
 <e1c93779-8cde-4986-85d3-2134fb8970b3@redhat.com>
 <ZkXDS9y_cBSzBzeN@localhost.localdomain>
 <fd1b4d3f-be4c-16e2-00d9-8ea6443c68f3@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fd1b4d3f-be4c-16e2-00d9-8ea6443c68f3@huawei.com>

On Thu, May 16, 2024 at 04:45:22PM +0800, Miaohe Lin wrote:
> Thanks for your comment. Do you mean something like below?
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 16ada4fb02b7..a9fe9eda593f 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -2546,6 +2546,13 @@ int unpoison_memory(unsigned long pfn)
>                 goto unlock_mutex;
>         }
> 
> +       if (is_huge_zero_folio(folio)) {
> +               unpoison_pr_info("Unpoison: huge zero page is not supported %#lx\n",
> +                                pfn, &unpoison_rs);
> +               ret = -EOPNOTSUPP;
> +               goto unlock_mutex;
> +       }
> +
>         if (!PageHWPoison(p)) {
>                 unpoison_pr_info("Unpoison: Page was already unpoisoned %#lx\n",
>                                  pfn, &unpoison_rs);

Yes, something like that makes much more sense to me.


Thanks

-- 
Oscar Salvador
SUSE Labs