Received-SPF: pass (google.com: domain of linux-kernel+bounces-180816-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <6bbc4606-67f4-4689-bd85-7de6b6f99a62@amd.com>
Date: Thu, 16 May 2024 14:39:19 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATH net-next 1/2] dt-bindings: net: xilinx_gmii2rgmii: Add
 clock support
Content-Language: en-GB
To: Krzysztof Kozlowski <krzk@kernel.org>, git@amd.com, davem@davemloft.net,
 edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
 krzk+dt@kernel.org, conor+dt@kernel.org, harini.katakam@amd.com,
 andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
 michal.simek@amd.com
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <20240515094645.3691877-1-vineeth.karumanchi@amd.com>
 <20240515094645.3691877-2-vineeth.karumanchi@amd.com>
 <4ae4d926-73f0-4f30-9d83-908a92046829@kernel.org>
From: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
In-Reply-To: <4ae4d926-73f0-4f30-9d83-908a92046829@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UzVlQnhyckdZR21ZUm9kSlIxa3hzT3FqeENBNE5nWk81YnYzam1CcTNVNndS?=
 =?utf-8?B?UFBaWWJrZE9pTmJVU3h6aW5TYjd6VUZwTG5pdVZtOXJwMW5GNjJNZVQwTm4v?=
 =?utf-8?B?WFl0MkpLT25xMkJ0ZDI2a1ZNcitYeFlWMTlIRHlXM01NSjAxYXZQbDlscTIx?=
 =?utf-8?B?MkNPRnNwZnpEdDRSVDA0enc3Wm9BZVNOelh2RXVHdUhLelI5ZjJ1YWlxRldF?=
 =?utf-8?B?NitYcVNycGRqSlZRY1FpSTNCT08xK0JWaWhTOTVmNWQ2eGtLR2MwdlNodUx3?=
 =?utf-8?B?bmFNUFZFbUdkNERyby9ZZ1B4YWNCY1c5Q1JDR1RpL0d2bm9XVXU5VUVSZWpF?=
 =?utf-8?B?Z1FmSjh2RzQvRjBrZDBwalYxdEZoeWQ2T3k2RFJBc3hvSUV4ZmpGdXRJUG9P?=
 =?utf-8?B?bWo4WUNqbnJ2K1FUU3hWZU9BNXFhMmVmN2JWei93ejBadHNkSGtjaHcyTzhO?=
 =?utf-8?B?V3R4Q0tHUkVZdW9wZ0h3aDA5Z3QvM2gzbFprOUR0Qm5mV1F5SEFtYk9CZFVq?=
 =?utf-8?B?YzEwMkpRQ3BzMlpvSkgxMFZQNklPT28xaVFQd2FJeDRQZEIxbnkyeStIK3Vh?=
 =?utf-8?B?cVFZSDVuVUFlaGdMYTFEbTFEaU13d09wWGVBSzAwRS8zVW90SEJaN2F1Smg3?=
 =?utf-8?B?V3B0alhmVGR3R016dVM5WGd3bWJDTCtCeGZOTVdwM3czQkRuRk5FaWd5ejln?=
 =?utf-8?B?NHI2MlUzZDFKYkMyMitWSlIxNGFzWWlXclcxNXoycHR0dDVWd25GbWl4ZXZa?=
 =?utf-8?B?MHhTTFQ5Tkg1OS9QdzVHczgwbkZqdmowSGxwWGZhQ0NXZzdGdFhkaktGWVFO?=
 =?utf-8?B?QXBPMUV1RWVLK1l0Um9wQkRTV00reVIyUFgzUTZJeWpEdjN4VklNSlBaSkNX?=
 =?utf-8?B?WHNrcm0weTlMNjk5blZOTHkzRE1TYzJ2Y2V4ZWphdDhCdkt4QkFMZURIcVRF?=
 =?utf-8?B?SHhzV2xZY3BBbGRMR3VLNDN0VjE5K1FGZzFkQjlmdzBwRVlDNmlkRXp0U3dt?=
 =?utf-8?B?SXRGNDNYd21IYnkrdUZLMlgybEdVU3luTWhHNEtoeXp4NjZ2cVlvUmtMclg5?=
 =?utf-8?B?MzNjMFRMbUVHTkNQVXNnWmV0SFlTVjV6WVYwOG5MWnhkMkUza3hnaVlYRmQr?=
 =?utf-8?B?TGEwTUYyQzZKNk91ek1zL2tsdmttSzlqVzNoL3ZxbjBrK1Z3cnFaZVppT2g0?=
 =?utf-8?B?V3Z0WlZQYU9DMll0REk5Uy9ZUStrb0VCai80Zy9ma3pJRklGTEdJbjZzK1li?=
 =?utf-8?B?MEgrSDIrcitxeUdoNUtpWmtiU25NZzJXZHpHMTgvMVh1eHpqdkxGVFc0TkpO?=
 =?utf-8?B?NlFlcTMyT3hsNVQxYnkwckRId204RWZFZW1yWmwrQUFka3laZkJaNE12L05p?=
 =?utf-8?B?RFM2Y2RQenpOQlZKVW4rSmRFcWNZVzZXMHFoekZ1dXBJNlZuNGI3VURkS0V3?=
 =?utf-8?B?TjlWZkx1b1hIbVErQU52L0NGWWE4a1pxczFGTktVM3phRFlyQmpJTzRvRGY5?=
 =?utf-8?B?NnVRanB6ZE8rSUM1MDhrNjdsRVN1bzFmTEE3eTFxVzM3UVdoajA3MU9ESG50?=
 =?utf-8?B?bkkwcnVNNmw0MmpwSzFlL01zNFRhMjIzTWV0d0JRcDI4ZHdjbnE3ZS9USkhG?=
 =?utf-8?B?bTY3QklUcHVsQjZOaVdCUFVVNFVYd0MxVWg0bXMrSWgvTzJOc3pCV2ZyUzhh?=
 =?utf-8?B?RXJIaEttVGZFV2t3ZENYNGpVYXhKQ1lHcnJRbE9sWVlUZzBMWW8rUE9GUGI0?=
 =?utf-8?B?NHpzWFRYNkJmbmk4SWhyRmd6WGEvbXgxS29ZbklQNEhHS1ZLVmo0V1VvUEdI?=
 =?utf-8?B?RXRFUkxya09TcVFNNjVaQUNKd21NcHB2aU5Xc25BbUZQck5WalJYQzQwMFd6?=
 =?utf-8?B?N1orNCsvZ3JuR3VKcmYrYkpLbC9MUlM2Q1JYais4VnlOVGxuT0Z4eEo5YzBt?=
 =?utf-8?B?dmEyMDVYNEZVaFhRUFNjQXBsNE9wVkJqSm42eVpjbThLVXRxNml1cmFmRjlt?=
 =?utf-8?B?eTkvMWwzRWpWUXRwdjN2ay9Yb2FVdXlwbWtzQnJqQldlMUlnQ3dqR2o1cU5N?=
 =?utf-8?B?YjRtTDNvWWdNUGpkQkdFQTZrU0NzRHdaVWo3NVFEdENLT1N2RTloSSsxUTlm?=
 =?utf-8?Q?q0oWLHC7wLksfgRXUkwimsKu8?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f1cfea4-b36b-4724-ffd6-08dc7587e4a9
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5946.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 09:09:29.9994
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tHZUbI+fR3c4aqd6xAMGHtXANNvd9uM7lmTxS+PN2FFM0i1g/JsdbdO/nQp8CfTm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4334

Hi Krzysztof,

On 15/05/24 7:37 pm, Krzysztof Kozlowski wrote:
> On 15/05/2024 11:46, Vineeth Karumanchi wrote:
>> Add input clock support to gmii_to_rgmii IP.
> 
> Why? Wasn't it there before?

Earlier we used to enable all PL clocks (fixed), now we want to enable 
only the needed clocks.

> 
>> Add "clocks" and "clock_names" bindings, "clkin" is the input clock name.
> 
> Please use standard email subjects, so with the PATCH keyword in the
> title. `git format-patch` helps here to create proper versioned patches.
> Another useful tool is b4. Skipping the PATCH keyword makes filtering of
> emails more difficult thus making the review process less convenient.
> 
> Don't write it by yourself....
> 
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 

sorry mybad, I used 'git format-patch', but typo!.
Will take care from next time.

>>
>> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
>> ---
>>   .../devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml      | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
>> index 0f781dac6717..d84d13fb2c54 100644
>> --- a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
>> +++ b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
>> @@ -31,6 +31,13 @@ properties:
>>     phy-handle:
>>       $ref: ethernet-controller.yaml#/properties/phy-handle
>>   
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  clock-names:
>> +    const: clkin
>> +    description: 200/375 MHz free-running clock is used as a input clock.
> 
> Nope, just write the description as items in clocks, instead of
> maxItems. And drop clock-names, not needed and kind of obvious.
> 

OK.

???? vineeth

> 
> Best regards,
> Krzysztof
>