Received-SPF: pass (google.com: domain of linux-kernel+bounces-180837-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <212a9464-d52b-4730-95b9-5a0aebd38c91@gmail.com>
 <CAHx5RXCWW5M-eW5v65bAkQWZemsU2NTvDv3jA9_XKz=+YP56Qg@mail.gmail.com>
 <688e54ec-3b29-4e3b-a2c3-f2c83b9c97b7@lunn.ch> <CAHx5RXBFdzsgKXR94gdZd2b=uz8PJDg4OjLPJxKtsdhcjJq3Qw@mail.gmail.com>
 <e307a237-68e3-40c9-be31-4fe3d560ada2@lunn.ch> <CAHx5RXCF0=Soz_k88RGvJFGrajaxn=mVnqpb99GAQ=b7XOcWiw@mail.gmail.com>
 <732d8bb2-1d4f-4958-b130-0bd15a407271@gmail.com> <CAHx5RXDaweFTF_Qt0GdBH4nBeMqwL4VVto7xzHBvFgFL5n=Ebg@mail.gmail.com>
 <c8c01e53-0a45-4319-88ff-bfb0caba150c@lunn.ch> <CAHx5RXDzN93WaYFe2bk6m2TmMC+A9vsmhodRFmZi17cFY5CrWQ@mail.gmail.com>
 <949fcbea-23dc-44c1-9146-c358b15b9253@lunn.ch> <CAHx5RXC44V-qsN9QiuhKrDdGZ4ppXpT_cQz3XNAa2aQnf7Pe5Q@mail.gmail.com>
 <cb0f929b-75aa-4ff6-98dc-217b34421e5a@gmail.com>
In-Reply-To: <cb0f929b-75aa-4ff6-98dc-217b34421e5a@gmail.com>
From: Stephen Langstaff <stephenlangstaff1@gmail.com>
Date: Thu, 16 May 2024 10:27:49 +0100
Message-ID: <CAHx5RXCaiHav5fbUwYe40_7XJbNSrTDO90fUD8ZMAryUovH0gA@mail.gmail.com>
Subject: Re: drivers/net/dsa/dsa_loop_bdinfo.c build problems
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, linux-kernel@vger.kernel.org, OlteanV@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 15, 2024 at 8:27=E2=80=AFPM Florian Fainelli <f.fainelli@gmail.=
com> wrote:
> What changes have you done to the dsa_loop.c file for this error to show
> up? Currently the driver does the following:
>
> static void dsa_loop_phylink_get_caps(struct dsa_switch *dsa, int port,
>                                          struct phylink_config *config)
>    {
>            bitmap_fill(config->supported_interfaces,
> PHY_INTERFACE_MODE_MAX);
>            __clear_bit(PHY_INTERFACE_MODE_NA, config->supported_interface=
s);
>            config->mac_capabilities =3D ~0;
>    }
>
> which is basically to say: I support everything, except
> PHY_INTERFACE_MDOE_NA.

I am currently on kernel version 6.1.55 which does not appear to have
this caps code in, and neither does 6.1.90.

The following commit to net/dsa/port.c, backported to the 6.1 tree,
appears to fix the issue
https://github.com/torvalds/linux/commit/9945c1fb03a3c9f7e0dcf9aa17041a70e5=
51387a

Steve.