Received-SPF: pass (google.com: domain of linux-kernel+bounces-180871-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Hariprasad Kelam <hkelam@marvell.com>
To: Chen Ni <nichen@iscas.ac.cn>, "nbd@nbd.name" <nbd@nbd.name>,
        "sean.wang@mediatek.com" <sean.wang@mediatek.com>,
        "Mark-MC.Lee@mediatek.com"
	<Mark-MC.Lee@mediatek.com>,
        "lorenzo@kernel.org" <lorenzo@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "matthias.bgg@gmail.com"
	<matthias.bgg@gmail.com>,
        "angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
        "linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>
Subject: ] [PATCH net-next] net: ethernet: mtk_eth_soc: add missing check for
 rhashtable_init
Thread-Topic: ] [PATCH net-next] net: ethernet: mtk_eth_soc: add missing check
 for rhashtable_init
Thread-Index: AQHap3dQVMNVjNkdZEasWxrQ03s9qw==
Date: Thu, 16 May 2024 09:56:25 +0000
Message-ID: 
 <PH0PR18MB44744D577E2114AA1B72857DDEED2@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20240516092427.3897322-1-nichen@iscas.ac.cn>
In-Reply-To: <20240516092427.3897322-1-nichen@iscas.ac.cn>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?OGPtNnYsGPao/8/WveHfgUzqcb++irPKLtdcWRJXIHbjMCqZDDgAG8qtkyqG?=
 =?us-ascii?Q?nQhCUi7ruQ3ECgyLMx94IFMBktGTt0vERBX8xJO9EFjUJFnS9Xh7Zd7r9tNM?=
 =?us-ascii?Q?uA1I0wYqn/FUqZM2n4II3AhJiJXpY2OMytTkADu4MQeuX6KxefpOSvyb2lfU?=
 =?us-ascii?Q?fS/3dTosuq0XgYEW0VcEsE3O9ElJUF0E/pkQC9MG6zNc5fIsLks4cd57MSf6?=
 =?us-ascii?Q?UMheySMJ3na89rQZ6If/vFXbhQ/x4ZJDDMoGAgGa0bf0tstRVbi3Iv0elWN+?=
 =?us-ascii?Q?j2++tW7Oq0R86caMF3neqIRiaLKnLtKwi/dcGQyY78hAkM+Ir/kbeSbmgDus?=
 =?us-ascii?Q?aW6CznK1JQbXKBc9hDfvQeqYN8gg5sz6rrBWdl9c9MQRlzw2lVXvRlr5JB1Y?=
 =?us-ascii?Q?MSdKWHKxOwH1TVzOXCzufFtWAWPEeY3DP9zN2+MJ5BapLSIxPxw4rvEX0Yib?=
 =?us-ascii?Q?/vGzXYiJHExXpMny5g0PdMEIs99WGJGM5kiFti/yGRLqQrbmTIKfFb3gXmWP?=
 =?us-ascii?Q?AYoq6/pwUai6Py+Dtgr2ZIehNrbcgO7b2nWZRMttWuFrX4EIlhSIwXWS0MuE?=
 =?us-ascii?Q?mymLxHrjpWMnfS1LbSIK4bPI8w29/A4PbEKp7DH9iox86Y0bj//LcpreeuGl?=
 =?us-ascii?Q?AYK0X7VKlY4u1BSMqCm5pT1aj+OOdHY9d3hEe5WrGy8XW6YUuQ9sXeLgddCM?=
 =?us-ascii?Q?ndZqa4JqHEuSar98xL5NsWGIB6sCK29spdCiePysYvvNjBXxB5HQYcbiPkhv?=
 =?us-ascii?Q?pRKUj7Vfzv7dc4z2wvePIHFAUrcMMFlueAykb0D0fE0M0nEGidWjXIgdeYVF?=
 =?us-ascii?Q?Nhx94fxFBg9KWZRT4jiQeE9GBxtdIzIrvmY6TKFnzPWXXaF1o3CqWA+OE6X4?=
 =?us-ascii?Q?lEziOTPWOhk53lJdcS3RvscuBh3d9fRubP/Qh+gVsP6U49F09qWMmWeGcgb/?=
 =?us-ascii?Q?w/TI0KF1VrnvO/o2nARNzRqUAY51oDiMe+5VxUt2GNhp4WhyQoRShYPGYQ8j?=
 =?us-ascii?Q?nIci3WNlIm9P9eJKhV6TAH+8IYVVL9jh5ztJOZ2fNE8aMQxkdgnIgzxca5Kh?=
 =?us-ascii?Q?uqoxOWpZzDewexVTfyxCIqK81UMlL8UpcBu+wQ/hXMy39npWYz8QGjkR3G8V?=
 =?us-ascii?Q?5tJWjKE/Rp+fkWIZdKmHI5w5Ey4vjOlz97dNvaNphcKfZcfijJ7S08gfeozA?=
 =?us-ascii?Q?h3LPZQ+JpzCmEjQoeBuE4KXE1DDAqfumKLaJhVT0NgABB588CgJHdBv9IdEV?=
 =?us-ascii?Q?fNJX+irc87q4KPm4IUG4lHb/tB9dWmIDO5vAMJTlxTp/tRrxX20Y+bcXRtu/?=
 =?us-ascii?Q?NXui3Gz27sNUxkv76h6L2iq/3l6KSYo67ZsADECh/lp/MmNNEDFNV6Wewxaw?=
 =?us-ascii?Q?3QsWODUDp9H7BmdmScxGSfJnh30S7lNdNwhGEVCz5KIfaM6CbTgxJJTsdLAO?=
 =?us-ascii?Q?CbnpnLTcpwR7OZ+AsmduyF4yuszleyY0VRxK/jBpjkQzvfyXYLnHGggPZnJj?=
 =?us-ascii?Q?NxcETglajlCxDu5bPsw+yPobmtJv/9CjyPokNAelkrxYwIcwzIuo0GOIv/JM?=
 =?us-ascii?Q?ROzCD2ufsJakAFOjclw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bad6d3f-70a6-49c6-135a-08dc758e7309
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2024 09:56:25.5049
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cTnV78523HN5oDryv6JtBhVAbhMNFiyO5ApiuNh1nv7FsPCcXQVzEzrrTCD+aAjTxb47JBeNDjTtoyJGDSHBzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3605
X-Proofpoint-GUID: UyTGBgPlA-KBuRTLYRL7rrqFtpz3nbDO
X-Proofpoint-ORIG-GUID: UyTGBgPlA-KBuRTLYRL7rrqFtpz3nbDO
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-16_05,2024-05-15_01,2023-05-22_02


> Add check for the return value of rhashtable_init() and return the error =
if it
> fails in order to catch the error.
>=20
> Fixes: 33fc42de3327 ("net: ethernet: mtk_eth_soc: support creating mac
> address based offload entries")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/net/ethernet/mediatek/mtk_ppe.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/mediatek/mtk_ppe.c
> b/drivers/net/ethernet/mediatek/mtk_ppe.c
> index 0acee405a749..f7e5e6e52cdf 100644
> --- a/drivers/net/ethernet/mediatek/mtk_ppe.c
> +++ b/drivers/net/ethernet/mediatek/mtk_ppe.c
> @@ -884,12 +884,15 @@ struct mtk_ppe *mtk_ppe_init(struct mtk_eth *eth,
> void __iomem *base, int index)
>  	struct mtk_ppe *ppe;
>  	u32 foe_flow_size;
>  	void *foe;
> +	int ret;
>=20
>  	ppe =3D devm_kzalloc(dev, sizeof(*ppe), GFP_KERNEL);
>  	if (!ppe)
>  		return NULL;
>=20
> -	rhashtable_init(&ppe->l2_flows, &mtk_flow_l2_ht_params);
> +	ret =3D rhashtable_init(&ppe->l2_flows, &mtk_flow_l2_ht_params);
> +	if (ret)
> +		return NULL;

Instead of returning NULL, return actual error ERR_PTR(ret) and use IS_ERR_=
OR_NULL API to validate the error

Thanks,
Hariprasad k
>=20
>  	/* need to allocate a separate device, since it PPE DMA access is
>  	 * not coherent.
> --
> 2.25.1
>=20