Received-SPF: pass (google.com: domain of linux-kernel+bounces-180879-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Liu Ying <victor.liu@nxp.com>
To: dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: andrzej.hajda@intel.com,
	neil.armstrong@linaro.org,
	rfoss@kernel.org,
	Laurent.pinchart@ideasonboard.com,
	jonas@kwiboo.se,
	jernej.skrabec@gmail.com,
	maarten.lankhorst@linux.intel.com,
	mripard@kernel.org,
	tzimmermann@suse.de,
	airlied@gmail.com,
	daniel@ffwll.ch,
	biju.das.jz@bp.renesas.com,
	dmitry.baryshkov@linaro.org,
	u.kleine-koenig@pengutronix.de,
	aford173@gmail.com,
	jani.nikula@intel.com,
	bli@bang-olufsen.dk,
	sui.jingfeng@linux.dev
Subject: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary
Date: Thu, 16 May 2024 18:10:06 +0800
Message-Id: <20240516101006.2388767-1-victor.liu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
 =?us-ascii?Q?YGjgpN0Ze4IhwlWZZjuVCD1VF4bRvE5P9sVqDRPu4yxS+4MfAHmhoq3d+7dJ?=
 =?us-ascii?Q?36Dyyaa+/KVkF9cmswFjlKKaDFjbS1+hSAZnss4GOeYCVC/+QS8sw9ZsAnFN?=
 =?us-ascii?Q?AVtx/o5h2iEBT6WI1BtlkvFMVe8ZpQ0Ry5CzxJIEwGpqeboWhJS1/aECkNYf?=
 =?us-ascii?Q?J74ohEHrdp7+DlcO8Fxr33+7OANVRuI4WXSCSGP1kZLBr+Kmp8x0FNl+052Z?=
 =?us-ascii?Q?daUXpPuJf5iFweJFqgaoXMq0DN+zY7r7QkGMwFsLJE1/nBerZLJfYZ6aEL2k?=
 =?us-ascii?Q?Wlf+yPuOlCqd7iKEyzBYa+uDQCSGI+cYn02SVyXwKRHJ0x/GMll+PbuDwH2/?=
 =?us-ascii?Q?mOvvOrx8TL1d2DtBvRfez4Wbkp1Y+hYjnkf630ixjT59+ia5aWv5So5AbWvC?=
 =?us-ascii?Q?P++Oe/xONX8yBIj428UT7jjj3OGBaK6umigGR3KQetHA+gzu/ulUAXy78BHd?=
 =?us-ascii?Q?ttU3x6+xHDKhEnx4Olsz6wJ4DZILfUhQBnAuAcR69yroNDEtPf/dtz894W5M?=
 =?us-ascii?Q?DauM3cqFr99QyzaRMYjtkz1u1Vd1OaUMY3OusjWwjIPq4rb/4izX4EycyXgB?=
 =?us-ascii?Q?yS2u6hzuhbvW923UdwxpY3dDNFtnAZ78X0bCxVe3tBNzreUsbAdO8XNXpvu6?=
 =?us-ascii?Q?d8m4WYA2dGlaxvPI9yIcSUW6wLQ5EZplG1d//bJxg1r66F/4xtfokLw5+6oe?=
 =?us-ascii?Q?qc5M1r9C9Dg2KIR+aeoeLpSdFnSgshkWFqrwXoQwIey9NP4a0TWkccCUBzk3?=
 =?us-ascii?Q?kd5uKJzZ3h99RD4i2/O9yF2jM9NRWGR8CSU6PaG6wghZ9h6RLruNBNK+wVYW?=
 =?us-ascii?Q?/2zv9KShjm880VmYHh66UB7ZFLAhahio8pBNN7AjS1G1M2p4SSzwsRb1GON9?=
 =?us-ascii?Q?PW+NxpL+m51SHcdqpfvoi8Mvgxt7A+zhXfFqyNvENGPCw6K2S/2nYVFyKz6V?=
 =?us-ascii?Q?KAhgk0IoWbZX0hLJTwhAS0SK6LG6GjR7UrYDVPW8VPH1zFtwBq5UPilsNUZW?=
 =?us-ascii?Q?k1dfnNdSOuSbefOSQKhnBrUVTwkR+Y1a96QnAGEqYC5181+PKaIr5SPumwys?=
 =?us-ascii?Q?hPl6heeJnsvD7SOOs8xdimHZTRHtluJNakV3a2wV9Hb/zhZYDyRjdvh4mKWt?=
 =?us-ascii?Q?aS0rGVwJqZrzT5QfTmXoro5m7kMIMnE3MVPUnMEZUPcWPIpBc0kDM7MwvRzQ?=
 =?us-ascii?Q?PxDIWWFM08qTuZx+g2vDOVjMyD76Pu19jfjxMI0+364Be6PvJeUydriDHgtr?=
 =?us-ascii?Q?tw9qkmEaogR4Fy2E2Qjbd1e+9Ztv3aDT0cXt01YFTfiVnHgM9wRS1qYZ2KJl?=
 =?us-ascii?Q?AKvuVok30aPNs5ButWGf5iorZSlIBYp9Ha6NqRy+QAVX5rWEkVdMpTRBIv/s?=
 =?us-ascii?Q?CWK/oN7kqBGVle1fvBbQu5iQn9FeTP+f4AqGGuThAUl+e4/zb3WUh07Np03e?=
 =?us-ascii?Q?JpPTEe2urX/G1++WHH8GobTwl6xmWB0XOAV/NC3cl0sw3NkT9Wd37BOj4IrG?=
 =?us-ascii?Q?8oR/Py18enNDjI71Ug+w0QVRPTIDL1QkTk64n3DaFfumLy0gdJQtYUHsNeSC?=
 =?us-ascii?Q?TEpOmhnhE778dWxSkxHel2QOwLWUzrQemHTXF3fL?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad8f8066-b1f0-4c66-cc54-08dc758f2bf2
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 10:01:36.0542
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jdPEP+GC8qduQeyYelVsFZzYhG4isVvLk4nzNuLiruZfWWjjBCh8KFE0dZF5kGa3VMRKmobZ9SpDZ/abFi52UQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7232

Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins")
fails to consider the case where adv7511->i2c_main->irq is zero, i.e.,
no interrupt requested at all.

Without interrupt, adv7511_wait_for_edid() could return -EIO sometimes,
because it polls adv7511->edid_read flag by calling adv7511_irq_process()
a few times, but adv7511_irq_process() happens to refuse to handle
interrupt by returning -ENODATA.  Hence, EDID retrieval fails randomly.

Fix the issue by checking adv7511->i2c_main->irq before exiting interrupt
handling from adv7511_irq_process().

Fixes: f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins")
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index 6089b0bb9321..2074fa3c1b7b 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -479,7 +479,8 @@ static int adv7511_irq_process(struct adv7511 *adv7511, bool process_hpd)
 		return ret;
 
 	/* If there is no IRQ to handle, exit indicating no IRQ data */
-	if (!(irq0 & (ADV7511_INT0_HPD | ADV7511_INT0_EDID_READY)) &&
+	if (adv7511->i2c_main->irq &&
+	    !(irq0 & (ADV7511_INT0_HPD | ADV7511_INT0_EDID_READY)) &&
 	    !(irq1 & ADV7511_INT1_DDC_ERROR))
 		return -ENODATA;
 
-- 
2.37.1