Received-SPF: pass (google.com: domain of linux-kernel+bounces-180905-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <12437901.O9o76ZdvQC@kreacher> <6046110.lOV4Wx5bFT@kreacher> <ZkXea4fdJwgvu0Hm@smile.fi.intel.com>
In-Reply-To: <ZkXea4fdJwgvu0Hm@smile.fi.intel.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 16 May 2024 12:26:34 +0200
Message-ID: <CAJZ5v0hxDDrN8DyKws1R-3GabjHcQ4eua2wyTQsueqnqa6Y4+Q@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] ACPI: EC: Install address space handler at the
 namespace root
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Linux ACPI <linux-acpi@vger.kernel.org>, 
	LKML <linux-kernel@vger.kernel.org>, Hans de Goede <hdegoede@redhat.com>, 
	Mario Limonciello <mario.limonciello@amd.com>, Armin Wolf <w_armin@gmx.de>, 
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 16, 2024 at 12:22=E2=80=AFPM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, May 15, 2024 at 09:40:54PM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > It is reported that _DSM evaluation fails in ucsi_acpi_dsm() on Lenovo
> > IdeaPad Pro 5 due to a missing address space handler for the EC address
> > space:
> >
> >  ACPI Error: No handler for Region [ECSI] (000000007b8176ee) [EmbeddedC=
ontrol] (20230628/evregion-130)
> >
> > This happens because if there is no ECDT, the EC driver only registers
> > the EC address space handler for operation regions defined in the EC
> > device scope of the ACPI namespace while the operation region being
> > accessed by the _DSM in question is located beyond that scope.
> >
> > To address this, modify the ACPI EC driver to install the EC address
> > space handler at the root of the ACPI namespace for the first EC that
> > can be found regardless of whether or not an ECDT is present.
> >
> > Note that this change is consistent with some examples in the ACPI
> > specification in which EC operation regions located outside the EC
> > device scope are used (for example, see Section 9.17.15 in ACPI 6.5),
> > so the current behavior of the EC driver is arguably questionable.
>
> ...
>
> > -             status =3D acpi_install_address_space_handler_no_reg(ec->=
handle,
> > +             status =3D acpi_install_address_space_handler_no_reg(scop=
e_handle,
> >                                                                  ACPI_A=
DR_SPACE_EC,
> >                                                                  &acpi_=
ec_space_handler,
> >                                                                  NULL, =
ec);
>
> Looking at this...
>
> >               if (ACPI_FAILURE(acpi_remove_address_space_handler(
> > +                                             scope_handle,
> > +                                             ACPI_ADR_SPACE_EC,
> > +                                             &acpi_ec_space_handler)))
>
> ...and this, I believe you can move scope_handle to the previous line and=
 align
> the rest for the sake of consistency and slightly better readability.

Well, I prefer to cut a separate cleanup patch to make this more consistent=
.