Received-SPF: pass (google.com: domain of linux-kernel+bounces-180912-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <ce6d7e6a-e24a-43b4-a9b8-4e946277c2d8@arm.com>
Date: Thu, 16 May 2024 12:36:21 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] MAINTAINERS: perf: arm64: Catch all Arm files and folders
To: Anshuman Khandual <anshuman.khandual@arm.com>,
 linux-perf-users@vger.kernel.org
Cc: gregkh@linuxfoundation.org, John Garry <john.g.garry@oracle.com>,
 Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
 Leo Yan <leo.yan@linux.dev>, Peter Zijlstra <peterz@infradead.org>,
 Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>,
 Namhyung Kim <namhyung@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
 Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
 Adrian Hunter <adrian.hunter@intel.com>, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org
References: <20240515151221.204163-1-james.clark@arm.com>
 <e92a8423-9172-4aec-acbf-c9f136e6884f@arm.com>
Content-Language: en-US
From: James Clark <james.clark@arm.com>
In-Reply-To: <e92a8423-9172-4aec-acbf-c9f136e6884f@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 16/05/2024 06:35, Anshuman Khandual wrote:
> 
> 
> On 5/15/24 20:42, James Clark wrote:
>> Catch all files and folders with Arm in the name in tools/perf/ up to
>> two levels deep. There currently no false positives.
>>
>> This catches lots of missing items like these and more:
>>
>>   * util/arm-spe-decoder/
>>     (The existing util/arm-spe* entry only matched files not folders)
>>   * util/perf-regs-arch/perf_regs_arm.c
>>   * scripts/python/arm-cs-trace-disasm.py
>>   * tests/shell/test_arm_spe.sh
> 
> Agreed.
> 
>>
>> Signed-off-by: James Clark <james.clark@arm.com>
>> ---
>>  MAINTAINERS | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index ec0284125e8f..c5d0256d32dd 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -17318,9 +17318,10 @@ R:	Leo Yan <leo.yan@linux.dev>
>>  L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
>>  S:	Supported
>>  F:	tools/build/feature/test-libopencsd.c
>> -F:	tools/perf/arch/arm*/
>> -F:	tools/perf/pmu-events/arch/arm64/
>> -F:	tools/perf/util/arm-spe*
>> +F:	tools/perf/*/*/*arm*
>> +F:	tools/perf/*/*/*arm*/
>> +F:	tools/perf/*/*arm*
>> +F:	tools/perf/*/*arm*/
>>  F:	tools/perf/util/cs-etm*
> 
> Very minor nit, these regular expressions should be arranged as per
> the increasing directory depth levels, just to make it apparent in
> terms of which files are being covered here ?
> 
> F:	tools/perf/*/*arm*
> F:	tools/perf/*/*arm*/
> F:	tools/perf/*/*/*arm*
> F:	tools/perf/*/*/*arm*/
> 

Checkpatch has an alphabetical sort which says they have to be the other
way around, but yes I agree I did write it your way initially.

> But regardless, with or without the above changes
> 
> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
> 
>>  
>>  PERSONALITY HANDLING