Received-SPF: pass (google.com: domain of linux-kernel+bounces-180931-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
Date: Thu, 16 May 2024 11:16:05 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: "Yajun Deng" <yajun.deng@linux.dev>
Message-ID: <e41ea9022c217bb6aed5a8a4b8375a62878c9c8b@linux.dev>
TLS-Required: No
Subject: Re: [PATCH] mm/cma: get nid from physical address
To: "Kefeng Wang" <wangkefeng.wang@huawei.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
In-Reply-To: <1d38aa26-cd2f-4330-9dcc-6c379cecb83b@huawei.com>
References: <20240516091701.1527002-1-yajun.deng@linux.dev>
 <1d38aa26-cd2f-4330-9dcc-6c379cecb83b@huawei.com>

May 16, 2024 at 6:03 PM, "Kefeng Wang" <wangkefeng.wang@huawei.com> wrote=
:


>=20
>=20On 2024/5/16 17:17, Yajun Deng wrote:
>=20
>=20>=20
>=20> The nid passed to cma_declare_contiguous_nid() may be NUMA_NO_NODE,
> >=20
>=20>  which is not the actual nid. To get the correct nid, we can get th=
e nid
> >=20
>=20>  from physical address.
> >=20
>=20
> Please check
>=20
>=20https://lore.kernel.org/linux-riscv/47437c2b-5946-41c6-ad1b-cc03329eb=
230@huawei.com/
>=20

Okay,=20thanks!
> >=20
>=20> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> >=20
>=20>  ---
> >=20
>=20>  mm/cma.c | 1 +
> >=20
>=20>  1 file changed, 1 insertion(+)
> >=20
>=20>  diff --git a/mm/cma.c b/mm/cma.c
> >=20
>=20>  index 3e9724716bad..be6cdde32944 100644
> >=20
>=20>  --- a/mm/cma.c
> >=20
>=20>  +++ b/mm/cma.c
> >=20
>=20>  @@ -361,6 +361,7 @@ int __init cma_declare_contiguous_nid(phys_add=
r_t base,
> >=20
>=20>  kmemleak_ignore_phys(addr);
> >=20
>=20>  base =3D addr;
> >=20
>=20>  }
> >=20
>=20>  + nid =3D early_pfn_to_nid(PHYS_PFN(base));
> >=20
>=20>  > ret =3D cma_init_reserved_mem(base, size, order_per_bit, name, r=
es_cma);
> >=20
>=20>  if (ret)
> >
>