Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933762AbYAaQag (ORCPT ); Thu, 31 Jan 2008 11:30:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760941AbYAaQa1 (ORCPT ); Thu, 31 Jan 2008 11:30:27 -0500 Received: from ns1.suse.de ([195.135.220.2]:37486 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758522AbYAaQaY (ORCPT ); Thu, 31 Jan 2008 11:30:24 -0500 Date: Thu, 31 Jan 2008 17:30:22 +0100 From: Andi Kleen To: Thomas Gleixner Cc: huang ying , "Huang, Ying" , Ingo Molnar , "H. Peter Anvin" , Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] x86: add executable mapping support to ioremap Message-ID: <20080131163022.GD25989@bingen.suse.de> References: <1201764967.12950.25.camel@caritas-dev.intel.com> <851fc09e0801310522s2d690c3ejef661e5ce6847f73@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 550 Lines: 16 > There is nothing to fix. It works on virtual addresses. > > The __pa() in change_page_attr_addr() is only used to check for the > high alias mapping of the kernel, but the call to change_page_attr > uses the virtual address. But __pa() doesn't work for ioremap ... huang is completely right. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/