Received-SPF: pass (google.com: domain of linux-kernel+bounces-180947-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 16 May 2024 12:33:36 +0100
From: Mark Brown <broonie@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] regulator: don't cache vsel to ensure voltage setting
Message-ID: <f7cf4ac0-afa2-4f64-818b-1275b1e8a6ee@sirena.org.uk>
References: <cover.1715848512.git.mazziesaccount@gmail.com>
 <a8ee4ae5532b67a5aef0f6e482cb37f5efbd8952.1715848512.git.mazziesaccount@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="XJhKCSwPgGL9pZtO"
Content-Disposition: inline
In-Reply-To: <a8ee4ae5532b67a5aef0f6e482cb37f5efbd8952.1715848512.git.mazziesaccount@gmail.com>


--XJhKCSwPgGL9pZtO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, May 16, 2024 at 11:53:46AM +0300, Matti Vaittinen wrote:

> +		/*
> +		 * Some PMICs treat the vsel_reg same as apply-bit. Force it
> +		 * to be written even if the old selector were same as the new
> +		 * (but range changed) by using regmap_write_bits() and not the
> +		 * regmap_update_bits().
> +		 */
> +		ret = regmap_write_bits(rdev->regmap, rdev->desc->vsel_reg,
> +					rdev->desc->vsel_mask, sel);

This feels like a special case for those devices, for devices that don't
have this behaviour it'd be a regression in that it'd increase I/O
traffic.  At least this should be specialised to only devices that have
ranges I think?

--XJhKCSwPgGL9pZtO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZF7xAACgkQJNaLcl1U
h9DbNAf/VLLIo8HA9/ZDXifhrB3586UcRnANOPXHGEAN7ftgwLP39775DG1h3x2E
7DPQwJk3JLXuP9j0mH3B4YkoXAnyQBJr8Geaa2b6EJHSBC7aa/6MNPxc3IrB8m86
pCkzfAUcJVH0ES52rxTmIcyRJ948T09kvVf18+/yeFH+pJHXdHHY9kis5SfWRSBp
L3ATdZb+1mJIYtD88051r9a3RaaOGpKFb2VHxV888MxGduftSJRjGqm1Ynw2ACI7
UlAi33taOrja7mZOj1hZySLNFgbphc9nxgbnrm8kT4ptBgXJSK0SpFjwpGYJq3td
QDqMmgTYcY/rC0v7zH8Ydr3cuCLwZw==
=8ygg
-----END PGP SIGNATURE-----

--XJhKCSwPgGL9pZtO--