Received-SPF: pass (google.com: domain of linux-kernel+bounces-180954-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 16 May 2024 13:43:18 +0200
From: Larysa Zaremba <larysa.zaremba@intel.com>
To: Simon Horman <horms@kernel.org>
CC: <intel-wired-lan@lists.osuosl.org>, Jacob Keller
	<jacob.e.keller@intel.com>, <maciej.fijalkowski@intel.com>, Magnus Karlsson
	<magnus.karlsson@gmail.com>, Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	<igor.bagnucki@intel.com>, "David S. Miller" <davem@davemloft.net>, "Eric
 Dumazet" <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann
	<daniel@iogearbox.net>, Jesper Dangaard Brouer <hawk@kernel.org>, "John
 Fastabend" <john.fastabend@gmail.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>
Subject: Re: [PATCH iwl-net 3/3] ice: map XDP queues to vectors in
 ice_vsi_map_rings_to_vectors()
Message-ID: <ZkXxVp3hFvczWr8r@lzaremba-mobl.ger.corp.intel.com>
References: <20240515160246.5181-1-larysa.zaremba@intel.com>
 <20240515160246.5181-4-larysa.zaremba@intel.com>
 <20240516082713.GC179178@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240516082713.GC179178@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HLJErOfeYxo7BGc6fvvh1R1EGo4m/Om97RVHuxrPL6O3ECffo8Tv2kW2QBZf?=
 =?us-ascii?Q?pWrTStizbsPODPCy0PgoSdDI7aaxSJQszYionTO0lsC/d1zQprvzBosCSNQx?=
 =?us-ascii?Q?MS8iqkHPdKv7yW/LzDWOrOcEpLZcp7MOcWKbfYKx+06/Az/2bl5PqWvTkjIo?=
 =?us-ascii?Q?G/aYBqjFDZZSkhWH5rxijuBLn8tZl7bA4KGr3f5HWD/kGtxgyV1YtvYCnQvK?=
 =?us-ascii?Q?QYfAn1wGaqFfO77Cx8j/4F+7iDfoHeN6Fhq+kRjLb5m3CarEaq1IKi18VN8W?=
 =?us-ascii?Q?XbG6V0F0PH7xSRWD687t+twp5b9mVd/mr38WGboVSXyabo7475JGgaFALl5Q?=
 =?us-ascii?Q?g8q+0tsvMWnV3jVFY+hQFsY0Z9TN8oVRgwEobHCUUJqA45fsfMsOnJSfF6y1?=
 =?us-ascii?Q?hEZK8XrZvsZnv7w+ab1wnMhpIom2dr4ILVGa0r71tGI2sKUZ1gVnOhIKtgkN?=
 =?us-ascii?Q?9S2kNdbWoODD0yL36pVWfYrjSywOmCI7t/0aAZTn10WxKeBVwHMYiwi/Aadd?=
 =?us-ascii?Q?onp3z29MOZSqbYl+Yky0cgjUT1jBHKqTo8N7POLNWLMNtmZ0XpVUS98b2rlc?=
 =?us-ascii?Q?pgRPC5qYg7XT0jjjvIYjxPEAcbMALTBd8kNGUpKzdHrqTOkMkUbsKUb6mxCF?=
 =?us-ascii?Q?voW9mPpVVgk1Dd6/7eK8aAOIcVagm1qHfBQMRmNi+9Cd2zBbeM2mQ66RQ4WZ?=
 =?us-ascii?Q?2PloVpgqaJ4unWuvR4lsC6n3zGIH0iPc8zGksaP3imb8y8ghx0HbLYF986/y?=
 =?us-ascii?Q?7oBd4nA3+Edsu0vNHJ6PN7tmql7/OnymcH8VsgQDzah+yemLuNN/XUbIvm92?=
 =?us-ascii?Q?OMeoELW6ZYGF3q5cS1uymSi7YYohPsg15ZGbakshY+kU1/Bot3cniYhxcYfz?=
 =?us-ascii?Q?hM1TxOid/mvOAly+6arHJSBdgVwCuqDSO2iVcgApdo6Qe5AmOfkCjzryRVyL?=
 =?us-ascii?Q?0cB6iCU/6sRJk7kCuLhbIIV9UuYOSWg1/gh5MBP6zNL9hEBbwA3s6tjIK/kM?=
 =?us-ascii?Q?bRGLerbCiCg3hHjR8Uaw5ocLoTsz+VrdCNcKzSP4KaWQ6KmlEZS2En74kPwy?=
 =?us-ascii?Q?J+VFL76a3ng+ZAWs1ruVSANAUrVbG+Lc8VSB3DtQwPA7nsQAyn3C7T3bnViS?=
 =?us-ascii?Q?8KBf2gSyGulKt3By91tWi2yO118lkaC99nyAGYUnNsswE/SoMzz84jnTxHr9?=
 =?us-ascii?Q?pz5qhDKkTGdyQcHL/FuDRiAZtlED6iwUFhayxuzSZvLDfjXKQz63xjpulHIX?=
 =?us-ascii?Q?0fQXIosHZBVdjcGYUCZCfhm9WWs/7pY8P4d3Kgk+R3OuWJR0iOwWv0WsLH8Q?=
 =?us-ascii?Q?zPkMmJ5QfmAGTwifgVS6XpZ3RZH7BCzTCke6mLmEQ1iLnqG2gsUkwgqNgEmi?=
 =?us-ascii?Q?mY1dpTWrFuZv2OFC7JORJgpL7tkyXoQ0+1KIKkTPKv+lIbyENBDNuqmGeW8u?=
 =?us-ascii?Q?YKrKd8bTzmCpMpTTiP74zYSO7i6UoTQi5cN7YuZKxFwLxTySmX0VYxsGNYFr?=
 =?us-ascii?Q?ncnt9v0XpfMmc6FyZ4iwCXu1Sg6WggpPlx29AEwiDaHVRoLHkxVoNxOP54wM?=
 =?us-ascii?Q?hKOaH6Lo2seh1xRxfuIBnXqqTh8fFayHloZta9E2sqd8Fn2Tqdstwmym9Aor?=
 =?us-ascii?Q?tw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 10349e5d-13b8-4778-0b28-08dc759d677e
X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7540.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 11:43:28.7699
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sjipUoARqmSWT7a1p0X2oQDWF7i8nRM2tjxzNbHjW2lkPqVfsMUoZsjJtGQYERYu0KwrqLQoorVY+5ns2ISjFXSKK6VxrLAPXEJSk5K611Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8412
X-OriginatorOrg: intel.com

On Thu, May 16, 2024 at 09:27:13AM +0100, Simon Horman wrote:
> On Wed, May 15, 2024 at 06:02:16PM +0200, Larysa Zaremba wrote:
> > ice_pf_dcb_recfg() re-maps queues to vectors with
> > ice_vsi_map_rings_to_vectors(), which does not restore the previous
> > state for XDP queues. This leads to no AF_XDP traffic after rebuild.
> > 
> > Map XDP queues to vectors in ice_vsi_map_rings_to_vectors().
> > Also, move the code around, so XDP queues are mapped independently only
> > through .ndo_bpf().
> 
> Hi Larysa,
> 
> I take it the last sentence refers to the placement of ice_map_xdp_rings()
> in ice_prepare_xdp_rings() after rather than before the
> (cfg_type == ICE_XDP_CFG_PART) condition.
> 
> If so, I see that it is a small change. But I do wonder if it is separate
> from fixing the issue described in the first paragraph. And thus would
> be better as a separate patch.

This is not neccessary for the fix to work, but I think this is intergral to
making the change properly. I mean, before the change in the rebuild path we map
XDP rings to vectors only once and after the change we do this only once, just
previously it was in ice_prepare_xdp_rings() and now it is in
ice_vsi_map_rings_to_vectors().

> 
> Also, (I'm raising a separate issue :) breaking out logic into
> ice_xdp_ring_from_qid() seems very nice.  But I wonder if this ought to be
> part of a cleanup-patch for 'iwl' rather than a fixes patch for 'iwl-next'.
>

I have separated this into a separate function, because 2 lines exceeded 80 
characters, which is not in line with our current style for drivers.
And I do not think that this small function creates any more additional 
potentian applying problems for this patch. And the change is small enough to 
see that the logic stays the same.

> OTOH, I do see that breaking out ice_map_xdp_rings() makes sense in the
> context of this fix as the same logic is to be called in two places.
> 
> Splitting patches aside, the resulting code looks good to me.
> 
> ...
>