Received-SPF: pass (google.com: domain of linux-kernel+bounces-180957-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 16 May 2024 12:47:00 +0100
From: Mark Brown <broonie@kernel.org>
To: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Banajit Goswami <bgoswami@quicinc.com>,
	Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, quic_rohkumar@quicinc.com,
	quic_pkumpatl@quicinc.com
Subject: Re: [PATCH v4 2/7] ASoC: codecs: wcd937x-sdw: add SoundWire driver
Message-ID: <91f581ef-58ea-4b98-80e2-dd9b14a61c60@sirena.org.uk>
References: <20240516044801.1061838-1-quic_mohs@quicinc.com>
 <20240516044801.1061838-3-quic_mohs@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="6TMXXQ4QPf3seqeB"
Content-Disposition: inline
In-Reply-To: <20240516044801.1061838-3-quic_mohs@quicinc.com>


--6TMXXQ4QPf3seqeB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, May 16, 2024 at 10:17:56AM +0530, Mohammad Rafi Shaik wrote:

> +static const struct reg_default wcd937x_defaults[] = {

> +	{ WCD937X_DIGITAL_EFUSE_REG_0,				0x00 },
> +	{ WCD937X_DIGITAL_EFUSE_REG_1,				0xff },
> +	{ WCD937X_DIGITAL_EFUSE_REG_2,				0xff },
> +	{ WCD937X_DIGITAL_EFUSE_REG_3,				0xff },

Given the name I'd expect these to vary per device so not have default
values.  In general ID, status or volatile registers probably shouldn't
have defaults since they should be read from the device.

> +static bool wcd937x_readonly_register(struct device *dev, unsigned int reg)
> +{
> +	switch (reg) {

> +	case WCD937X_DIGITAL_CHIP_ID0:
> +	case WCD937X_DIGITAL_CHIP_ID1:
> +	case WCD937X_DIGITAL_CHIP_ID2:
> +	case WCD937X_DIGITAL_CHIP_ID3:

> +	case WCD937X_DIGITAL_EFUSE_REG_0:
> +	case WCD937X_DIGITAL_EFUSE_REG_1:
> +	case WCD937X_DIGITAL_EFUSE_REG_2:

> +	.readable_reg = wcd937x_readable_register,
> +	.writeable_reg = wcd937x_rdwr_register,
> +	.volatile_reg = wcd937x_readonly_register,

It's not a bug per se since things will work but you should probably
have separate volatile and read only checks, things like the ID and
efuse registers are read only but they shouldn't vary at runtime so
could be cached and not volatile.

--6TMXXQ4QPf3seqeB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZF8jMACgkQJNaLcl1U
h9C/Agf/dxl2QvSF6O91HT9LEA+eXsV+RD+If0rb6NqB7TD6GqF4NT8biCZgRABj
+5j0XCauKqigxtMYyzxxdJE80SL5L9z93e7OLemzzOfxpspvFbNcnktzgCN2zPTc
HNDtykLiV7SvrRm8e2J7aU3aqhSBBp1d2e970CmaOnVuyvfbyZVoPjsvicMgHZP9
3CB0Pa1C1+By8DrFR7vI6yembohfU4wFeB/66qzYovFSCI/hOuMYo2usgNhsaT8d
hUjon+Xz5e9/yaNPVIRjWuOsEa2yL1lo21HwR9drPjRtZNeTlxxhKrXoDd3goJLS
EdleAlXH/IcsXx7gjcdXQDal8syQPg==
=W/m3
-----END PGP SIGNATURE-----

--6TMXXQ4QPf3seqeB--