Received-SPF: pass (google.com: domain of linux-kernel+bounces-180981-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 16 May 2024 13:13:19 +0100
From: Mark Brown <broonie@kernel.org>
To: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shengjiu Wang <shengjiu.wang@gmail.com>,
	Xiubo Li <Xiubo.Lee@gmail.com>, Fabio Estevam <festevam@gmail.com>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCHv4 7/9] ASoC: fsl-asoc-card: add DT clock "cpu_sysclk"
 with generic codec
Message-ID: <ffb3624f-2170-4642-aaa5-fb6736a75d59@sirena.org.uk>
References: <20240515135411.343333-1-elinor.montmasson@savoirfairelinux.com>
 <20240515135411.343333-8-elinor.montmasson@savoirfairelinux.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="LqD9gI/K1pmwN8AU"
Content-Disposition: inline
In-Reply-To: <20240515135411.343333-8-elinor.montmasson@savoirfairelinux.com>


--LqD9gI/K1pmwN8AU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, May 15, 2024 at 03:54:09PM +0200, Elinor Montmasson wrote:

> Add an optional DT clock "cpu_sysclk" to get the CPU DAI system-clock
> frequency when using the generic codec.
> It is set for both Tx and Rx.
> The way the frequency value is used is up to the CPU DAI driver
> implementation.

> +		struct clk *cpu_sysclk = clk_get(&pdev->dev, "cpu_sysclk");
> +		if (!IS_ERR(cpu_sysclk)) {
> +			priv->cpu_priv.sysclk_freq[TX] = clk_get_rate(cpu_sysclk);
> +			priv->cpu_priv.sysclk_freq[RX] = priv->cpu_priv.sysclk_freq[TX];
> +			clk_put(cpu_sysclk);
> +		}

I don't really understand the goal here - this is just reading whatever
frequency happens to be set in the hardware when the driver starts up
which if nothing else seems rather fragile?

--LqD9gI/K1pmwN8AU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZF+F4ACgkQJNaLcl1U
h9AXTAf/eg99B2kknpaDwJ9DZYFFkcxJ6324qRL4RTcRJNsgycwZKlovGPFG7PVB
29K3gLq85wh/oTwmaxu0ytCzdOUaYcKNAec6vzs2Ro15xt1N728lxhxfM1JnH4F3
0WTtEvxm1RB//7l8dl3SNGm+tZEPMZZf5vjpDhYF0KctVTrlgekUNwQvSXbEpi9T
Xpxz8LYxSROWirKxovgWZefVgP9CDqERbTny2dUnaFZJUwV1CZg33QsIL6S6Szg1
+6XGOwJ1XLprfuqZlcejaGFjAcaaYyscdyypTVEFxfZrm9O1sy40NL+z/QEksF7r
/BTWFjcskN42Qd4lgOeScS/BzpHJ8A==
=filG
-----END PGP SIGNATURE-----

--LqD9gI/K1pmwN8AU--