Received-SPF: pass (google.com: domain of linux-kernel+bounces-181038-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Peng Fan <peng.fan@nxp.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>
CC: "jasowang@redhat.com" <jasowang@redhat.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "eperezma@redhat.com"
	<eperezma@redhat.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH] vhost: use pr_err for vq_err
Thread-Topic: [PATCH] vhost: use pr_err for vq_err
Thread-Index: AQHap2PoJC/0KTnrWkOIs9fllb1Mi7GZy6QAgAAAj2A=
Date: Thu, 16 May 2024 12:36:14 +0000
Message-ID:
 <DU0PR04MB94172C1079F0EEF84631700688ED2@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240516074629.1785921-1-peng.fan@oss.nxp.com>
 <20240516083221-mutt-send-email-mst@kernel.org>
In-Reply-To: <20240516083221-mutt-send-email-mst@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?Q7pU6ICJ5hdFwyyjyDN+QzxqMgRw8hv4Cnmcp5rRgS8gskaWe5zhFHtA+FzT?=
 =?us-ascii?Q?D2uq4pOjLn0ErGCJqUpnQjAnCueb/arG9ezxjro5tMPgXcOdwf4dtP205Mqq?=
 =?us-ascii?Q?R4Fet9UmdymD98XFdOhBUqldmKK+4tgOHZNk5drY1o04DHVSv0BLaIE6Iyfy?=
 =?us-ascii?Q?2Wzvu9m5Al2J0/BFXNelFX15c2dgLZXBh0ibevjNYqG8b3oimpzFaj9TCxJi?=
 =?us-ascii?Q?kmFY/DKMsGHLf9vg+9F0PEMAwPhe26PJaP0sgV2XtSd3uFXep7/2+SHcaYWC?=
 =?us-ascii?Q?TMT0Q0/b5ZxpLnH/CCZiUiBc0R0dQfYDplYHyIce8yM2bxQN9/8wAXMMgHUU?=
 =?us-ascii?Q?bQ6Y2sqrKfHUmgTHVrOqJBml915dE48cBQpQQYm/zVWjz7YAWGKFh8L9xLi2?=
 =?us-ascii?Q?vIwtfUZqOTD/kAZAuH4fbZ+Zb9cHbYLry7Z32c0tEeuR2fGFuXMWXMkoEOf+?=
 =?us-ascii?Q?6xlhREJhy68ZLWoov64jxYV3kYlR5PrgXv0DZpn5/ukn72p2BHmj7RKXd1PA?=
 =?us-ascii?Q?72cYwxoWEzWBt8/4j/k9CH58pHM5pf4ZWWwsLgkh6+CDOCvZvz5gZqloTW3s?=
 =?us-ascii?Q?kiO23oreQoCwJhyy2Aypi/RbUG8GK1j4C23UuS/vU0LcUvbAQ/V0oz6jlX9q?=
 =?us-ascii?Q?R8I8FpufvwU3hm+lD4+lL+eNdN9yizFCwspdGot3hUqHUauMUd6ZnIDKqvTu?=
 =?us-ascii?Q?+F6LLWpMdL6wHP3DDgdGLwGFv79s0/wmrGXhKYEOgd2pdUiSprspo9o56t3H?=
 =?us-ascii?Q?yPR1EL2wYWnxa/9ADBIf+VOUnmZ5EUVfq1siMB9kB8wcjZuKH1sN3ypOULRa?=
 =?us-ascii?Q?SptnmVc0uj8hCDspiAOJZMQhapngWa8VBQF8G179lHdRc281ehtrNkeNwYwU?=
 =?us-ascii?Q?StIAGQOc0IgdRFhxfgXCbcE9Z1U6iZuIrsyyH6R+Bvp204HOYlKlmArX/yi6?=
 =?us-ascii?Q?6Sn9k9BBbowLG1MF6d8sCIVv+el+BX8yC5FvMB2j2UQmt2diVmN+PqgFFh6v?=
 =?us-ascii?Q?EB88jv/5DxE1GsgAnlntMJ7F5kzbeuvegsOwNpb5L9WW5eJTAPE2zpWFZIwL?=
 =?us-ascii?Q?mmT7mVkrJ7X7aA906jQMi6QF8a5NnCvOiWSyPng13diQ4X3d5ifTgHvffe+D?=
 =?us-ascii?Q?eIa2Od6B245o614VigWFrQJc4YPboFHBGag8NVkB5EQ4aX22gkMfak1BZt92?=
 =?us-ascii?Q?7c4WQiF8l8Q5PjhTG8fyocRhRpsIKmgD3xfXi3bz3Til0zJLai1tvwgpSUtC?=
 =?us-ascii?Q?lA1rleDc8Mv5e73/wbRxzMH/JElh2UBJFoiVnSbOBPLnx6PJw9H4fai9rRyE?=
 =?us-ascii?Q?0Rf/81hp7IVhwrqH4qZWFyNwp+0Fj7rmwiVyVc7O0ypmKn18ltlCAZcYzm6L?=
 =?us-ascii?Q?NTPjZC/AHhtNQ9+NKNmWmpd4DXGhzZIL7FNySr/HPdIdZ4A6h/KA1xSMSjen?=
 =?us-ascii?Q?xiQsFB8onWEARextWGcGe8vI1GSG1j3xF7+t85xKEgTJRbEDcyKNx5bzxsvE?=
 =?us-ascii?Q?akTy/gX3VjnsDTOIJUIVIVIrkRJhJNd3rWlp33eA5RwPo5iLViDnPHo5KsFh?=
 =?us-ascii?Q?jPrTy0EkJK3IKpg8dwE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3dfda90d-9c82-4c9c-e2d1-08dc75a4c665
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2024 12:36:14.3331
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HTFrV/Iwl3DfjuFsI+Fptx80w++54/u0cAIXNbNUhQNXGxTwr2h5SwklLJD3cQ+EqF5/GqTKLV9+mHdOlbPutQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7786

> Subject: Re: [PATCH] vhost: use pr_err for vq_err
>=20
> On Thu, May 16, 2024 at 03:46:29PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Use pr_err to print out error message without enabling DEBUG. This
> > could make people catch error easier.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
>=20
> This isn't appropriate: pr_err must not be triggerable by userspace. If y=
ou are
> debugging userspace, use a debugging kernel, it's that simple.

I see, then drop this patch.

Thanks,
Peng.
>=20
>=20
> > ---
> >  drivers/vhost/vhost.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h index
> > bb75a292d50c..0bff436d1ce9 100644
> > --- a/drivers/vhost/vhost.h
> > +++ b/drivers/vhost/vhost.h
> > @@ -248,7 +248,7 @@ void vhost_iotlb_map_free(struct vhost_iotlb *iotlb=
,
> >  			  struct vhost_iotlb_map *map);
> >
> >  #define vq_err(vq, fmt, ...) do {                                  \
> > -		pr_debug(pr_fmt(fmt), ##__VA_ARGS__);       \
> > +		pr_err(pr_fmt(fmt), ##__VA_ARGS__);       \
> >  		if ((vq)->error_ctx)                               \
> >  				eventfd_signal((vq)->error_ctx);\
> >  	} while (0)
> > --
> > 2.37.1