Received-SPF: pass (google.com: domain of linux-kernel+bounces-181075-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 16 May 2024 15:05:24 +0200
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Richard Weinberger <richard@nod.at>, Vignesh Raghavendra
 <vigneshr@ti.com>, linux-mtd@lists.infradead.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] mtd: nand: mxc_nand: implement exec_op
Message-ID: <20240516150524.24be4aeb@xps-13>
In-Reply-To: <ZkXvyiuB4B2Fbz4l@pengutronix.de>
References: <20240514-mtd-nand-mxc-nand-exec-op-v3-0-3e6f45fd3d82@pengutronix.de>
	<20240514-mtd-nand-mxc-nand-exec-op-v3-2-3e6f45fd3d82@pengutronix.de>
	<20240516103214.57a8ce33@xps-13>
	<ZkXfJ6n-06YqOr39@pengutronix.de>
	<20240516124405.2da1aa23@xps-13>
	<ZkXvyiuB4B2Fbz4l@pengutronix.de>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Sascha,

s.hauer@pengutronix.de wrote on Thu, 16 May 2024 13:36:42 +0200:

> On Thu, May 16, 2024 at 12:44:05PM +0200, Miquel Raynal wrote:
> > Hi Sascha,
> >=20
> > s.hauer@pengutronix.de wrote on Thu, 16 May 2024 12:25:43 +0200:
> >  =20
> > > On Thu, May 16, 2024 at 10:32:14AM +0200, Miquel Raynal wrote: =20
> > > > Hi Sascha,
> > > >    =20
> > > > > +static const struct nand_op_parser mxcnd_op_parser =3D NAND_OP_P=
ARSER(
> > > > > +	NAND_OP_PARSER_PATTERN(mxcnd_do_exec_op,
> > > > > +			       NAND_OP_PARSER_PAT_CMD_ELEM(false),
> > > > > +			       NAND_OP_PARSER_PAT_ADDR_ELEM(true, 7),
> > > > > +			       NAND_OP_PARSER_PAT_CMD_ELEM(true),
> > > > > +			       NAND_OP_PARSER_PAT_WAITRDY_ELEM(true),
> > > > > +			       NAND_OP_PARSER_PAT_DATA_IN_ELEM(true, MAX_DATA_SIZE)),=
   =20
> > > >=20
> > > > CMD, ADDR, CMD, DATA is the RNDOUT pattern. So it is now working fi=
ne?   =20
> > >=20
> > > Yes, RNDOUT is working now. =20
> >=20
> > Excellent!
> >  =20
> > > > Or did you forget to adapt the patterns to your use case?   =20
> > >=20
> > > Although it looks like the patterns from the pl35x-nand-controller.c,
> > > there is one slight difference. The 'false' in the NAND_OP_PARSER_PAT=
_CMD_ELEM
> > > above has the effect that a plain NAND_OP_PARSER_PAT_DATA_IN_ELEM is
> > > disallowed. =20
> >=20
> > I'm not sure I follow, the above pattern means: a single command cycle
> > is supported, no? =20
>=20
> A single command cycle indeed is and shall be supported. The
> pl35x-nand-controller.c I copied this from has
> NAND_OP_PARSER_PAT_CMD_ELEM(true). With all elements being optional this
> also allows a single NAND_OP_PARSER_PAT_DATA_IN_ELEM()
> (supported_op.data_only_read becomes true). I can't support that, so I
> made the CMD mandatory.

Alright, yeah. Ack.

Thanks,
Miqu=C3=A8l