Received-SPF: pass (google.com: domain of linux-kernel+bounces-181178-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 16 May 2024 10:40:29 -0400
From: Frank Li <Frank.li@nxp.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: linus.walleij@linaro.org, sudeep.holla@arm.com,
	cristian.marussi@arm.com, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, festevam@gmail.com,
	imx@lists.linux.dev, aisheng.dong@nxp.com,
	Peng Fan <peng.fan@nxp.com>
Subject: Re: [RFC] dt-bindings: firmware: arm,scmi: Add properties for i.MX95
 Pinctrl OEM extensions
Message-ID: <ZkYa3VAsLYkxhWP7@lizhi-Precision-Tower-5810>
References: <20240516073012.1699795-1-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240516073012.1699795-1-peng.fan@oss.nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?GmB239OshfvCJrxvPLG0ri5HRzMKPmCYk715h5pL4vLSec9x1jo5AjxniELN?=
 =?us-ascii?Q?MapbLlYkDAeLdcS58KMjlzXAqOqgZKd8je+OLrI/ZUErz6oLHLaiiCjqplZR?=
 =?us-ascii?Q?Kbr3/P6te6pr6exHBxu5hdfQ1W9BAySTi828aBI394iuUYmQ7E1I0k284UFi?=
 =?us-ascii?Q?7ZbLdaTBWhP7p28BCU35zj9sg/cKoIyKGO5xroeM6dyjrybJKS3c7GzRr25Q?=
 =?us-ascii?Q?GGysud6kgW06YXlX56AatxQdfeaZovZRs5/DQXyXKa6gaD4EIKKfKfWmg39H?=
 =?us-ascii?Q?rwNPE9Lwo32dYPE8OQ0jIgi2dP03UUR4wNhE1lRgpeOTZpgVhWgN4GXCqTE0?=
 =?us-ascii?Q?Qx6KEzY6xwma6qt4DTdgLhjSduiduHeo9RW6yBMGeoCx9S41VPrQqzzs9iO+?=
 =?us-ascii?Q?91LZPCuCfubcco0HIIA6IK61Jp4uR/s8npxAajai7dmB6xGbTiVAP9bD/6Zd?=
 =?us-ascii?Q?wKFQr6yUFFCE9DxxnPssWilOUE6i6KfTRF7tI5UWbF7oaGip4SNWdAUtLKP5?=
 =?us-ascii?Q?+DFpeaJFgoglll3EjI/Ne5ErHVsECXDd/iLbh9BzJ6kavatohW1pn0XMHl38?=
 =?us-ascii?Q?+J6YewsJIqAp7T42YIJwFlluyPWNIRwpIUCd+F5Hq3z2FOTn91AgdfBXNgod?=
 =?us-ascii?Q?CRBSJsK4YiKw2koFgSgERCvANkuB7GcCUZjgzl10wc8SU5ZDO84te9gXiq55?=
 =?us-ascii?Q?NjS9qWMkLuqIo2xFLDOH7hg5IDmyvblr/joGUzSmy+0dJHBkSlSrfSfAGqgH?=
 =?us-ascii?Q?Pqea4hMpD8ZXAWcwEYEMSWAVPJDlqJ358H92OuKyJj1pJNc/50c3SFohtj5D?=
 =?us-ascii?Q?V2JGOQO8EQlgDx0Gzss52ZEeve5vL5zm2JoIhTVZMyNMryFb6HcCT+ubnjCn?=
 =?us-ascii?Q?Jf5+Iwhe6DDby3Z9TuEBj4PKoExpTMgcqtmRNpQDXQz00DZMQ/B2UC0etm+b?=
 =?us-ascii?Q?cTXHX1VIW4iOclfNQDCV8ONzdAvXXeMolIYCR8SogGJN8EwIijuqRPANP6qA?=
 =?us-ascii?Q?b5x4tO6N9zDT212R+BJyV6WsfywgEe63dtBdfbL2tigQiS6TgD6igaK1F7x7?=
 =?us-ascii?Q?qUCS4rm0CczEevPjcGzkt3ZeIaqLVxc51XSSpOOYwVWlA471o5VhVOg1soa4?=
 =?us-ascii?Q?u5YNPWzh3ZAMLp0owI/C2zlxZLLQwwlOJUqB6eMHGnNhbkPd/XlWjFlTEOs0?=
 =?us-ascii?Q?6loyUSUbJ7fYetUxK1WIvbWL493vlfLoqUTmwAY/xF35R4JWH29Bleq9wv3f?=
 =?us-ascii?Q?RVg1gGemc8pbULQCC94MntlGCnl06JqSDOZgCXGp8eauxNxRv742++lwGCys?=
 =?us-ascii?Q?BDn20DhQHpXqalVEPXrf4dw2DOztN7/DLQuz4QEbj/mn1Nh4BjbtXME+4Tt3?=
 =?us-ascii?Q?O/2ivUr9iLPZn2zBI8SqQh+Aurg3zQP9bycPwcMgSlh/s64PY0Kvzbtarrl5?=
 =?us-ascii?Q?NroPm3P+SQ9aoV0IlaqTeoTaWx7HfaeIn3yyrETlqiWnvfWdEXFFjeaBr0fn?=
 =?us-ascii?Q?Hf4Fpdn4FNDM6c9LJMvCX4JsoSWpIU5amXNC05t4rN4oc+jt+Tm/+Rr0Ahl4?=
 =?us-ascii?Q?oPwwy5KDR0nZc3s0Af1sKajCWvOnY9Hn1j6uaDIg?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 319a3b84-cf3d-4813-8e8e-08dc75b627a9
X-MS-Exchange-CrossTenant-AuthSource: AS4PR04MB9621.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 14:40:39.2800
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u4CDoTP0xti5gCaAlkkmffDb1AlxSDoEyxF6KWz8d3g2h4MFoky5y94ody+tFl9iOtDr495rIF6AULEalVHQaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8304

On Thu, May 16, 2024 at 03:30:12PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> i.MX95 Pinctrl is managed by System Control Management Interface(SCMI)
> firmware using OEM extensions. No functions, no groups are provided by
> the firmware. So add i.MX95 specific properties.
> 
> To keep aligned with current i.MX pinctrl bindings, still use "fsl,pins"
> for i.MX95.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> 
> V1:
>  There is already a v6 version for i.MX95 pinctrl with binding got reviewed by
>  Rob, https://lore.kernel.org/all/20240513-pinctrl-scmi-oem-v3-v6-1-904975c99cc4@nxp.com/
>  But after NXP internal discussion, to keep "fsl,pins" for i.MX95 would make
>  it aligned with current i.MX93/8M/7 bindings which people are familiar with,
>  and easy to understand.
> 
>  Sorry to bring back so late after your reviewing in previous generic binding
>  patch. This is not to reject the v6 patch, just wanna to see whether you are
>  happy with "fsl,pins" for i.MX95. If people are happy to accept, I will post
>  out driver together with this patch in new patchset to reject v6. If people are
>  not happy, we could continue with v6.
> 
>  v6: https://lore.kernel.org/all/20240513-pinctrl-scmi-oem-v3-v6-0-904975c99cc4@nxp.com/
> 
>  Thanks,
>  Peng
> 
>  .../bindings/firmware/arm,scmi.yaml           |  4 +-
>  .../firmware/nxp,imx95-scmi-pinctrl.yaml      | 54 +++++++++++++++++++
>  2 files changed, 57 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/firmware/nxp,imx95-scmi-pinctrl.yaml
> 
> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> index 7de2c29606e5..f7a48b1e9f62 100644
> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> @@ -251,7 +251,9 @@ properties:
>      type: object
>      allOf:
>        - $ref: '#/$defs/protocol-node'
> -      - $ref: /schemas/pinctrl/pinctrl.yaml
> +      - anyOf:
> +          - $ref: /schemas/pinctrl/pinctrl.yaml
> +          - $ref: /schemas/firmware/nxp,imx95-scmi-pinctrl.yaml
>  
>      unevaluatedProperties: false
>  
> diff --git a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi-pinctrl.yaml b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi-pinctrl.yaml
> new file mode 100644
> index 000000000000..3f28c4a171c7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi-pinctrl.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright 2024 NXP
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/firmware/nxp,imx95-scmi-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: i.MX System Control and Management Interface (SCMI) Pinctrl Protocol
> +
> +maintainers:
> +  - Peng Fan <peng.fan@nxp.com>
> +
> +allOf:
> +  - $ref: /schemas/pinctrl/pinctrl.yaml
> +
> +patternProperties:
> +  'grp$':
> +    type: object
> +    description:
> +      Pinctrl node's client devices use subnodes for desired pin configuration.
> +      Client device subnodes use below standard properties.
> +
> +    unevaluatedProperties: false
> +
> +    properties:
> +      fsl,pins:
> +        description:
> +          each entry consists of 6 integers and represents the mux and config
> +          setting for one pin. The first 5 integers <mux_reg conf_reg input_reg
> +          mux_val input_val> are specified using a PIN_FUNC_ID macro, which can
> +          be found in <arch/arm64/boot/dts/freescale/imx95-pinfunc.h>. The last
> +          integer CONFIG is the pad setting value like pull-up on this pin. Please
> +          refer to i.MX8M Plus Reference Manual for detailed CONFIG settings.
> +        $ref: /schemas/types.yaml#/definitions/uint32-matrix
> +        items:
> +          items:
> +            - description: |

needn't "|" 

Frank

> +                "mux_reg" indicates the offset of mux register.
> +            - description: |
> +                "conf_reg" indicates the offset of pad configuration register.
> +            - description: |
> +                "input_reg" indicates the offset of select input register.
> +            - description: |
> +                "mux_val" indicates the mux value to be applied.
> +            - description: |
> +                "input_val" indicates the select input value to be applied.
> +            - description: |
> +                "pad_setting" indicates the pad configuration value to be applied.
> +
> +
> +    required:
> +      - fsl,pins
> +
> +additionalProperties: true
> -- 
> 2.37.1
>