Received-SPF: pass (google.com: domain of linux-kernel+bounces-181186-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 16 May 2024 10:49:50 -0400
From: Frank Li <Frank.li@nxp.com>
To: linux@treblig.org
Cc: vkoul@kernel.org, linux-arm-msm@vger.kernel.org,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: qcom: gpi: remove unused struct 'gpi_desc'
Message-ID: <ZkYdDtoPMnYlGT/6@lizhi-Precision-Tower-5810>
References: <20240516133211.251205-1-linux@treblig.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240516133211.251205-1-linux@treblig.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?zgoDohbwwe6ktFdmMVpe6YM5SB+R0ohHcmjjSymsVbZ+1aNDvHFuU/VddONx?=
 =?us-ascii?Q?9dOiwEsXU6I1dChgnQ2u96/LwsTm+rYYYpCcVJySu2HEatcSdjVpAX/q3jFI?=
 =?us-ascii?Q?qUZdOFdagaG6lPx1kbYVTqeD+To7I0rTvvagf+3b5edbcN6d/bYu66iKTF8S?=
 =?us-ascii?Q?USg/1ETODAG6sQywN81IfnNdNcLsq2h+Zvea234aIdZ4wUV/AaaJNNcYIPHA?=
 =?us-ascii?Q?8kPz8OCk0F1SYMjDfCmbTPzE5QmjOWl/dnkCz0cYUCM7Od6phVXBEaemWKf/?=
 =?us-ascii?Q?r+DVJ84iDH54hJPD6yb5408eNlzWG2FDTU7x9/QLKpuGOlsuVrdaMgBUOd8z?=
 =?us-ascii?Q?GX0H9KuK3y15YzFCIA3f2uA8HdJoozg9zi3uY/S6TDA5HY1tJuFAEGBHk6n0?=
 =?us-ascii?Q?ctPngKlpRFk2fZUPR+qxV90LrSqpuWUYdpjEmlEcDz3IzUSyQ8C8JOsc0gFJ?=
 =?us-ascii?Q?Ky8hKNKoCvRqArq2xKEG49OP44YZ2/PkTHCHosv/MhlYkD/rOnDHiGwlia/r?=
 =?us-ascii?Q?TS/sPJsSln0WR/5vVjf/QQnzAYdiBtV5udkq2zzaziF5XGduIx07+TbcydAZ?=
 =?us-ascii?Q?aticbuxyKuNiJbYr1p9lC4IL3BVfJpEG+mutHPOoa0u/YrVmu5dkzdtMFC7N?=
 =?us-ascii?Q?kXw6aX9rCixyg381KwTAQK56/WXLzniMApAqn5uXz+e4qRS+N8kBcZzK5Qc6?=
 =?us-ascii?Q?S4YAOVyMsHHg5VSazfBsenSQxpAGSlsjaN+k872RVEXw6B2RrZF3FN4MVLvC?=
 =?us-ascii?Q?Y2cVhZcajuRKRWqvYQjrokzj5YrCX3a5UUWDKF+JWoNGt58v8rdcMtueQ1fd?=
 =?us-ascii?Q?n1PQPZ6U/ngb4ifYcjGMUtW2Y3biA/2MRjGZV0wMhk82nWmHaSIONMpWO7bS?=
 =?us-ascii?Q?FhmtJ9k+sxmJ5ZExd1u9A3PrXK8i3vdL4SNAom2KUQW7xvwmXDYhmXZku1W1?=
 =?us-ascii?Q?1aUn49OgbieH6XqExnBF+8Zf40TyMO+A8vvAE0VZbImb5n8TcKHTzH9L7Bmk?=
 =?us-ascii?Q?hqWRrPDq/hdL2hokKDnsQi4MXDCFCU4ZP5s0eS59eqhXdKfoMe1d3V7k3zNW?=
 =?us-ascii?Q?7czZSgiwnCby/II+8v1+L0EXihIBWqHcweSqW2d9s2R+jcAnibSOrbD5xmP2?=
 =?us-ascii?Q?UugoIMfLH+4PJp9APJHPpVkJgk7es0L7wXFxCv5wCYalP44c7L+zDGkMaD6r?=
 =?us-ascii?Q?XB9RcC7qPbz0X1c/1U48j1/AmhBnM6HfkopTQ5Bl3kYk903TG+BY2Rc0+Vta?=
 =?us-ascii?Q?XZ1XB14IXcUEV4zhoxcCYbf4sPMle/pR9AkjrkMYBohD99lYomm7kJzhh/ib?=
 =?us-ascii?Q?tSCv20A1tGvrAW4S+pINqy5Y6gMbWmwmwgG969yYjNyaUkmotm9MKHecJteq?=
 =?us-ascii?Q?VxkLdskWc06i/TSw/Kbkaxe5p4c+K8eFVWiiA7XBelEHzRZCcrZEAZFbUURE?=
 =?us-ascii?Q?dpqN0KeySAtffH4U+2wphjX8Q9ZCVJN6bv8hfXLKXgNrWQwteWzZM3d3g+4a?=
 =?us-ascii?Q?ltcY6xdgX/fjKhNMHt5rXsIctjq4hg7f39k2STyPXcAJrQH1KbZyp17GPXZD?=
 =?us-ascii?Q?bVND92yxyNVCxKNJPAwwzgFDscbagarAqy204Lrq?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca973929-c362-407c-9a29-08dc75b77485
X-MS-Exchange-CrossTenant-AuthSource: AS4PR04MB9621.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 14:49:57.4818
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mdsWCBpqENSlclmBQbHMVMJ9qxNET2pvYiyazLSFDyMmhsiAM44n6dnv6UlmjHNKopo+iykQ+K3fBBsxEslRcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7862

On Thu, May 16, 2024 at 02:32:11PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'gpi_desc' seems like it was never used.
> Remove it.

code change show 'reg_info', not 'gpi_desc'. You need make sure that it
really is not used, not "seems like".

'struct reg_info' is never used, so remove it.

> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/dma/qcom/gpi.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index 1c93864e0e4d..639ab304db9b 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -476,12 +476,6 @@ struct gpi_dev {
>  	struct gpii *gpiis;
>  };
>  
> -struct reg_info {
> -	char *name;
> -	u32 offset;
> -	u32 val;
> -};
> -
>  struct gchan {
>  	struct virt_dma_chan vc;
>  	u32 chid;
> -- 
> 2.45.0
>