Received-SPF: pass (google.com: domain of linux-kernel+bounces-181194-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <7bb8376a-ddad-4acb-b862-fd553b400c32@amd.com>
Date: Thu, 16 May 2024 08:01:39 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH iwl-next v9] ice: Add get/set hw address for VFs using
 devlink commands
To: "Keller, Jacob E" <jacob.e.keller@intel.com>,
 Karthik Sundaravel <ksundara@redhat.com>,
 "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
 "Drewek, Wojciech" <wojciech.drewek@intel.com>,
 "sumang@marvell.com" <sumang@marvell.com>,
 "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
 "davem@davemloft.net" <davem@davemloft.net>,
 "edumazet@google.com" <edumazet@google.com>,
 "kuba@kernel.org" <kuba@kernel.org>, "pabeni@redhat.com"
 <pabeni@redhat.com>,
 "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
 "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "horms@kernel.org" <horms@kernel.org>
Cc: "pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>,
 "jiri@resnulli.us" <jiri@resnulli.us>,
 "michal.swiatkowski@linux.intel.com" <michal.swiatkowski@linux.intel.com>,
 "rjarry@redhat.com" <rjarry@redhat.com>,
 "aharivel@redhat.com" <aharivel@redhat.com>,
 "vchundur@redhat.com" <vchundur@redhat.com>,
 "cfontain@redhat.com" <cfontain@redhat.com>
References: <20240515142207.27369-1-ksundara@redhat.com>
 <20240515142207.27369-2-ksundara@redhat.com>
 <26b64d11-9cd2-4e60-b7ce-be2dea0f2caa@amd.com>
 <CO1PR11MB508932F90216EED30FCEAF8CD6EC2@CO1PR11MB5089.namprd11.prod.outlook.com>
Content-Language: en-US
From: Brett Creeley <bcreeley@amd.com>
In-Reply-To: <CO1PR11MB508932F90216EED30FCEAF8CD6EC2@CO1PR11MB5089.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RlRHd3diVGhMd3lwZVZiYWtxempkSFg2TzFsVWZ3cCs2TVdlODM1a3lLa3k2?=
 =?utf-8?B?aGlPRUx4S3NlcThEVHYvTnc2bWZObG5XeVVSb2szb3EzOFloTXR2Vi81N24w?=
 =?utf-8?B?VUhZNzZmeWFwd2ExbXA3aCt5eXF1VGJwK25vY2lmUHhzdHRKMnVyM1hpNTV6?=
 =?utf-8?B?TUVHVGxhN2JRdXdiSlVDUFZicjRxSmVPbElicmc0Zm5qZHI3S0w2QVVKN0FR?=
 =?utf-8?B?eUlaanlYaVNjbkxyMHpCbi8ydHdNVDZNVlI4YUFkTnRvZHNHV2o2eGwrRVNO?=
 =?utf-8?B?blh5RzFScUpjblNRL3BSTmltWTZBQW5JZ1NhNkVrRWc1OWFTV0xmOGFjZWZY?=
 =?utf-8?B?THoybU1EQUN5SlFuQlFxZ2tpQU1xSHZQV0JZZm0zdXVvVEhvV2NkNUNPelRZ?=
 =?utf-8?B?cW1Sa1B3RmF1L2tVL2Z0TEFIT1dSUmcvT1NlZ1J3L1JKaG1ndFFBUTJUMUNN?=
 =?utf-8?B?dVNUOFFxVXRBSDJwaU5xVDQ5UmsxV05Sd2NOMVo2MjQzSU50SDJrSnZiamhY?=
 =?utf-8?B?NE5aUm5QUll0SVJkL0pUVHVrYlJjeldnNHg0YUowVTU4cnBqYjFqSVhpR2JP?=
 =?utf-8?B?YmlMREJ2R1hRaU1iVGNwMEI1TVFTMFh3STNrQ3Y3S01kdTJ4dVJSRXhsN21n?=
 =?utf-8?B?TVF3RXRMS2xOaklBQU5FUWlyL2dNak9jVWo4OEdva2pCTHVzOTdmMXB2UXdV?=
 =?utf-8?B?Q1JSVzIvdGFGNXJ4a0lTV0E5Z1BWcVRCc0kzejdNenhDRnFOcTRQOCtTV1pM?=
 =?utf-8?B?OElmVC93K2h5dDZtSFFscjlpWndPUUxLbGdFM2F1akJaRC9kcStBdEpjT2Fh?=
 =?utf-8?B?TWk1Z1AxR0RwRUNKeEtvZ0E2RmR0YWFpRjRmNmRQN0RqOUNTeGgzQklGZ3Vm?=
 =?utf-8?B?d2NnNnZTb3F1RkhDcTBvVXNkRDVsaWMwa01kK3B2YkNYcXFKTFdaU1RrTHdI?=
 =?utf-8?B?KzVEQi9wVmp4M3VMMUdUQ3VrUDg1MTR5YWdPWVJKaUxQYWFROXAxbjI3WlVQ?=
 =?utf-8?B?eG8yUGlLb3B0SEpWUFdlK252VjlOVjVpK282dTNUTXFKR1k3eVBheWUySmNk?=
 =?utf-8?B?NDdVK0F4UkJvZmhTMWVUaDlIYitUWmRMeUtRalU4L0tkbkJxbHJDTVA1MGZO?=
 =?utf-8?B?VmJaZXZjQlpOemphbkh2WFRPa0tqZmJYcE8zRENOL09hSnNnOFlBQWFKN09Q?=
 =?utf-8?B?SHVCbHQ5eFFWZFJnVHRGdSt5MTl1VjZTYnR4RjVqRm8xOFk5MVd3bG8zd3Y5?=
 =?utf-8?B?T0c3R25EKy9tdzM0VTZwZTJxc0pqNnptUGJQSHVYeitBbzRkbGlpZ25rMVlO?=
 =?utf-8?B?NlJLb1RqR2RoeXFBdUFqKzhxTWlYRCtpVXgzWlUvTWdscjFZb3IvRXpUcFdi?=
 =?utf-8?B?dStUNzU5aWREVzRyeFMzZmkvVWNPcDc3K3dHek5lMW5tVjhvQTNOeXFMN2dx?=
 =?utf-8?B?Z0RhMVFjaDhHWG13cTd1bktib0tzNU1ycWNHN29tbFhCc2l0OFRsbEFWcG0v?=
 =?utf-8?B?M2hmQzdOaVhqS1ZhWmpUbkp5azkvbzBrVFVyT3ZFV20rbmRxRGlSZWFyTE9P?=
 =?utf-8?B?OFJPL3pxTXFINHhSamFzVG5TRnJxUWJHRDVwSnF3Nm45dlhlMEF0eldKNURw?=
 =?utf-8?B?MEtILzFqdWFac2tMMDY1ZnltdEYxMUh4Q0hyK2RJNUU0RWd3Nk43NGEvdnhs?=
 =?utf-8?B?bXcyaHg2UDdrWHloR3I1dFBwc0FPbEkvSDZZcURlM1ZRRFJUSVhXTDhNUk1N?=
 =?utf-8?B?SDlselJIS043Z2FlYnJ5V0JXRkkwTWlTTno4VjdrRVpFa0QxV0hXQVRUUEtB?=
 =?utf-8?B?cUsyam8rSXVLMy9XWnpwN2g5eHZKR2l0dkpHSkp1N2crZUtUaU8rSkZqZUsz?=
 =?utf-8?B?VmhxczhsSTY4NHRWdEdVVTNxanR2U2NpdW0vcHJTSVYwSk9SZW9NTDJDTlgw?=
 =?utf-8?B?eklvT091SW5pN2lGNFVyRVVUcEhOMXY5aThDcHlDalMreXNaZm15WXVSdjJt?=
 =?utf-8?B?cWdBK2FPOWNlMGlPSWVaTitlNDFBdlZBQzJ3cWdXcm1CTkhkTUZMVVZwWFlY?=
 =?utf-8?B?MDhMTnJRRVljSURXRnlTQlV0dWs0a1hlVnNRU2F4eHpPQmx6NzhIT0hYanJr?=
 =?utf-8?Q?iSiDRW2reYQ9JHV8Qqa7mMaPv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a2384bd-4960-4187-ce91-08dc75b9188c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB7982.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 15:01:42.2777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VR0B3XdMciRGRK82/lINJa5vsBPg/q0azPHC1NmvUdJkq/wXowns/7ZXv620owU7fNbrgyMKOgCIVhFIxQJYcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7952


On 5/15/2024 2:21 PM, Keller, Jacob E wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
>> -----Original Message-----
>> From: Brett Creeley <bcreeley@amd.com>
>> Sent: Wednesday, May 15, 2024 9:53 AM
>> To: Karthik Sundaravel <ksundara@redhat.com>; Brandeburg, Jesse
>> <jesse.brandeburg@intel.com>; Drewek, Wojciech <wojciech.drewek@intel.com>;
>> sumang@marvell.com; Keller, Jacob E <jacob.e.keller@intel.com>; Nguyen,
>> Anthony L <anthony.l.nguyen@intel.com>; davem@davemloft.net;
>> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; intel-wired-
>> lan@lists.osuosl.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
>> horms@kernel.org
>> Cc: pmenzel@molgen.mpg.de; jiri@resnulli.us;
>> michal.swiatkowski@linux.intel.com; rjarry@redhat.com; aharivel@redhat.com;
>> vchundur@redhat.com; cfontain@redhat.com
>> Subject: Re: [PATCH iwl-next v9] ice: Add get/set hw address for VFs using devlink
>> commands
>>
>>
>>
>> On 5/15/2024 7:22 AM, Karthik Sundaravel wrote:
>>> Caution: This message originated from an External Source. Use proper caution
>> when opening attachments, clicking links, or responding.
>>>
>>>
>>> Changing the MAC address of the VFs is currently unsupported via devlink.
>>> Add the function handlers to set and get the HW address for the VFs.
>>>
>>> Signed-off-by: Karthik Sundaravel <ksundara@redhat.com>
>>> ---
>>>    .../ethernet/intel/ice/devlink/devlink_port.c | 59 +++++++++++++++++-
>>>    drivers/net/ethernet/intel/ice/ice_sriov.c    | 62 +++++++++++++++++++
>>>    drivers/net/ethernet/intel/ice/ice_sriov.h    |  8 +++
>>>    3 files changed, 128 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink_port.c
>> b/drivers/net/ethernet/intel/ice/devlink/devlink_port.c
>>> index c9fbeebf7fb9..6ff7cba3f630 100644
>>> --- a/drivers/net/ethernet/intel/ice/devlink/devlink_port.c
>>> +++ b/drivers/net/ethernet/intel/ice/devlink/devlink_port.c
>>> @@ -372,6 +372,62 @@ void ice_devlink_destroy_pf_port(struct ice_pf *pf)
>>>           devl_port_unregister(&pf->devlink_port);
>>>    }
>>>
>>> +/**
>>> + * ice_devlink_port_get_vf_fn_mac - .port_fn_hw_addr_get devlink handler
>>> + * @port: devlink port structure
>>> + * @hw_addr: MAC address of the port
>>> + * @hw_addr_len: length of MAC address
>>> + * @extack: extended netdev ack structure
>>> + *
>>> + * Callback for the devlink .port_fn_hw_addr_get operation
>>> + * Return: zero on success or an error code on failure.
>>> + */
>>> +static int ice_devlink_port_get_vf_fn_mac(struct devlink_port *port,
>>> +                                         u8 *hw_addr, int *hw_addr_len,
>>> +                                         struct netlink_ext_ack *extack)
>>> +{
>>> +       struct ice_vf *vf = container_of(port, struct ice_vf, devlink_port);
>>> +
>>> +       ether_addr_copy(hw_addr, vf->dev_lan_addr);
>>> +       *hw_addr_len = ETH_ALEN;
>>> +
>>> +       return 0;
>>> +}
>>> +
>>> +/**
>>> + * ice_devlink_port_set_vf_fn_mac - .port_fn_hw_addr_set devlink handler
>>> + * @port: devlink port structure
>>> + * @hw_addr: MAC address of the port
>>> + * @hw_addr_len: length of MAC address
>>> + * @extack: extended netdev ack structure
>>> + *
>>> + * Callback for the devlink .port_fn_hw_addr_set operation
>>> + * Return: zero on success or an error code on failure.
>>> + */
>>> +static int ice_devlink_port_set_vf_fn_mac(struct devlink_port *port,
>>> +                                         const u8 *hw_addr,
>>> +                                         int hw_addr_len,
>>> +                                         struct netlink_ext_ack *extack)
>>> +
>>> +{
>>> +       struct devlink_port_attrs *attrs = &port->attrs;
>>> +       struct devlink_port_pci_vf_attrs *pci_vf;
>>> +       struct devlink *devlink = port->devlink;
>>> +       struct ice_pf *pf;
>>> +       u16 vf_id;
>>> +
>>> +       pf = devlink_priv(devlink);
>>> +       pci_vf = &attrs->pci_vf;
>>> +       vf_id = pci_vf->vf;
>>> +
>>> +       return ice_set_vf_fn_mac(pf, vf_id, hw_addr);
>>
>> Instead of creating a duplicate function, it seems like you can do the
>> following instead:
>>
>> pf = devlink_priv(devlink);
>> vsi = ice_get_main_vsi(pf);
>> if (!vsi)
>>        return -ENODEV;
>>
>> [...]
>>
>> return ice_set_vf_mac(vsi->netdev, vf_id, hw_addr);
>>
>>> +}
>>> +
>>> +static const struct devlink_port_ops ice_devlink_vf_port_ops = {
>>> +       .port_fn_hw_addr_get = ice_devlink_port_get_vf_fn_mac,
>>> +       .port_fn_hw_addr_set = ice_devlink_port_set_vf_fn_mac,
>>> +};
>>> +
>>>    /**
>>>     * ice_devlink_create_vf_port - Create a devlink port for this VF
>>>     * @vf: the VF to create a port for
>>> @@ -407,7 +463,8 @@ int ice_devlink_create_vf_port(struct ice_vf *vf)
>>>           devlink_port_attrs_set(devlink_port, &attrs);
>>>           devlink = priv_to_devlink(pf);
>>>
>>> -       err = devl_port_register(devlink, devlink_port, vsi->idx);
>>> +       err = devl_port_register_with_ops(devlink, devlink_port, vsi->idx,
>>> +                                         &ice_devlink_vf_port_ops);
>>>           if (err) {
>>>                   dev_err(dev, "Failed to create devlink port for VF %d, error %d\n",
>>>                           vf->vf_id, err);
>>> diff --git a/drivers/net/ethernet/intel/ice/ice_sriov.c
>> b/drivers/net/ethernet/intel/ice/ice_sriov.c
>>> index 067712f4923f..dc40be741be0 100644
>>> --- a/drivers/net/ethernet/intel/ice/ice_sriov.c
>>> +++ b/drivers/net/ethernet/intel/ice/ice_sriov.c
>>> @@ -1415,6 +1415,68 @@ ice_get_vf_cfg(struct net_device *netdev, int vf_id,
>> struct ifla_vf_info *ivi)
>>>           return ret;
>>>    }
>>>
>>> +/**
>>> + * ice_set_vf_fn_mac
>>> + * @pf: PF to be configure
>>> + * @vf_id: VF identifier
>>> + * @mac: MAC address
>>> + *
>>> + * program VF MAC address
>>> + */
>>> +int ice_set_vf_fn_mac(struct ice_pf *pf, u16 vf_id, const u8 *mac)
>>> +{
>>> +       struct device *dev;
>>> +       struct ice_vf *vf;
>>> +       int ret;
>>> +
>>> +       dev = ice_pf_to_dev(pf);
>>> +       if (is_multicast_ether_addr(mac)) {
>>> +               dev_err(dev, "%pM not a valid unicast address\n", mac);
>>> +               return -EINVAL;
>>> +       }
>>> +
>>> +       vf = ice_get_vf_by_id(pf, vf_id);
>>> +       if (!vf)
>>> +               return -EINVAL;
>>> +
>>> +       /* nothing left to do, unicast MAC already set */
>>> +       if (ether_addr_equal(vf->dev_lan_addr, mac) &&
>>> +           ether_addr_equal(vf->hw_lan_addr, mac)) {
>>> +               ret = 0;
>>> +               goto out_put_vf;
>>> +       }
>>> +
>>> +       ret = ice_check_vf_ready_for_cfg(vf);
>>> +       if (ret)
>>> +               goto out_put_vf;
>>> +
>>> +       mutex_lock(&vf->cfg_lock);
>>> +
>>> +       /* VF is notified of its new MAC via the PF's response to the
>>> +        * VIRTCHNL_OP_GET_VF_RESOURCES message after the VF has been reset
>>> +        */
>>> +       ether_addr_copy(vf->dev_lan_addr, mac);
>>> +       ether_addr_copy(vf->hw_lan_addr, mac);
>>> +       if (is_zero_ether_addr(mac)) {
>>> +               /* VF will send VIRTCHNL_OP_ADD_ETH_ADDR message with its MAC */
>>> +               vf->pf_set_mac = false;
>>> +               dev_info(dev, "Removing MAC on VF %d. VF driver will be
>> reinitialized\n",
>>> +                        vf->vf_id);
>>> +       } else {
>>> +               /* PF will add MAC rule for the VF */
>>> +               vf->pf_set_mac = true;
>>> +               dev_info(dev, "Setting MAC %pM on VF %d. VF driver will be
>> reinitialized\n",
>>> +                        mac, vf_id);
>>> +       }
>>> +
>>> +       ice_reset_vf(vf, ICE_VF_RESET_NOTIFY);
>>> +       mutex_unlock(&vf->cfg_lock);
>>> +
>>> +out_put_vf:
>>> +       ice_put_vf(vf);
>>> +       return ret;
>>> +}
>>
>> This is almost an exact copy of ice_set_vf_mac(). The only difference
>> being the function arguments.
>>
>> Was there any reason to not use ice_set_vf_mac()? Why can't you pass the
>> PF's netdev?
>>
> 
> Or, refactor the set_vf_mac() into a function into a common one which takes a common set of arguments that can be derived in both the netdev op and devlink flow?

Yeah that's probably the best approach. Maybe someting like the 
following makes the most sense?

__ice_set_vf_mac(struct ice_pf *pf, u16 vf_id, const u8 *mac);

For the netdev_op it's:

return __ice_set_vf_mac(ice_netdev_to_pf(netdev), vf_id, mac);

For the devlink op it's:

pf = devlink_priv(devlink);
pci_vf = &attrs->pci_vf;
vf_id = pci_vf->vf;

return __ice_set_vf_mac(pf, vf_id, mac);

Regardless duplicating the entire function is not the correct approach.

Thanks,

Brett