Received-SPF: pass (google.com: domain of linux-kernel+bounces-181212-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 16 May 2024 08:11:10 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: "Lena Wang (=?UTF-8?B?546L5aic?=)" <Lena.Wang@mediatek.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Shiming
 Cheng (=?UTF-8?B?5oiQ6K+X5piO?=)" <Shiming.Cheng@mediatek.com>,
 "pabeni@redhat.com" <pabeni@redhat.com>, "edumazet@google.com"
 <edumazet@google.com>, "willemdebruijn.kernel@gmail.com"
 <willemdebruijn.kernel@gmail.com>, "netdev@vger.kernel.org"
 <netdev@vger.kernel.org>, "matthias.bgg@gmail.com"
 <matthias.bgg@gmail.com>, "davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH net] net: prevent pulling SKB_GSO_FRAGLIST skb
Message-ID: <20240516081110.362cbb51@kernel.org>
In-Reply-To: <bc69f8cc4aed8b16daba17c0ca0199fe6d7d24a8.camel@mediatek.com>
References: <20240428142913.18666-1-shiming.cheng@mediatek.com>
	<20240429064209.5ce59350@kernel.org>
	<bc69f8cc4aed8b16daba17c0ca0199fe6d7d24a8.camel@mediatek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, 15 May 2024 09:02:35 +0000 Lena Wang (=E7=8E=8B=E5=A8=9C) wrote:
> > One of the fixes you posted breaks the
> >=20
> >   tools/testing/selftests/net/udpgro_fwd.sh
> >=20
> > selftest. Please investigate, and either adjust the test or the fix. =20
>=20
> Dear Jakub,
> Sorry for late response.
> As we do not make selftest before, I try to build a test environmen and
> cost time to apply sudo access right in our company server.

Please read:
https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-st=
yle

Depending on your setup sudo may not be needed.

> Now it blocks to generate xdp_dummy.bpf.o. Could you please give some gui=
dline
> about the script test step? Thanks.

Install clang and run make? Please share some outputs or more details,
I'm not sure what the problem is

> Could you give more info about the failed situation? =20
> Is it this fix "[PATCH net] net: prevent pulling SKB_GSO_FRAGLIST skb"
> failed?
> Which case is failed?

These are the results, as far as I can tell:

https://netdev-3.bots.linux.dev/vmksft-net/results/573200/24-udpgro-fwd-sh/

> Is it possible that the test case has issue?

Entirely possible, yes.