Received-SPF: pass (google.com: domain of linux-kernel+bounces-181246-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 16 May 2024 15:28:41 +0000
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Frank Li <Frank.li@nxp.com>
Cc: vkoul@kernel.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: moxart-dma: remove unused struct
 'moxart_filter_data'
Message-ID: <ZkYmKVQ5NRwgSA53@gallifrey>
References: <20240516133250.251252-1-linux@treblig.org>
 <ZkYeE2SgzCFDqKs2@lizhi-Precision-Tower-5810>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <ZkYeE2SgzCFDqKs2@lizhi-Precision-Tower-5810>
User-Agent: Mutt/2.2.12 (2023-09-09)

* Frank Li (Frank.li@nxp.com) wrote:
> On Thu, May 16, 2024 at 02:32:50PM +0100, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'moxart_filter_data' never appears to have been used.
> > Remove it.
> 
> You can duplicate subject.
> 
> Remove unused struct moxart_filter_data.

V2 sent.

Dave

> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  drivers/dma/moxart-dma.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
> > index c48d68cbff92..66dc6d31b603 100644
> > --- a/drivers/dma/moxart-dma.c
> > +++ b/drivers/dma/moxart-dma.c
> > @@ -148,11 +148,6 @@ struct moxart_dmadev {
> >  	unsigned int			irq;
> >  };
> >  
> > -struct moxart_filter_data {
> > -	struct moxart_dmadev		*mdc;
> > -	struct of_phandle_args		*dma_spec;
> > -};
> > -
> >  static const unsigned int es_bytes[] = {
> >  	[MOXART_DMA_DATA_TYPE_S8] = 1,
> >  	[MOXART_DMA_DATA_TYPE_S16] = 2,
> > -- 
> > 2.45.0
> > 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/