Received-SPF: pass (google.com: domain of linux-kernel+bounces-181229-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240516141418.25345-1-jim.cromie@gmail.com> <4a77b3a77db293acba504914af220d8b8d644616.camel@perches.com>
In-Reply-To: <4a77b3a77db293acba504914af220d8b8d644616.camel@perches.com>
From: jim.cromie@gmail.com
Date: Thu, 16 May 2024 09:20:12 -0600
Message-ID: <CAJfuBxxEgCT+4SVAxoWb1xvAqhgij489=z+FH9iuXwYksm-RWA@mail.gmail.com>
Subject: Re: [PATCH 1/1] checkpatch: allow multi-statement declarative macros.
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, akpm@linuxfoundation.org, 
	Andy Whitcroft <apw@canonical.com>, Dwaipayan Ray <dwaipayanray1@gmail.com>, 
	Lukas Bulwahn <lukas.bulwahn@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 16, 2024 at 8:43=E2=80=AFAM Joe Perches <joe@perches.com> wrote=
:
>
> On Thu, 2024-05-16 at 08:14 -0600, Jim Cromie wrote:
> > Declarative macros, which declare/define storage (at either file or
> > function scope), cannot be wrapped in do-while statements.  So
> > checkpatch advice is incorrect here.
> >
> > The code has an $exceptions regex which allows multiple statements
> > based on the macro name, etc; /DECLARE_PER_CPU|DEFINE_PER_CPU/ are
> > currently accepted, widen those to accept /DECLARE|DEFINE/.
>
> It seems this exempts too large a number of these macros
>
> $ git grep -P '^\s*\#\s*define\s+\w*(?:DECLARE|DEFINE)\w*'|wc -l
> 5075
>

wow, thats more than Id have thought.

> How about somehow limiting these exemptions more strictly?

agreed.  I'll just add my 1 exceptional macro name.
resending shortly.