Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp371486lqo; Thu, 16 May 2024 08:37:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXcHJi1DdmG4V4BECkxnOZ6ZZZnJN3E55TKPEElPDPtjJY+obHlfTt3tySjJPjmYoD7j8p9eGK3QExyBFyaQ6XuKbFOzfOfo/MK3ti4vg== X-Google-Smtp-Source: AGHT+IE35gjIUfQrAdl3VUb6X09GV3/3uAA2yZVGOjEnb31brXtt4cT9nuo69ve8+HRA+l2Huxi8 X-Received: by 2002:ac8:5708:0:b0:43a:bcee:1124 with SMTP id d75a77b69052e-43dfdb91a21mr182413561cf.45.1715873833771; Thu, 16 May 2024 08:37:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715873833; cv=pass; d=google.com; s=arc-20160816; b=i34cP08W/pMS7NTOgsaIdpbKqgLk3TRFvYjOA02WnYZOY47UJvzCjoJr/nZSdDhDw2 lqEcRjfS1jrC8pehCd/zeGN+gky3n57oXM5phbWbi39z916KXhsSqud/YInXEey0FvK8 BSYmYGyvO2DybqcdfihTfdT3tbDAjWmJ3OmfxsdeJzBHCpkDVtZjPLcSxCmbyMOXKwjs sStXAIpNl9B7pUEHLBjPJaCucCFD9PG+FfRnvb0oerIM79MpKiXXLrf2WF3F3j4v1xC7 7G5Lc+N7kV/NPxfwnCAYg9MAUt41w3atq5YZllFrs0AVLiToJcAHwURSyda6FeiGBVKs qKwQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=CkkoYW/WrNDScyDqJtcJP20SigSwuFPwGx5apzp7mAo=; fh=6nwcRK+CZfuiJ424hPNAfsnS/ShnOo4osuhsYLXwebY=; b=O5URfmGbtrT9wRwoa7O4fxp5qTHFC0qbU/yzbiOf6LU4bny0SYJ/5necg3KVfWAouF i9jXEJQi9qwoEsXEFcoOvN7mOvxjE1uRjsoyJjYyhewDsFxYbjZZ81ovR+oaKjYYamip 5WWwyvOgSw86JIu8Ta9Zkztch6xyD5nhU7H0xnniEu2vtfDne2W9/cLuMOIn69ckGQvB 67N02E9Cxb/Bis5Zu6KSJfp0BKY22nJ6gVdI/Ze2OVQrLuKzPM1D651jQsXpJKBFlvbu cS3DRhbKUFY/z5Kv3zaY8VsdwwKfbTZdiLsYxxOiUXSWpuKXWfzAha7DSDjlPGf1zWoK Bj0g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=V7rMvlxm; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-181255-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181255-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-43df56d56d5si166547411cf.676.2024.05.16.08.37.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 May 2024 08:37:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-181255-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=V7rMvlxm; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-181255-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181255-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6CA9A1C20D47 for ; Thu, 16 May 2024 15:37:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E373B14D458; Thu, 16 May 2024 15:37:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="V7rMvlxm" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A497143895; Thu, 16 May 2024 15:36:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715873820; cv=none; b=rpqUM4Kd0Xx7Vv51v7vWoC1lHKGqRxGiKqAY/LPjPIvRafFE5AY5wFwn+wbMuoAIkzM1is6g0CungBrTPf4vY4grZqvYwrtbw5SUBgkYAFlsYwe0pI4gNBBBFOJ90lqQlRKcMSFHJdfRe7cZzHyJZCImtDn4Cn67jfO8I9fSQMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715873820; c=relaxed/simple; bh=CqE/9MPGEX1Q+0v3bBKi5xj+QVnxFpy5ipH8pa0wvm4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IYiIsHjbuijzUz2Wg1BfUqHgYrOYK8typRSXT2cH3pbjkxeyvJHEZ9s2UqoszKxS+bp+7MdVkgAvEwbfEwlPxknMe0rA3iBppvwZEmO4gfCFzK9PiRNrI1BpiDnmMYTC6CFzw+5qSW8WXc5bhNXaacPQLZyiwCWnYwOLucBg2WY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=V7rMvlxm; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715873818; x=1747409818; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=CqE/9MPGEX1Q+0v3bBKi5xj+QVnxFpy5ipH8pa0wvm4=; b=V7rMvlxm/CHEOpZM2oCWP4aK1EBHlgTidYhkB2CcwhaGPE2SrPN6B2SD mOt1zrXszPkZQ/rF045zV3jC5PeERXNk0sHdcCvwsQd9YNd7NJBwT6Raw igJq0ypcwg/eOJ6EbE7f23CwbHEjbftQoWfog9VbgYs5BNVZ4MWcbCzsc z2jsyTgW0trRnrGxqDx+yOg6tlsW71WRfvKdO30U/W+4OA2HlYhZzShDt zBwIs4hRHqGOgWz9OIUBxgr8jWdOXA5IOj1+SHE9QqZWsaUaF5DjdGXYN lZktghU+dWm7TM0CD2ik1OkWYkYoVtOmr4OMOIXZ7opWieUpeRPTK4LgT Q==; X-CSE-ConnectionGUID: RrWl/izdSEibeeAvpzc6Uw== X-CSE-MsgGUID: 2i1PfF/VTzau73vy3QTArA== X-IronPort-AV: E=McAfee;i="6600,9927,11074"; a="22597316" X-IronPort-AV: E=Sophos;i="6.08,164,1712646000"; d="scan'208";a="22597316" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2024 08:36:57 -0700 X-CSE-ConnectionGUID: PNojzY0sQau7aYd9d68+Ew== X-CSE-MsgGUID: yr9pS+I5Rv+Yrw9ang7V7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,164,1712646000"; d="scan'208";a="31475610" Received: from angaikwa-mobl1.amr.corp.intel.com (HELO [10.212.163.41]) ([10.212.163.41]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2024 08:36:57 -0700 Message-ID: Date: Thu, 16 May 2024 08:36:56 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 24/27] KVM: x86: Enable CET virtualization for VMX and advertise to userspace To: Sean Christopherson , Weijiang Yang Cc: rick.p.edgecombe@intel.com, pbonzini@redhat.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, chao.gao@intel.com, mlevitsk@redhat.com, john.allen@amd.com References: <20240219074733.122080-1-weijiang.yang@intel.com> <20240219074733.122080-25-weijiang.yang@intel.com> <39b95ac6-f163-4461-93f3-eaa653ab1355@intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/16/24 07:39, Sean Christopherson wrote: >> We synced the issue internally, and got conclusion that KVM should honor host >> IBT config. In this case IBT bit in boot_cpu_data should be honored.  With >> this policy, it can avoid CPUID confusion to guest side due to host ibt=off >> config. > What was the reasoning? CPUID confusion is a weak justification, e.g. it's not > like the guest has visibility into the host kernel, and raw CPUID will still show > IBT support in the host. I'm basically arguing for the path of least resistance (at least to start). We should just do what takes the least amount of code for now that results in mostly sane behavior, then debate about making it perfect later. In other words, let's say the place we'd *IDEALLY* end up is that guests can have any random FPU state which is disconnected from the host. But the reality, for now, is that the host needs to have XFEATURE_CET_USER set in order to pass it into the guest and that means keeping X86_FEATURE_SHSTK set. If you want guest XFEATURE_CET_USER, you must have host X86_FEATURE_SHSTK ... for now.