Received-SPF: pass (google.com: domain of linux-kernel+bounces-181372-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240516090541.4164270-2-ardb+git@google.com> <FBF468D5-18D6-4D29-B6A2-83A0A1998A05@akamai.com>
In-Reply-To: <FBF468D5-18D6-4D29-B6A2-83A0A1998A05@akamai.com>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Thu, 16 May 2024 19:30:47 +0200
Message-ID: <CAMj1kXG1TLKR1ukg7Vn3rgAC2opL1LN6EX9L9XVxZQ3s+6wuBQ@mail.gmail.com>
Subject: Re: [PATCH] x86/efistub: Omit physical KASLR when memory reservations exist
To: "Chaney, Ben" <bchaney@akamai.com>
Cc: Ard Biesheuvel <ardb+git@google.com>, 
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>, "keescook@chromium.org" <keescook@chromium.org>, 
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "x86@kernel.org" <x86@kernel.org>, 
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Thu, 16 May 2024 at 19:29, Chaney, Ben <bchaney@akamai.com> wrote:
>
> > +static efi_status_t parse_options(const char *cmdline)
> > +{
> > + static const char opts[][14] = {
> > + "mem=", "memmap=", "efi_fake_mem=", "hugepages="
> > + };
> > +
>
> I think we probably want to include both crashkernel and pstore as arguments that can disable this randomization.
>

The existing code in arch/x86/boot/compressed/kaslr.c currently does
not take these into account, as far as I can tell.