Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp458886lqo; Thu, 16 May 2024 10:57:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXVKu+hygKg9TxfNdD0hlki5tK+EgYdUae7WLC1BXpDS+Eu9Bvo+yuFOH/RJhn+Zwi5zzzwk0e5dxwdU1S1Xq1aTcHuvmnAFp9EM7MH+A== X-Google-Smtp-Source: AGHT+IH8Qj3qLwaof3eV+aWkVON92r94ZJwr4fUKcOrHC73ZdO7sGc5hsUBE9anxkYathsWCZGXu X-Received: by 2002:a05:6a21:31c8:b0:1b0:3190:96d6 with SMTP id adf61e73a8af0-1b0319097b5mr1277645637.34.1715882275263; Thu, 16 May 2024 10:57:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715882275; cv=pass; d=google.com; s=arc-20160816; b=Nk3Ich5FfZBfdubDZvqMpslmFZK3hQi3wiSuKRp2yCYKHhJ3eczeQ8DadUWdSnCIPK 2WLDqRUAn2tYH90ayEO/zSmYsZrppAh50NVroO1R4C90mrflE4WDva51Ghf/0kFFsogZ SA7KSZxd3/CBAJ18gYU+cXc5pBDQsIagJZVIXghWqHNc/fMExexi+B3y9C/lUXIgk/ow WticstcBMy+FAMafCiSW8xJiPDhOAmrP8Lrj8+AbNj++TdNgRV0RsRiDYlaJ+YaH8An8 +0aoyUcZh8CozBwKtUdPATCQerJqFVqCeOZCfMvZst6FhF+paylyjeSlrFoZp4hLtXG+ umGA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=1Yk3zlTkgWi4AihMGcc8aW5GoxToOm2dN986l+VV/uk=; fh=7qBr56u35TFvxtnaxEF1yo1WfgwSWBjDaw3HP+QqFzM=; b=spJ2JGyFTiEvPsB5jBa+w26DuDWPES68aAQ+f6lAQ7pilomeUQHi7ruY5b6pMCk+8M ctwAGcmUivVg8/UZfGr+l7uw/OkydjS9Pw+0SnY1rbzfv+5CqAiO8hacLynN+1OZd3yA ReD9+kOoHIEnZM1rl2rV8FPGNtw0QuaCEnnw7ksAL6Syt3HwQaXX3XdMEvz3gTEZuNlG F8jPvUTeRs+vkkxTWCYd6Q3pQ0eUgV9G0MVLF9cprK7QUvszB8LtL1XxALaDEYJKBSdo wVNzsU3q25yOa5ThXW/TVBA+r1YZO6OlpJLWqvbvgicf/EM+7lXKIeyekqKE8SfSB4g7 82mA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=BB4dzfiV; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-181423-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181423-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-658d03e8a98si2305850a12.509.2024.05.16.10.57.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 May 2024 10:57:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-181423-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=BB4dzfiV; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-181423-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181423-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0999EB21EDD for ; Thu, 16 May 2024 17:57:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 678E3156864; Thu, 16 May 2024 17:57:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="BB4dzfiV" Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EFE614D457 for ; Thu, 16 May 2024 17:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715882265; cv=none; b=kCHE/v30cGaP1tsgaXRv4gpNnIY0duqCjavfAPO/XSVrnuzHzQ8SVaDSU2ma1P3MLU5Tkz4SmqgHQqp6XbFnpFQ9mnafkYvEh8SEApvH6V/v8BCevO2ACLXFIIGgIiwOgvtpXfZ1E1tDrF/8BgSDw2SybY8rJKCSsXc1TyVTCdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715882265; c=relaxed/simple; bh=QAHh4f+z1gl2UBJfmsuQjakgT8ESP7RS8QoJaVPvkgg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lhRCIwIOTfGa4t7qoRPYAfJpgp+fWTq0xPveoC5VKd6PfpFVgURgy63PJ4y4Eg1nupL5mM/l8vGOLY2kUPVa/4lAN28UvtlrSA0+wACwOEDD+SVka2tYqdOFpO18btA9CJl0Is/8AEaM5X4DIJdAtiTlUdJURva5qKTB/PIqPMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=BB4dzfiV; arc=none smtp.client-ip=209.85.166.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-7e1bf0e9ab5so64261339f.3 for ; Thu, 16 May 2024 10:57:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715882263; x=1716487063; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1Yk3zlTkgWi4AihMGcc8aW5GoxToOm2dN986l+VV/uk=; b=BB4dzfiVUpA15C8zurGm/Q8nV3jJI0EWqrW5qXAVphOWhyZEU5X7NWCgDpQrM2ThKw t2mkf1JhcMAlvcNOC7hCcSR+nrZr072zeACeJbCxnsc0kL9jCEKnYI8uG3hDvMIEfFLY BQ0JZPMn16hLusCYUENX25dhFG3rHnsH3a7Ok= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715882263; x=1716487063; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1Yk3zlTkgWi4AihMGcc8aW5GoxToOm2dN986l+VV/uk=; b=cuIg+8TH90HL21kdjVjtX0OSjUfGRi8chJQqtU3QCQtLYJNg+u2JyFckUJPgkVRSTN Dr4YhC36QdgsaxvEzEtWCZSr1ylCXQr/zn8jNhu2Wr8O+IowUboTdXs6yvkR3FPOF+i2 W+cIYXrlDRw3Jemn5ku2sSB/gBArcipNSVU/HrzQLiYqLcZxKP1Xx+Nf6nSZG1ahM5s9 /6HfS4myVusSlvgyBkx1D5mdNA3+qfvarTULS6oOHpOHkPWeqElaRVux29hf3WYUE2Od c+Kku0kVD1DtwtKrbF4x5qs6qyXBigKIQKdbYd5h/0YGyreEhXQ+XFwm4Unf67UQCsZ6 vPIw== X-Gm-Message-State: AOJu0Yz95PKhVIvD0kui6yoaB3HVV8jfDnsj9HxHEUTZJT7sdRodcGkL feQEdRAI396xXsbeVa7QQzQTiAll5SBh3BwtkmcPNemBgClTIGYrfcXCsk8nLmk6l/aP4KyfU8M = X-Received: by 2002:a05:6e02:216f:b0:36c:c8f:89b with SMTP id e9e14a558f8ab-36cc148e4f7mr235882165ab.11.1715882263135; Thu, 16 May 2024 10:57:43 -0700 (PDT) Received: from timvp-p620-9115096.bld.corp.google.com ([2620:15c:183:200:93ff:e692:b652:436e]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4893703bfd8sm4301631173.47.2024.05.16.10.57.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 May 2024 10:57:42 -0700 (PDT) From: Tim Van Patten To: LKML Cc: alexander.deucher@amd.com, prathyushi.nangia@amd.com, Tim Van Patten , =?UTF-8?q?Christian=20K=C3=B6nig?= , Daniel Vetter , David Airlie , Felix Kuehling , Ikshwaku Chauhan , Le Ma , Lijo Lazar , Mario Limonciello , "Pan, Xinhui" , "Shaoyun.liu" , Shiwu Zhang , Srinivasan Shanmugam , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1 Date: Thu, 16 May 2024 11:57:25 -0600 Message-ID: <20240516115721.1.I8d413e641239c059d018d46cc569048b813a5d9b@changeid> X-Mailer: git-send-email 2.45.0.rc1.225.g2a3ae87e7f-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tim Van Patten The following commit updated gmc->noretry from 0 to 1 for GC HW IP 9.3.0: commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") This causes the device to hang when a page fault occurs, until the device is rebooted. Instead, revert back to gmc->noretry=0 so the device is still responsive. Fixes: 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") Signed-off-by: Tim Van Patten --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c index be4629cdac049..bff54a20835f1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c @@ -876,7 +876,6 @@ void amdgpu_gmc_noretry_set(struct amdgpu_device *adev) struct amdgpu_gmc *gmc = &adev->gmc; uint32_t gc_ver = amdgpu_ip_version(adev, GC_HWIP, 0); bool noretry_default = (gc_ver == IP_VERSION(9, 0, 1) || - gc_ver == IP_VERSION(9, 3, 0) || gc_ver == IP_VERSION(9, 4, 0) || gc_ver == IP_VERSION(9, 4, 1) || gc_ver == IP_VERSION(9, 4, 2) || -- 2.45.0.rc1.225.g2a3ae87e7f-goog