Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp462626lqo; Thu, 16 May 2024 11:03:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVTxVObRpUF5SAcS/t1usk3Mhaj5A+Kke1DYHzVyj+8CL2IcA7QHuUV/JsUTuuZHoXTPTShVgddynvke+1VNmTven/JQxrU4rK4ZHDIsw== X-Google-Smtp-Source: AGHT+IEq8NlVDFCJ4OmfJYPouIYHjgwVhsdTPvtHoNo1gzBpRs7KOUDVlckikOdthcEAqkCJuFoN X-Received: by 2002:ae9:e014:0:b0:792:8c06:cd8 with SMTP id af79cd13be357-792c7610199mr2080290185a.71.1715882604735; Thu, 16 May 2024 11:03:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715882604; cv=pass; d=google.com; s=arc-20160816; b=JrU+9Ap+m6s78hig8z1k9TjG5a7wMbVVsPoMWRjW2yPqqWhVNY3maqrOGKDYD/5h0y 7ckIvn/kk1ewuBPpB0jKMIaLkY7NPCfntOEtRoi4tgOdWAaLBvFYrJOhGncn7wOw4TNB omc5H7a7+1OC4F+e4BtetRfp2ffWvhJbNcqfAvKfz4QItBCHfBcntyg/2yBI4xmZScbG LNl9XH8A3Venb8WVo+tSFzOVjfS/lpSfy0yEhGMvr0pV4WAWXF0Z+WVXhpI0IwmYRtmF 6KSr9pFTywkQYVXtRPN6gTbQlzWUKFRRKMkPif7RFbVzhmdiFcPwJXBQa+UOCCKaV5bA C9Eg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:in-reply-to:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=o+GF2dgdNZULsIROTgLVzJ5vpJUiJG/IGiwctfeNVZQ=; fh=QZG+P2ihl50thjW3GcD0A9YtHJaciYoTPZapdZHe2nk=; b=bJ759OgIWq4blfJiu7vDVY0nqLDGVu7DbVw9KPenoPUcxLr7REr+uLuv7t8raXGrcz NFRWMG1QQx4WB/FLiUByWfSsgNCFpQ9AfEPeq37Kn0x0t2FJzzZLg36jxlK77MHmmzfp FbuYi8l4ZpzcXTYXJ6c9uyoxUDalMVEaXroMQutoe4c+cCdalgslP1FM9GQj6T4k6Eih cjYxuJYqRBBvIz5jzEIOq/0h5AY6d8eDYFbZAFDLVUDF0zq5N1JclsCibb5vIv8+7pvC NfpY12waEoBT4jVv85D/VA+OLX1jK4uy6grJFGZpFqxrtoCTMPiox6EwN11xov0uHlrJ rk1Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b=VOjdr9Vb; dkim=pass header.i=@fluxnic.net header.s=2016-12.pbsmtp header.b=kKT6QT4K; arc=pass (i=1 spf=pass spfdomain=fluxnic.net dkim=pass dkdomain=pobox.com dkim=pass dkdomain=fluxnic.net); spf=pass (google.com: domain of linux-kernel+bounces-181426-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181426-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id af79cd13be357-792bf30bc89si1857391885a.353.2024.05.16.11.03.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 May 2024 11:03:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-181426-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b=VOjdr9Vb; dkim=pass header.i=@fluxnic.net header.s=2016-12.pbsmtp header.b=kKT6QT4K; arc=pass (i=1 spf=pass spfdomain=fluxnic.net dkim=pass dkdomain=pobox.com dkim=pass dkdomain=fluxnic.net); spf=pass (google.com: domain of linux-kernel+bounces-181426-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181426-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 745021C21CE7 for ; Thu, 16 May 2024 18:03:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5D0A4156F20; Thu, 16 May 2024 18:03:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="VOjdr9Vb"; dkim=pass (1024-bit key) header.d=fluxnic.net header.i=@fluxnic.net header.b="kKT6QT4K" Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E50101EF12; Thu, 16 May 2024 18:03:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.108.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715882593; cv=none; b=mqFAkiML5AjbCcTiQvis6PzGjZx35tHy2i4A3g+DQZ1vzWC9DDH/BgBics6trMUhBEgBI4T+tQaExg0az0gUSnYq3EAXhnDDoxRP1foix5cOptEwpYfkD2SvKm13jAh4Ly532J2uur06AaX/Y0n8QAwXocHeKEhOdgq27AJpuVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715882593; c=relaxed/simple; bh=XJ0wq7P6oGLF/Wn9fqoUjoZ83n5V3K97kIES94DrOro=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=kRODBWzQ6WkP+OXNG6sizA7L1BzOzDqIWqfWzYJEu+ix5YHtRjxQze2CyBlz1CF319xyC/k//O9NjXQxOlJFG0Nob9JnQ8UYXXYY7O5Zm85LMh/3RG2uY5uT+JLDgo9Lj6qgANkeRPUyDPuNhEYgBu/8k7QR/sQ9GVIJYdYSENU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fluxnic.net; spf=pass smtp.mailfrom=fluxnic.net; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b=VOjdr9Vb; dkim=pass (1024-bit key) header.d=fluxnic.net header.i=@fluxnic.net header.b=kKT6QT4K; arc=none smtp.client-ip=64.147.108.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fluxnic.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fluxnic.net Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id CB39527021; Thu, 16 May 2024 14:03:02 -0400 (EDT) (envelope-from nico@fluxnic.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=date:from :to:cc:subject:in-reply-to:message-id:references:mime-version :content-type; s=sasl; bh=XJ0wq7P6oGLF/Wn9fqoUjoZ83n5V3K97kIES94 DrOro=; b=VOjdr9VbYqvAhJ1O1wr5RtgQWmrKG5y14NFIMLx2SWbJt8adLgVZAk S3KUinvn9IcpVeKYUmFJZSXEidYH5xTMtW55SJUnzhniNdbyv/p4hDrEWBS5NwMu pS5ElyQ1/3Ls0f0039ZXvxZY9hhGpnm9sUn9FIeyWYnBAz4JS0Nx0= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id BCCF727020; Thu, 16 May 2024 14:03:02 -0400 (EDT) (envelope-from nico@fluxnic.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=fluxnic.net; h=date:from:to:cc:subject:in-reply-to:message-id:references:mime-version:content-type; s=2016-12.pbsmtp; bh=XJ0wq7P6oGLF/Wn9fqoUjoZ83n5V3K97kIES94DrOro=; b=kKT6QT4KePcP5IVss4cXNVmwc84T0rvzFBI5csD3UX3I3klIToJYmEK4zorZzLg7viXK/g/YEOfGVJwwToo7jExogWuyhxCTCCNPDEfxTSJccvxS2BU5hJjH6QiXYyh6dXrS30vm42B7CPdDyw6nkOOfIKXrnr4qD5cZk9Cj5nQ= Received: from yoda.fluxnic.net (unknown [184.162.15.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 3607A2701C; Thu, 16 May 2024 14:03:02 -0400 (EDT) (envelope-from nico@fluxnic.net) Received: from xanadu (unknown [IPv6:fd17:d3d3:663b:0:9696:df8a:e3:af35]) by yoda.fluxnic.net (Postfix) with ESMTPSA id 17546CAFE2C; Thu, 16 May 2024 14:03:01 -0400 (EDT) Date: Thu, 16 May 2024 14:03:00 -0400 (EDT) From: Nicolas Pitre To: Andrew Lunn cc: Thorsten Blum , Arnd Bergmann , davem@davemloft.net, edumazet@google.com, glaubitz@physik.fu-berlin.de, kuba@kernel.org, linux-kernel@vger.kernel.org, lkp@intel.com, netdev@vger.kernel.org, pabeni@redhat.com Subject: Re: [PATCH v2] net: smc91x: Fix pointer types In-Reply-To: <0efd687d-3df5-49dd-b01c-d5bd977ae12e@lunn.ch> Message-ID: <811pn38n-n071-6qsn-50qr-096048q07o40@syhkavp.arg> References: <20240516155610.191612-3-thorsten.blum@toblux.com> <0efd687d-3df5-49dd-b01c-d5bd977ae12e@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Pobox-Relay-ID: 8969512C-13AE-11EF-BFA2-78DCEB2EC81B-78420484!pb-smtp1.pobox.com On Thu, 16 May 2024, Andrew Lunn wrote: > You could add a follow up patch which removes the > void __iomem *__ioaddr = ioaddr; lines and uses lp->base. > The code will then be more uniform. Beware, It is sometimes overridden with __ioaddr = lp->datacs. Nicolas